You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by li...@inuus.com on 2010/10/04 17:35:02 UTC
Re: Updated few checks in ConcatVisitor, to increase its coverage. (issue2085042)
lgtm, if you could add a follow-on test for conditional comments I'd
appreciate it.
http://codereview.appspot.com/2085042/
Re: Updated few checks in ConcatVisitor, to increase its coverage. (issue2085042)
Posted by MHarish Mnsatya <sa...@gmail.com>.
Thanks Paul.
On 4 October 2010 21:39, Paul Lindner <li...@inuus.com> wrote:
> k thx, ship it!
>
>
> On Mon, Oct 4, 2010 at 8:49 AM, Gagandeep singh <ga...@gmail.com>
> wrote:
> >
> http://codereview.appspot.com/2085042/diff/27001/java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/ConcatVisitorTest.java
> > has nice tests for conditional and non conditional comments.
> >
> > On Mon, Oct 4, 2010 at 9:05 PM, <li...@inuus.com> wrote:
> >>
> >> lgtm, if you could add a follow-on test for conditional comments I'd
> >> appreciate it.
> >>
> >> http://codereview.appspot.com/2085042/
> >
> >
>
>
>
> --
> Paul Lindner -- lindner@inuus.com -- linkedin.com/in/plindner
>
Re: Updated few checks in ConcatVisitor, to increase its coverage. (issue2085042)
Posted by Paul Lindner <li...@inuus.com>.
k thx, ship it!
On Mon, Oct 4, 2010 at 8:49 AM, Gagandeep singh <ga...@gmail.com> wrote:
> http://codereview.appspot.com/2085042/diff/27001/java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/ConcatVisitorTest.java
> has nice tests for conditional and non conditional comments.
>
> On Mon, Oct 4, 2010 at 9:05 PM, <li...@inuus.com> wrote:
>>
>> lgtm, if you could add a follow-on test for conditional comments I'd
>> appreciate it.
>>
>> http://codereview.appspot.com/2085042/
>
>
--
Paul Lindner -- lindner@inuus.com -- linkedin.com/in/plindner
Re: Updated few checks in ConcatVisitor, to increase its coverage. (issue2085042)
Posted by Gagandeep singh <ga...@gmail.com>.
http://codereview.appspot.com/2085042/diff/27001/java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/ConcatVisitorTest.javahas
nice tests for conditional and non conditional comments.
On Mon, Oct 4, 2010 at 9:05 PM, <li...@inuus.com> wrote:
> lgtm, if you could add a follow-on test for conditional comments I'd
> appreciate it.
>
>
> http://codereview.appspot.com/2085042/
>