[GitHub] [pinot] dongxiaoman commented on a change in pull request #8271: Apply TlsConfig to secure GrpcBrokerRequestHandler properly

[GitBox <gi...@apache.org>]

dongxiaoman commented on a change in pull request #8271:
URL: https://github.com/apache/pinot/pull/8271#discussion_r817916750



##########
File path: pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java
##########
@@ -237,25 +237,22 @@ public void start()
             Helix.DEPRECATED_ENABLE_CASE_INSENSITIVE_KEY, false);
     TableCache tableCache = new TableCache(_propertyStore, caseInsensitive);
     // Configure TLS for netty connection to server
-    TlsConfig tlsDefaults = TlsUtils.extractTlsConfig(_brokerConf, Broker.BROKER_TLS_PREFIX);
+    TlsConfig tlsDefaults = null;
+    if (_brokerConf.getProperty(Broker.BROKER_NETTYTLS_ENABLED, false)) {

Review comment:
       Right now Broker can have only one BrokerRequestHandler. We will use the same `Broker.BROKER_NETTYTLS_ENABLED` flag to enable gRPC server secure flag.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org