[GitHub] [incubator-doris] imay commented on a change in pull request #3738: [Bug]fix the crash of checksum task #3735

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #3738:
URL: https://github.com/apache/incubator-doris/pull/3738#discussion_r433283161



##########
File path: be/src/olap/row.h
##########
@@ -59,6 +59,10 @@ bool equal_row(const std::vector<uint32_t>& ids,
 template<typename LhsRowType, typename RhsRowType>
 int compare_row(const LhsRowType& lhs, const RhsRowType& rhs) {
     for (uint32_t cid = 0; cid < lhs.schema()->num_key_columns(); ++cid) {
+        //because the num_column_ids include the column of double/float type

Review comment:
       This function is used in many senarios. And changing here to fix the problem is not a good idea.
   Why not to make column in the schema is not NULL.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org