You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by stefanobaghino <gi...@git.apache.org> on 2016/02/18 09:59:47 UTC
[GitHub] flink pull request: [FLINK-3438] ExternalProcessRunner fails to de...
GitHub user stefanobaghino opened a pull request:
https://github.com/apache/flink/pull/1665
[FLINK-3438] ExternalProcessRunner fails to detect ClassNotFound exception because of locale settings
This should be regarded as a temporary solution to this issue in particular. See the discussion going on at [[FLINK-3438]].
[FLINK-3438]: https://issues.apache.org/jira/browse/FLINK-3438
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/radicalbit/flink 3438
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1665.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1665
----
commit 12b6659542c7deafc05ef36cfcd9d7ac99681164
Author: Stefano Baghino <st...@baghino.me>
Date: 2016-02-17T16:58:53Z
[FLINK-3438] ExternalProcessRunner fails to detect ClassNotFound exception because of locale settings
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3438] ExternalProcessRunner fails to de...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1665
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3438] ExternalProcessRunner fails to de...
Posted by stefanobaghino <gi...@git.apache.org>.
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1665#issuecomment-187248829
Running the test locally with the same `PROFILE` as the failing tests do not yield the same results (i.e. all tests pass). Is there a way to determine if this was just a hiccup in the CI environment? Meanwhile, I'm rerunning the tests on our fork.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3438] ExternalProcessRunner fails to de...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1665#issuecomment-185732111
Should be okay for the tests.
Just make sure you don't try to parse the returned stderr stream, but simply take non-empty stream as an exception with a copy of the stderr data.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3438] ExternalProcessRunner fails to de...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1665#issuecomment-185636882
Anyone against merging this as a (maybe temporary) solution?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3438] ExternalProcessRunner fails to de...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1665#issuecomment-187250281
The test failure looks unrelated to this fix.
+1 to merge this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3438] ExternalProcessRunner fails to de...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1665#issuecomment-187608866
Thanks for your contribution @stefanobaghino. Will merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3438] ExternalProcessRunner fails to de...
Posted by stefanobaghino <gi...@git.apache.org>.
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1665#issuecomment-185756748
I'm going into the direction proposed by @StephanEwen, the change looks trivial.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---