[GitHub] [logging-log4net] NicholasNoise commented on pull request #59: Update build system

[GitBox <gi...@apache.org>]

NicholasNoise commented on pull request #59:
URL: https://github.com/apache/logging-log4net/pull/59#issuecomment-686386567


   >  Ok, the breaking change for the removed `ImmediateFlush` property in .NET Standard 1.3 is not fixed. But I think that's ok since it was not functional anyway.
   
   I have failed to find a _good_ way to test `DebugAppender` compiled for netstandard2.0, because there are no `Debug.Listeners` despite [documentation remarks](https://docs.microsoft.com/en-us/dotnet/api/system.diagnostics.trace.listeners?view=netcore-3.1#remarks):
   ```
   The Listeners collection is shared by both the Debug and the Trace classes; adding a trace listener to either class adds the listener to both.
   ```
   But actually `Debug.Write` method does not use `Listeners`, so there are no way to test... I recommend to replace `DebugAppender` for `TraceAppender`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org