You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2018/04/28 11:21:12 UTC

[GitHub] rafaelweingartner commented on issue #2598: CLOUDSTACK-10360: Change the method name.

rafaelweingartner commented on issue #2598: CLOUDSTACK-10360: Change the method name.
URL: https://github.com/apache/cloudstack/pull/2598#issuecomment-385167494
 
 
   I would say that Travis and Jenkins validation are enough for this kind of PR. Of course, we still need reviews.
   
   @BruceKuiLiu your initiative is good. I have seen @DaanHoogland comments in your PRs, and he has some good points. Please, do not take them personally. It is natural to have different opinion/views and they are essential to create discussion and really achieve improvements and code quality.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services