[GitHub] mhenke1 commented on a change in pull request #3343: Support time-series DB using Kamon Tag, and optional granular metric.

[GitBox <gi...@apache.org>]

mhenke1 commented on a change in pull request #3343: Support time-series DB using Kamon Tag, and optional granular metric.
URL: https://github.com/apache/incubator-openwhisk/pull/3343#discussion_r170515193
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/common/Logging.scala
 ##########
 @@ -164,27 +164,47 @@ private object Logging {
     if (simpleName.endsWith("$")) simpleName.dropRight(1)
     else simpleName
   }
-
 }
 
 private object Emitter {
   val timeFormat = DateTimeFormatter.ofPattern("yyyy-MM-dd'T'HH:mm:ss.SSS'Z'").withZone(ZoneId.of("UTC"))
 }
 
-case class LogMarkerToken(component: String, action: String, state: String) {
+/**
+ * Used to record log message and make a metric name.
+ *
+ * @param component Component like invoker, controller, and docker. It is defined in LoggingMarkers.
+ * @param action Action of the component.
+ * @param state State of the action.
+ * @param macroTags macroTags should be used for tags with a bounded number of permutations.
 
 Review comment:
   Please add an example for such a bounded tag (e.g. http staus code)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services