You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Karl Fogel <kf...@red-bean.com> on 2008/03/21 22:59:29 UTC
Oddity in r29895 (ra_serf error handling tweak).
r29895 contains this patch:
--- subversion/libsvn_ra_serf/update.c (revision 29894)
+++ subversion/libsvn_ra_serf/update.c (revision 29895)
@@ -2293,6 +2293,12 @@
}
if (status)
{
+ svn_error_t *err = parser_ctx->error;
+
+ if (err)
+ svn_error_clear(sess->pending_error);
+
+ SVN_ERR(parser_ctx->error);
SVN_ERR(sess->pending_error);
[...]
Is there some reason to declare the new 'err' variable? Why not just
do:
if (parser_ctx->error)
svn_error_clear(sess->pending_error);
? (Noticed this while reviewing r29895 for 1.5.x/STATUS.)
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Oddity in r29895 (ra_serf error handling tweak).
Posted by Lieven Govaerts <sv...@mobsol.be>.
Karl Fogel wrote:
> r29895 contains this patch:
>
> --- subversion/libsvn_ra_serf/update.c (revision 29894)
> +++ subversion/libsvn_ra_serf/update.c (revision 29895)
> @@ -2293,6 +2293,12 @@
> }
> if (status)
> {
> + svn_error_t *err = parser_ctx->error;
> +
> + if (err)
> + svn_error_clear(sess->pending_error);
> +
> + SVN_ERR(parser_ctx->error);
> SVN_ERR(sess->pending_error);
> [...]
>
> Is there some reason to declare the new 'err' variable? Why not just
> do:
>
> if (parser_ctx->error)
> svn_error_clear(sess->pending_error);
No real reason, fixed in r30001. Thx.
Lieven
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org