You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/19 06:58:03 UTC
[GitHub] [flink] curcur opened a new pull request #14691: [FLINK-21018] Update checkpoint related documentation for UI
curcur opened a new pull request #14691:
URL: https://github.com/apache/flink/pull/14691
## What is the purpose of the change
Follow up of FLINK-20488 to update checkpoint related documentation for UI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14691: [FLINK-21018] Update checkpoint related documentation for UI
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14691:
URL: https://github.com/apache/flink/pull/14691#issuecomment-762651310
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c02e54d3e599a05ebb96cbb66aaade1e058da0fe",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c02e54d3e599a05ebb96cbb66aaade1e058da0fe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c02e54d3e599a05ebb96cbb66aaade1e058da0fe UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski merged pull request #14691: [FLINK-21018] Update checkpoint related documentation for UI
Posted by GitBox <gi...@apache.org>.
pnowojski merged pull request #14691:
URL: https://github.com/apache/flink/pull/14691
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14691: [FLINK-21018] Update checkpoint related documentation for UI
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14691:
URL: https://github.com/apache/flink/pull/14691#issuecomment-762651310
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14691: [FLINK-21018] Update checkpoint related documentation for UI
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14691:
URL: https://github.com/apache/flink/pull/14691#issuecomment-762651310
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c02e54d3e599a05ebb96cbb66aaade1e058da0fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12218",
"triggerID" : "c02e54d3e599a05ebb96cbb66aaade1e058da0fe",
"triggerType" : "PUSH"
}, {
"hash" : "6a766507fc023a0642ab36f6eca289e479b4b84b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12310",
"triggerID" : "6a766507fc023a0642ab36f6eca289e479b4b84b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6a766507fc023a0642ab36f6eca289e479b4b84b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12310)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14691: [FLINK-21018] Update checkpoint related documentation for UI
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14691:
URL: https://github.com/apache/flink/pull/14691#issuecomment-762643722
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit c02e54d3e599a05ebb96cbb66aaade1e058da0fe (Tue Jan 19 07:00:03 UTC 2021)
**Warnings:**
* Documentation files were touched, but no `.zh.md` files: Update Chinese documentation or file Jira ticket.
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-21018).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #14691: [FLINK-21018] Update checkpoint related documentation for UI
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #14691:
URL: https://github.com/apache/flink/pull/14691#discussion_r563686026
##########
File path: docs/ops/monitoring/checkpoint_monitoring.md
##########
@@ -74,7 +74,8 @@ For subtasks there are a couple of more detailed stats available.
- **Sync Duration**: The duration of the synchronous part of the checkpoint. This includes snapshotting state of the operators and blocks all other activity on the subtask (processing records, firing timers, etc).
- **Async Duration**: The duration of the asynchronous part of the checkpoint. This includes time it took to write the checkpoint on to the selected filesystem. For unaligned checkpoints this also includes also the time the subtask had to wait for last of the checkpoint barriers to arrive (alignment duration) and the time it took to persist the in-flight data.
- **Alignment Duration**: The time between processing the first and the last checkpoint barrier. For aligned checkpoints, during the alignment, the channels that have already received checkpoint barrier are blocked from processing more data.
-- **Start Delay**: The time it took for the first checkpoint barrier to reach this subtasks since the checkpoint barrier has been created.
+- **Start Delay**: The time it took for the first checkpoint barrier to reach this subtask since the checkpoint barrier has been created.
+- **Unaligned Checkpoint**: Whether the checkpoint for the subtask is completed as an unaligned checkpoint. An aligned checkpoint can switch to an unaligned checkpoint if the alignment timeouts.
Review comment:
I guess we also need to update `checkpoint_monitoring.zh.md`? As you know Chinese could you do it yourself? If not, the procedure is to create a special JIRA ticket (described in the `docs/README.md`) for someone to pick up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14691: [FLINK-21018] Update checkpoint related documentation for UI
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14691:
URL: https://github.com/apache/flink/pull/14691#issuecomment-762651310
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c02e54d3e599a05ebb96cbb66aaade1e058da0fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12218",
"triggerID" : "c02e54d3e599a05ebb96cbb66aaade1e058da0fe",
"triggerType" : "PUSH"
}, {
"hash" : "6a766507fc023a0642ab36f6eca289e479b4b84b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12310",
"triggerID" : "6a766507fc023a0642ab36f6eca289e479b4b84b",
"triggerType" : "PUSH"
}, {
"hash" : "6fc385f9a2c06ea6fb022ad75baa485432391e2b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12462",
"triggerID" : "6fc385f9a2c06ea6fb022ad75baa485432391e2b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6fc385f9a2c06ea6fb022ad75baa485432391e2b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12462)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14691: [FLINK-21018] Update checkpoint related documentation for UI
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14691:
URL: https://github.com/apache/flink/pull/14691#issuecomment-762651310
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski merged pull request #14691: [FLINK-21018] Update checkpoint related documentation for UI
Posted by GitBox <gi...@apache.org>.
pnowojski merged pull request #14691:
URL: https://github.com/apache/flink/pull/14691
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #14691: [FLINK-21018] Update checkpoint related documentation for UI
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #14691:
URL: https://github.com/apache/flink/pull/14691#discussion_r563686026
##########
File path: docs/ops/monitoring/checkpoint_monitoring.md
##########
@@ -74,7 +74,8 @@ For subtasks there are a couple of more detailed stats available.
- **Sync Duration**: The duration of the synchronous part of the checkpoint. This includes snapshotting state of the operators and blocks all other activity on the subtask (processing records, firing timers, etc).
- **Async Duration**: The duration of the asynchronous part of the checkpoint. This includes time it took to write the checkpoint on to the selected filesystem. For unaligned checkpoints this also includes also the time the subtask had to wait for last of the checkpoint barriers to arrive (alignment duration) and the time it took to persist the in-flight data.
- **Alignment Duration**: The time between processing the first and the last checkpoint barrier. For aligned checkpoints, during the alignment, the channels that have already received checkpoint barrier are blocked from processing more data.
-- **Start Delay**: The time it took for the first checkpoint barrier to reach this subtasks since the checkpoint barrier has been created.
+- **Start Delay**: The time it took for the first checkpoint barrier to reach this subtask since the checkpoint barrier has been created.
+- **Unaligned Checkpoint**: Whether the checkpoint for the subtask is completed as an unaligned checkpoint. An aligned checkpoint can switch to an unaligned checkpoint if the alignment timeouts.
Review comment:
I guess we also need to update `checkpoint_monitoring.zh.md`? As you know Chinese could you do it yourself? If not, the procedure is to create a special JIRA ticket (described in the `docs/README.md`) for someone to pick up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14691: [FLINK-21018] Update checkpoint related documentation for UI
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14691:
URL: https://github.com/apache/flink/pull/14691#issuecomment-762643722
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 6fc385f9a2c06ea6fb022ad75baa485432391e2b (Fri May 28 07:13:30 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14691: [FLINK-21018] Update checkpoint related documentation for UI
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14691:
URL: https://github.com/apache/flink/pull/14691#issuecomment-762651310
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c02e54d3e599a05ebb96cbb66aaade1e058da0fe",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12218",
"triggerID" : "c02e54d3e599a05ebb96cbb66aaade1e058da0fe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c02e54d3e599a05ebb96cbb66aaade1e058da0fe Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12218)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14691: [FLINK-21018] Update checkpoint related documentation for UI
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14691:
URL: https://github.com/apache/flink/pull/14691#issuecomment-762651310
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c02e54d3e599a05ebb96cbb66aaade1e058da0fe",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12218",
"triggerID" : "c02e54d3e599a05ebb96cbb66aaade1e058da0fe",
"triggerType" : "PUSH"
}, {
"hash" : "6a766507fc023a0642ab36f6eca289e479b4b84b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6a766507fc023a0642ab36f6eca289e479b4b84b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c02e54d3e599a05ebb96cbb66aaade1e058da0fe Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12218)
* 6a766507fc023a0642ab36f6eca289e479b4b84b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14691: [FLINK-21018] Update checkpoint related documentation for UI
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14691:
URL: https://github.com/apache/flink/pull/14691#issuecomment-762651310
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c02e54d3e599a05ebb96cbb66aaade1e058da0fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12218",
"triggerID" : "c02e54d3e599a05ebb96cbb66aaade1e058da0fe",
"triggerType" : "PUSH"
}, {
"hash" : "6a766507fc023a0642ab36f6eca289e479b4b84b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12310",
"triggerID" : "6a766507fc023a0642ab36f6eca289e479b4b84b",
"triggerType" : "PUSH"
}, {
"hash" : "6fc385f9a2c06ea6fb022ad75baa485432391e2b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6fc385f9a2c06ea6fb022ad75baa485432391e2b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6a766507fc023a0642ab36f6eca289e479b4b84b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12310)
* 6fc385f9a2c06ea6fb022ad75baa485432391e2b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org