You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Colm O hEigeartaigh <co...@apache.org> on 2017/05/03 10:09:26 UTC

Re: Review Request 58799: SENTRY-1730 - Remove FileInputStream/FileOutputStream

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58799/
-----------------------------------------------------------

(Updated May 3, 2017, 10:09 a.m.)


Review request for sentry.


Bugs: SENTRY-1730
    https://issues.apache.org/jira/browse/SENTRY-1730


Repository: sentry


Description
-------

This task is to remove FileInputStream/FileOutputStream due to reasons outlined here:

https://www.cloudbees.com/blog/fileinputstream-fileoutputstream-considered-harmful


Diffs (updated)
-----

  sentry-core/sentry-core-common/src/main/java/org/apache/sentry/SentryMain.java c1518ba3 
  sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/PolicyFiles.java 4a632bc9 


Diff: https://reviews.apache.org/r/58799/diff/2/

Changes: https://reviews.apache.org/r/58799/diff/1-2/


Testing
-------


Thanks,

Colm O hEigeartaigh


Re: Review Request 58799: SENTRY-1730 - Remove FileInputStream/FileOutputStream

Posted by Na Li <li...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58799/#review173737
-----------------------------------------------------------


Ship it!




Ship It!

- Na Li


On May 3, 2017, 10:09 a.m., Colm O hEigeartaigh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58799/
> -----------------------------------------------------------
> 
> (Updated May 3, 2017, 10:09 a.m.)
> 
> 
> Review request for sentry.
> 
> 
> Bugs: SENTRY-1730
>     https://issues.apache.org/jira/browse/SENTRY-1730
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> This task is to remove FileInputStream/FileOutputStream due to reasons outlined here:
> 
> https://www.cloudbees.com/blog/fileinputstream-fileoutputstream-considered-harmful
> 
> 
> Diffs
> -----
> 
>   sentry-core/sentry-core-common/src/main/java/org/apache/sentry/SentryMain.java c1518ba3 
>   sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/PolicyFiles.java 4a632bc9 
> 
> 
> Diff: https://reviews.apache.org/r/58799/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>