You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@chemistry.apache.org by "David Caruana (JIRA)" <ji...@apache.org> on 2010/03/01 20:06:05 UTC
[jira] Created: (CMIS-142) SimpleReadWriteTests.testCreateDocument
incorrect acl assertion?
SimpleReadWriteTests.testCreateDocument incorrect acl assertion?
----------------------------------------------------------------
Key: CMIS-142
URL: https://issues.apache.org/jira/browse/CMIS-142
Project: Chemistry
Issue Type: Bug
Components: opencmis-provider
Reporter: David Caruana
AbstractSimpleReadWriteTests (line 116):
if (supportsManageACLs()) {
AccessControlEntry ace = getObjectFactory().createAccessControlEntry(getUsername(),
Collections.singletonList("cmis:read"));
AccessControlList acl = getObjectFactory().createAccessControlList(
Collections.singletonList(ace));
AccessControlList newAcl = getProvider().getAclService().applyAcl(getTestRepositoryId(),
docId, acl, null, getAclPropagation(), null);
assertNotNull(newAcl);
This test case does not provide a removeAces value to applyAcl. Subsequently, in AbstractAtomPubService (line 508) the following check is made:
if ((removeAces == null) || (removeAces.getAces() == null)) {
throw new IllegalArgumentException("remove ACEs must not be null!");
}
The above assertion always seem to fail for SimpleReadWriteTests.testCreateDocument.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CMIS-142) SimpleReadWriteTests.testCreateDocument
incorrect acl assertion?
Posted by "Florian Müller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CMIS-142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Florian Müller reassigned CMIS-142:
-----------------------------------
Assignee: Florian Müller
> SimpleReadWriteTests.testCreateDocument incorrect acl assertion?
> ----------------------------------------------------------------
>
> Key: CMIS-142
> URL: https://issues.apache.org/jira/browse/CMIS-142
> Project: Chemistry
> Issue Type: Bug
> Components: opencmis-provider
> Reporter: David Caruana
> Assignee: Florian Müller
>
> AbstractSimpleReadWriteTests (line 116):
> if (supportsManageACLs()) {
> AccessControlEntry ace = getObjectFactory().createAccessControlEntry(getUsername(),
> Collections.singletonList("cmis:read"));
> AccessControlList acl = getObjectFactory().createAccessControlList(
> Collections.singletonList(ace));
> AccessControlList newAcl = getProvider().getAclService().applyAcl(getTestRepositoryId(),
> docId, acl, null, getAclPropagation(), null);
> assertNotNull(newAcl);
> This test case does not provide a removeAces value to applyAcl. Subsequently, in AbstractAtomPubService (line 508) the following check is made:
> if ((removeAces == null) || (removeAces.getAces() == null)) {
> throw new IllegalArgumentException("remove ACEs must not be null!");
> }
> The above assertion always seem to fail for SimpleReadWriteTests.testCreateDocument.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CMIS-142) SimpleReadWriteTests.testCreateDocument
incorrect acl assertion?
Posted by "Florian Müller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CMIS-142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Florian Müller resolved CMIS-142.
---------------------------------
Resolution: Fixed
> SimpleReadWriteTests.testCreateDocument incorrect acl assertion?
> ----------------------------------------------------------------
>
> Key: CMIS-142
> URL: https://issues.apache.org/jira/browse/CMIS-142
> Project: Chemistry
> Issue Type: Bug
> Components: opencmis-provider
> Reporter: David Caruana
> Assignee: Florian Müller
>
> AbstractSimpleReadWriteTests (line 116):
> if (supportsManageACLs()) {
> AccessControlEntry ace = getObjectFactory().createAccessControlEntry(getUsername(),
> Collections.singletonList("cmis:read"));
> AccessControlList acl = getObjectFactory().createAccessControlList(
> Collections.singletonList(ace));
> AccessControlList newAcl = getProvider().getAclService().applyAcl(getTestRepositoryId(),
> docId, acl, null, getAclPropagation(), null);
> assertNotNull(newAcl);
> This test case does not provide a removeAces value to applyAcl. Subsequently, in AbstractAtomPubService (line 508) the following check is made:
> if ((removeAces == null) || (removeAces.getAces() == null)) {
> throw new IllegalArgumentException("remove ACEs must not be null!");
> }
> The above assertion always seem to fail for SimpleReadWriteTests.testCreateDocument.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CMIS-142)
SimpleReadWriteTests.testCreateDocument incorrect acl assertion?
Posted by "David Caruana (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CMIS-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840066#action_12840066 ]
David Caruana commented on CMIS-142:
------------------------------------
I can confirm SimpleReadWriteTests now pass with this fix. Thanks.
> SimpleReadWriteTests.testCreateDocument incorrect acl assertion?
> ----------------------------------------------------------------
>
> Key: CMIS-142
> URL: https://issues.apache.org/jira/browse/CMIS-142
> Project: Chemistry
> Issue Type: Bug
> Components: opencmis-provider
> Reporter: David Caruana
> Assignee: Florian Müller
>
> AbstractSimpleReadWriteTests (line 116):
> if (supportsManageACLs()) {
> AccessControlEntry ace = getObjectFactory().createAccessControlEntry(getUsername(),
> Collections.singletonList("cmis:read"));
> AccessControlList acl = getObjectFactory().createAccessControlList(
> Collections.singletonList(ace));
> AccessControlList newAcl = getProvider().getAclService().applyAcl(getTestRepositoryId(),
> docId, acl, null, getAclPropagation(), null);
> assertNotNull(newAcl);
> This test case does not provide a removeAces value to applyAcl. Subsequently, in AbstractAtomPubService (line 508) the following check is made:
> if ((removeAces == null) || (removeAces.getAces() == null)) {
> throw new IllegalArgumentException("remove ACEs must not be null!");
> }
> The above assertion always seem to fail for SimpleReadWriteTests.testCreateDocument.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.