You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by LucaCanali <gi...@git.apache.org> on 2018/09/11 19:57:23 UTC
[GitHub] spark pull request #22397: [SPARK-25170][DOC] Add list and short description...
GitHub user LucaCanali opened a pull request:
https://github.com/apache/spark/pull/22397
[SPARK-25170][DOC] Add list and short description of Spark Executor Task Metrics to the documentation.
## What changes were proposed in this pull request?
Add description of Executor Task Metrics to the documentation.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/LucaCanali/spark docMonitoringTaskMetrics
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22397.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22397
----
commit a8db1605adbc271c785fda24b4945bf87149a4cd
Author: LucaCanali <lu...@...>
Date: 2018-08-20T14:12:52Z
Document Spark Executor Task Metrics
commit 27130bac74fda2a21dc1443b613c0aee4df1e17a
Author: LucaCanali <lu...@...>
Date: 2018-09-10T19:30:43Z
Addressing review comments.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22397: [SPARK-25170][DOC] Add list and short description of Spa...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22397
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22397: [SPARK-25170][DOC] Add list and short description of Spa...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22397
**[Test build #4340 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4340/testReport)** for PR 22397 at commit [`27130ba`](https://github.com/apache/spark/commit/27130bac74fda2a21dc1443b613c0aee4df1e17a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22397: [SPARK-25170][DOC] Add list and short description...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22397
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22397: [SPARK-25170][DOC] Add list and short description of Spa...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22397
Merged to master/2.4
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22397: [SPARK-25170][DOC] Add list and short description of Spa...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22397
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22397: [SPARK-25170][DOC] Add list and short description of Spa...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22397
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22397: [SPARK-25170][DOC] Add list and short description of Spa...
Posted by LucaCanali <gi...@git.apache.org>.
Github user LucaCanali commented on the issue:
https://github.com/apache/spark/pull/22397
Thanks @srowen for reviewing this. The metrics are commented in the source code of TaskMetrics class, I took most of the descriptions from there, adding some additional explanations where needed. Indeed I agree that the fact that time units are not uniform is a bit incovenient.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22397: [SPARK-25170][DOC] Add list and short description of Spa...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22397
**[Test build #4340 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4340/testReport)** for PR 22397 at commit [`27130ba`](https://github.com/apache/spark/commit/27130bac74fda2a21dc1443b613c0aee4df1e17a).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22397: [SPARK-25170][DOC] Add list and short description of Spa...
Posted by kiszk <gi...@git.apache.org>.
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22397
Yes, time unit looks confusing, but not a problem. In general, due to APIs, elapsed time is `ms`, and CPU time is `ns`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22397: [SPARK-25170][DOC] Add list and short description of Spa...
Posted by kiszk <gi...@git.apache.org>.
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22397
LGTM cc @jiangxb1987 @srowen
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org