You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Valentin Valchev (JIRA)" <ji...@apache.org> on 2010/10/08 09:14:30 UTC

[jira] Created: (FELIX-2644) cannot disable plugin

cannot disable plugin
---------------------

                 Key: FELIX-2644
                 URL: https://issues.apache.org/jira/browse/FELIX-2644
             Project: Felix
          Issue Type: Bug
          Components: Web Console
    Affects Versions: webconsole-3.1.2
            Reporter: Valentin Valchev


Something went terribly wrong! I cannot disable a plugin from the configuration.

The reason for this is that the plugins are initialized during startup. In the constructor, the Web Console will lookup the configuration and see if plugin is disable. If so, it will be ignored, otherwise the plugin will be instantiated and ready to use.

However, configuration delivery is asynchronous, so you don't know when the configuration dictionary is delivered and in my case, it is 'updated' a little bit after the initialization. So initially, when the web console is initialized, it has 'null' - default configuration and all plugins are enabled. Then later on, after updating the configuration I disable as example the 'shell' plugin.

Unfortunately, the web console will not check if the plugin is disabled, when the browser is opened and the 'shell' plugin remains visible.

Putting the plugin initialization in the constructor, means, that there is no way to actually disable a plugin and all internal plugin will be instantiate and visible by default, Even if they are not needed, there is no browser request for them or disabled by the configuration.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-2644) cannot disable plugin

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919256#action_12919256 ] 

Felix Meschberger commented on FELIX-2644:
------------------------------------------

Yes, this is caused by my refactoring of the OSGiManager setup.

Maybe we should enhance the PluginHolder and its internal classes Plugin/ServletPlugin addding an "enabled" flag and changing the getPlugins() and getPlugin(String) method to respect this enabled flag.

WDYT ?

> cannot disable plugin
> ---------------------
>
>                 Key: FELIX-2644
>                 URL: https://issues.apache.org/jira/browse/FELIX-2644
>             Project: Felix
>          Issue Type: Bug
>          Components: Web Console
>    Affects Versions: webconsole-3.1.2
>            Reporter: Valentin Valchev
>
> Something went terribly wrong! I cannot disable a plugin from the configuration.
> The reason for this is that the plugins are initialized during startup. In the constructor, the Web Console will lookup the configuration and see if plugin is disable. If so, it will be ignored, otherwise the plugin will be instantiated and ready to use.
> However, configuration delivery is asynchronous, so you don't know when the configuration dictionary is delivered and in my case, it is 'updated' a little bit after the initialization. So initially, when the web console is initialized, it has 'null' - default configuration and all plugins are enabled. Then later on, after updating the configuration I disable as example the 'shell' plugin.
> Unfortunately, the web console will not check if the plugin is disabled, when the browser is opened and the 'shell' plugin remains visible.
> Putting the plugin initialization in the constructor, means, that there is no way to actually disable a plugin and all internal plugin will be instantiate and visible by default, Even if they are not needed, there is no browser request for them or disabled by the configuration.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-2644) cannot disable plugin

Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919728#action_12919728 ] 

Valentin Valchev commented on FELIX-2644:
-----------------------------------------

And maybe that Plugin can be given a class name, so it can create the "internal plugin" instance on demand. Just like the external plugins registered as services.

> cannot disable plugin
> ---------------------
>
>                 Key: FELIX-2644
>                 URL: https://issues.apache.org/jira/browse/FELIX-2644
>             Project: Felix
>          Issue Type: Bug
>          Components: Web Console
>    Affects Versions: webconsole-3.1.2
>            Reporter: Valentin Valchev
>
> Something went terribly wrong! I cannot disable a plugin from the configuration.
> The reason for this is that the plugins are initialized during startup. In the constructor, the Web Console will lookup the configuration and see if plugin is disable. If so, it will be ignored, otherwise the plugin will be instantiated and ready to use.
> However, configuration delivery is asynchronous, so you don't know when the configuration dictionary is delivered and in my case, it is 'updated' a little bit after the initialization. So initially, when the web console is initialized, it has 'null' - default configuration and all plugins are enabled. Then later on, after updating the configuration I disable as example the 'shell' plugin.
> Unfortunately, the web console will not check if the plugin is disabled, when the browser is opened and the 'shell' plugin remains visible.
> Putting the plugin initialization in the constructor, means, that there is no way to actually disable a plugin and all internal plugin will be instantiate and visible by default, Even if they are not needed, there is no browser request for them or disabled by the configuration.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FELIX-2644) cannot disable plugin

Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Valentin Valchev updated FELIX-2644:
------------------------------------

    Attachment: internal-plugin-loader.patch

Attached quick and dirty patch for fixing the problem

Now the internal plugins are created by class-name, so the plugins are instantiated when they are requested.

This theoretically should decrease the startup time of the bundle.

Unfortunately there is a small problem with the metatype - I need to show the titles, but since I don't have the plugin instances I don't know the titles. So I assume, that the title is a resource key which is made as "<label>.pluginTitle", which of course is not true ;) And if the title is missing, then the label is used.



> cannot disable plugin
> ---------------------
>
>                 Key: FELIX-2644
>                 URL: https://issues.apache.org/jira/browse/FELIX-2644
>             Project: Felix
>          Issue Type: Bug
>          Components: Web Console
>    Affects Versions: webconsole-3.1.2
>            Reporter: Valentin Valchev
>         Attachments: internal-plugin-loader.patch
>
>
> Something went terribly wrong! I cannot disable a plugin from the configuration.
> The reason for this is that the plugins are initialized during startup. In the constructor, the Web Console will lookup the configuration and see if plugin is disable. If so, it will be ignored, otherwise the plugin will be instantiated and ready to use.
> However, configuration delivery is asynchronous, so you don't know when the configuration dictionary is delivered and in my case, it is 'updated' a little bit after the initialization. So initially, when the web console is initialized, it has 'null' - default configuration and all plugins are enabled. Then later on, after updating the configuration I disable as example the 'shell' plugin.
> Unfortunately, the web console will not check if the plugin is disabled, when the browser is opened and the 'shell' plugin remains visible.
> Putting the plugin initialization in the constructor, means, that there is no way to actually disable a plugin and all internal plugin will be instantiate and visible by default, Even if they are not needed, there is no browser request for them or disabled by the configuration.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (FELIX-2644) cannot disable plugin

Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924499#action_12924499 ] 

Valentin Valchev edited comment on FELIX-2644 at 10/25/10 4:47 AM:
-------------------------------------------------------------------

* agreed fro NON-NLS ;)
* instead of adding new method OsgiManager.isEnabled() refactored a little bit the existing method isPluginDisabled
* agreed for Plugin.isEnabled()
* for the configuration listener, if I extend the list to the list of all available plugins, then the problems is that each newly registered plugin will get 'disabled' by default. Another solution is the configuration value to contain the list of "disabled" plugins. Maybe we should have a different issue on that problem.


And some other thing, that I will do for the internal plugins is to make their title look like <label>.pluginTitle.

      was (Author: v_valchev):
    * agreed fro NON-NLS ;)
* instead of adding new method OsgiManager.isEnabled() refactored a little bit the existing method isPluginDisabled
* agreed for Plugin.isEnabled()
* for the configuration listener, if I extend the list to the list of all available plugins, then the problems is that each newly registered plugin will get 'disabled' by default. Another solution is the configuration value to contain the list of "disabled" plugins.


And some other thing, that I will do for the internal plugins is to make their title look like <label>.pluginTitle.
  
> cannot disable plugin
> ---------------------
>
>                 Key: FELIX-2644
>                 URL: https://issues.apache.org/jira/browse/FELIX-2644
>             Project: Felix
>          Issue Type: Bug
>          Components: Web Console
>    Affects Versions: webconsole-3.1.2
>            Reporter: Valentin Valchev
>         Attachments: internal-plugin-loader.patch
>
>
> Something went terribly wrong! I cannot disable a plugin from the configuration.
> The reason for this is that the plugins are initialized during startup. In the constructor, the Web Console will lookup the configuration and see if plugin is disable. If so, it will be ignored, otherwise the plugin will be instantiated and ready to use.
> However, configuration delivery is asynchronous, so you don't know when the configuration dictionary is delivered and in my case, it is 'updated' a little bit after the initialization. So initially, when the web console is initialized, it has 'null' - default configuration and all plugins are enabled. Then later on, after updating the configuration I disable as example the 'shell' plugin.
> Unfortunately, the web console will not check if the plugin is disabled, when the browser is opened and the 'shell' plugin remains visible.
> Putting the plugin initialization in the constructor, means, that there is no way to actually disable a plugin and all internal plugin will be instantiate and visible by default, Even if they are not needed, there is no browser request for them or disabled by the configuration.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-2644) cannot disable plugin

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924481#action_12924481 ] 

Felix Meschberger commented on FELIX-2644:
------------------------------------------

Patch basically looks good.

Some comments:

  * Can you please commit the "$NON-NLS-1$" changes in a separate commit ? (just to keep the history clean ;-) )
  * Instead of making the OsgiManager.enabledPlugins field package private I suggest:
            - to add an OsgiManager.isEnabled(String classNameOrLabel) returning whether the plugin is enabled
  * How about making InternalPlugin.isEnabled() a method of the Plugin class ? This makes all plugins eligible for disablement and allows us to not do stuff like "if plugin instanceof InternalPlugin"
  * ConfigurationListener2: Currently only built-in plugins support enablement. By movind the isEnabled method to the Plugin class, this class could be extended to go to the registered plugins to extend the list of plugins, which may be enabled/disabled, to the full set of installed plugins.

> cannot disable plugin
> ---------------------
>
>                 Key: FELIX-2644
>                 URL: https://issues.apache.org/jira/browse/FELIX-2644
>             Project: Felix
>          Issue Type: Bug
>          Components: Web Console
>    Affects Versions: webconsole-3.1.2
>            Reporter: Valentin Valchev
>         Attachments: internal-plugin-loader.patch
>
>
> Something went terribly wrong! I cannot disable a plugin from the configuration.
> The reason for this is that the plugins are initialized during startup. In the constructor, the Web Console will lookup the configuration and see if plugin is disable. If so, it will be ignored, otherwise the plugin will be instantiated and ready to use.
> However, configuration delivery is asynchronous, so you don't know when the configuration dictionary is delivered and in my case, it is 'updated' a little bit after the initialization. So initially, when the web console is initialized, it has 'null' - default configuration and all plugins are enabled. Then later on, after updating the configuration I disable as example the 'shell' plugin.
> Unfortunately, the web console will not check if the plugin is disabled, when the browser is opened and the 'shell' plugin remains visible.
> Putting the plugin initialization in the constructor, means, that there is no way to actually disable a plugin and all internal plugin will be instantiate and visible by default, Even if they are not needed, there is no browser request for them or disabled by the configuration.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-2644) cannot disable plugin

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919260#action_12919260 ] 

Felix Meschberger commented on FELIX-2644:
------------------------------------------

In addition to plugin enablement, we also have an issue with the WebConsoleSecurityProvider.authorize method, which is not used yet. So if we touch the PluginHolder class for the enablement class, it would probably make sense to add support for the authorize() method as well.

> cannot disable plugin
> ---------------------
>
>                 Key: FELIX-2644
>                 URL: https://issues.apache.org/jira/browse/FELIX-2644
>             Project: Felix
>          Issue Type: Bug
>          Components: Web Console
>    Affects Versions: webconsole-3.1.2
>            Reporter: Valentin Valchev
>
> Something went terribly wrong! I cannot disable a plugin from the configuration.
> The reason for this is that the plugins are initialized during startup. In the constructor, the Web Console will lookup the configuration and see if plugin is disable. If so, it will be ignored, otherwise the plugin will be instantiated and ready to use.
> However, configuration delivery is asynchronous, so you don't know when the configuration dictionary is delivered and in my case, it is 'updated' a little bit after the initialization. So initially, when the web console is initialized, it has 'null' - default configuration and all plugins are enabled. Then later on, after updating the configuration I disable as example the 'shell' plugin.
> Unfortunately, the web console will not check if the plugin is disabled, when the browser is opened and the 'shell' plugin remains visible.
> Putting the plugin initialization in the constructor, means, that there is no way to actually disable a plugin and all internal plugin will be instantiate and visible by default, Even if they are not needed, there is no browser request for them or disabled by the configuration.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-2644) cannot disable plugin

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924506#action_12924506 ] 

Felix Meschberger commented on FELIX-2644:
------------------------------------------

Ok, agreed on all. Thanks.

I would assume that changing the "title" of the internal plugins to "<label>.pluginTitle" will only affect some translations possibly being out there in the wild but not any functionality, right ? I f so, I am ok with this change.

> cannot disable plugin
> ---------------------
>
>                 Key: FELIX-2644
>                 URL: https://issues.apache.org/jira/browse/FELIX-2644
>             Project: Felix
>          Issue Type: Bug
>          Components: Web Console
>    Affects Versions: webconsole-3.1.2
>            Reporter: Valentin Valchev
>         Attachments: internal-plugin-loader.patch
>
>
> Something went terribly wrong! I cannot disable a plugin from the configuration.
> The reason for this is that the plugins are initialized during startup. In the constructor, the Web Console will lookup the configuration and see if plugin is disable. If so, it will be ignored, otherwise the plugin will be instantiated and ready to use.
> However, configuration delivery is asynchronous, so you don't know when the configuration dictionary is delivered and in my case, it is 'updated' a little bit after the initialization. So initially, when the web console is initialized, it has 'null' - default configuration and all plugins are enabled. Then later on, after updating the configuration I disable as example the 'shell' plugin.
> Unfortunately, the web console will not check if the plugin is disabled, when the browser is opened and the 'shell' plugin remains visible.
> Putting the plugin initialization in the constructor, means, that there is no way to actually disable a plugin and all internal plugin will be instantiate and visible by default, Even if they are not needed, there is no browser request for them or disabled by the configuration.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (FELIX-2644) cannot disable plugin

Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Valentin Valchev resolved FELIX-2644.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: webconsole-3.1.4

fixed in rev. 1027069

> cannot disable plugin
> ---------------------
>
>                 Key: FELIX-2644
>                 URL: https://issues.apache.org/jira/browse/FELIX-2644
>             Project: Felix
>          Issue Type: Bug
>          Components: Web Console
>    Affects Versions: webconsole-3.1.2
>            Reporter: Valentin Valchev
>            Assignee: Valentin Valchev
>             Fix For: webconsole-3.1.4
>
>         Attachments: internal-plugin-loader.patch
>
>
> Something went terribly wrong! I cannot disable a plugin from the configuration.
> The reason for this is that the plugins are initialized during startup. In the constructor, the Web Console will lookup the configuration and see if plugin is disable. If so, it will be ignored, otherwise the plugin will be instantiated and ready to use.
> However, configuration delivery is asynchronous, so you don't know when the configuration dictionary is delivered and in my case, it is 'updated' a little bit after the initialization. So initially, when the web console is initialized, it has 'null' - default configuration and all plugins are enabled. Then later on, after updating the configuration I disable as example the 'shell' plugin.
> Unfortunately, the web console will not check if the plugin is disabled, when the browser is opened and the 'shell' plugin remains visible.
> Putting the plugin initialization in the constructor, means, that there is no way to actually disable a plugin and all internal plugin will be instantiate and visible by default, Even if they are not needed, there is no browser request for them or disabled by the configuration.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-2644) cannot disable plugin

Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924499#action_12924499 ] 

Valentin Valchev commented on FELIX-2644:
-----------------------------------------

* agreed fro NON-NLS ;)
* instead of adding new method OsgiManager.isEnabled() refactored a little bit the existing method isPluginDisabled
* agreed for Plugin.isEnabled()
* for the configuration listener, if I extend the list to the list of all available plugins, then the problems is that each newly registered plugin will get 'disabled' by default. Another solution is the configuration value to contain the list of "disabled" plugins.


And some other thing, that I will do for the internal plugins is to make their title look like <label>.pluginTitle.

> cannot disable plugin
> ---------------------
>
>                 Key: FELIX-2644
>                 URL: https://issues.apache.org/jira/browse/FELIX-2644
>             Project: Felix
>          Issue Type: Bug
>          Components: Web Console
>    Affects Versions: webconsole-3.1.2
>            Reporter: Valentin Valchev
>         Attachments: internal-plugin-loader.patch
>
>
> Something went terribly wrong! I cannot disable a plugin from the configuration.
> The reason for this is that the plugins are initialized during startup. In the constructor, the Web Console will lookup the configuration and see if plugin is disable. If so, it will be ignored, otherwise the plugin will be instantiated and ready to use.
> However, configuration delivery is asynchronous, so you don't know when the configuration dictionary is delivered and in my case, it is 'updated' a little bit after the initialization. So initially, when the web console is initialized, it has 'null' - default configuration and all plugins are enabled. Then later on, after updating the configuration I disable as example the 'shell' plugin.
> Unfortunately, the web console will not check if the plugin is disabled, when the browser is opened and the 'shell' plugin remains visible.
> Putting the plugin initialization in the constructor, means, that there is no way to actually disable a plugin and all internal plugin will be instantiate and visible by default, Even if they are not needed, there is no browser request for them or disabled by the configuration.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (FELIX-2644) cannot disable plugin

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger closed FELIX-2644.
------------------------------------


Close after release

> cannot disable plugin
> ---------------------
>
>                 Key: FELIX-2644
>                 URL: https://issues.apache.org/jira/browse/FELIX-2644
>             Project: Felix
>          Issue Type: Bug
>          Components: Web Console
>    Affects Versions: webconsole-3.1.2
>            Reporter: Valentin Valchev
>            Assignee: Valentin Valchev
>             Fix For: webconsole-3.1.6
>
>         Attachments: internal-plugin-loader.patch
>
>
> Something went terribly wrong! I cannot disable a plugin from the configuration.
> The reason for this is that the plugins are initialized during startup. In the constructor, the Web Console will lookup the configuration and see if plugin is disable. If so, it will be ignored, otherwise the plugin will be instantiated and ready to use.
> However, configuration delivery is asynchronous, so you don't know when the configuration dictionary is delivered and in my case, it is 'updated' a little bit after the initialization. So initially, when the web console is initialized, it has 'null' - default configuration and all plugins are enabled. Then later on, after updating the configuration I disable as example the 'shell' plugin.
> Unfortunately, the web console will not check if the plugin is disabled, when the browser is opened and the 'shell' plugin remains visible.
> Putting the plugin initialization in the constructor, means, that there is no way to actually disable a plugin and all internal plugin will be instantiate and visible by default, Even if they are not needed, there is no browser request for them or disabled by the configuration.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (FELIX-2644) cannot disable plugin

Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Valentin Valchev reassigned FELIX-2644:
---------------------------------------

    Assignee: Valentin Valchev

> cannot disable plugin
> ---------------------
>
>                 Key: FELIX-2644
>                 URL: https://issues.apache.org/jira/browse/FELIX-2644
>             Project: Felix
>          Issue Type: Bug
>          Components: Web Console
>    Affects Versions: webconsole-3.1.2
>            Reporter: Valentin Valchev
>            Assignee: Valentin Valchev
>         Attachments: internal-plugin-loader.patch
>
>
> Something went terribly wrong! I cannot disable a plugin from the configuration.
> The reason for this is that the plugins are initialized during startup. In the constructor, the Web Console will lookup the configuration and see if plugin is disable. If so, it will be ignored, otherwise the plugin will be instantiated and ready to use.
> However, configuration delivery is asynchronous, so you don't know when the configuration dictionary is delivered and in my case, it is 'updated' a little bit after the initialization. So initially, when the web console is initialized, it has 'null' - default configuration and all plugins are enabled. Then later on, after updating the configuration I disable as example the 'shell' plugin.
> Unfortunately, the web console will not check if the plugin is disabled, when the browser is opened and the 'shell' plugin remains visible.
> Putting the plugin initialization in the constructor, means, that there is no way to actually disable a plugin and all internal plugin will be instantiate and visible by default, Even if they are not needed, there is no browser request for them or disabled by the configuration.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-2644) cannot disable plugin

Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924524#action_12924524 ] 

Valentin Valchev commented on FELIX-2644:
-----------------------------------------

Yes, it is mostly for the properties files, but in some plugins it requires to change a private static field TITLE

> cannot disable plugin
> ---------------------
>
>                 Key: FELIX-2644
>                 URL: https://issues.apache.org/jira/browse/FELIX-2644
>             Project: Felix
>          Issue Type: Bug
>          Components: Web Console
>    Affects Versions: webconsole-3.1.2
>            Reporter: Valentin Valchev
>         Attachments: internal-plugin-loader.patch
>
>
> Something went terribly wrong! I cannot disable a plugin from the configuration.
> The reason for this is that the plugins are initialized during startup. In the constructor, the Web Console will lookup the configuration and see if plugin is disable. If so, it will be ignored, otherwise the plugin will be instantiated and ready to use.
> However, configuration delivery is asynchronous, so you don't know when the configuration dictionary is delivered and in my case, it is 'updated' a little bit after the initialization. So initially, when the web console is initialized, it has 'null' - default configuration and all plugins are enabled. Then later on, after updating the configuration I disable as example the 'shell' plugin.
> Unfortunately, the web console will not check if the plugin is disabled, when the browser is opened and the 'shell' plugin remains visible.
> Putting the plugin initialization in the constructor, means, that there is no way to actually disable a plugin and all internal plugin will be instantiate and visible by default, Even if they are not needed, there is no browser request for them or disabled by the configuration.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.