You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Olivier Lamy <ol...@gmail.com> on 2012/11/13 11:14:36 UTC

Fwd: Checkstyle Plugin: Upgrade dependency to Checkstyle v5.6

resend as I have issues with my @apache.o mailbox.


---------- Forwarded message ----------
From: Olivier Lamy <ol...@apache.org>
Date: 2012/11/13
Subject: Re: Checkstyle Plugin: Upgrade dependency to Checkstyle v5.6
To: Maven Users List <us...@maven.apache.org>


2012/11/13 Brett Walker <br...@geometryit.com>:
> Hi Thomas,
>
>>> I tried building the plugin myself with an updated dependency. It did not work.
>>
>>Have you tried overriding the plugin dependency with checkstyle:5.6?
>>
>><plugin>
>>   <artifactId>maven-checkstyle-plugin</artifactId>
>>   <version>2.9.1</version>
>>   <dependencies>
>>      <dependency>
>>         <groupId>com.puppycrawl.tools</groupId>
>>         <artifactId>checkstyle</artifactId>
>>         <version>5.6</version>
>>      </dependency>
>>   </dependencies>
>></plugin>
>
> This is what I did. It fixed my immediate problem but introduced others. After fiddling around for a while I could not resolve all the new problems.
>
> I'm not familiar with Maven Plugin Architecture nor with how the Checkstyle Plugin links to the Checkstyle Library.
>
> I am hoping someone can point me in the right direction.
You can do it.
But if you use default checktyle rules provided by the plugin it will fail.
The reason is checkstyle folks removed DoubleCheckedLocking rule (see
http://svn.apache.org/viewvc/maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/maven_checks.xml?r1=1178094&r2=1390987&diff_format=h
) and checkstyle release note
(http://checkstyle.sourceforge.net/releasenotes.html)

So if going in this way you must use your own rules file and remove this one.

>
> Brett
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
> For additional commands, e-mail: users-help@maven.apache.org
>



--
Olivier Lamy
Talend: http://coders.talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy

--
Olivier Lamy
Talend: http://coders.talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org