You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/11/06 05:48:19 UTC

[GitHub] [shardingsphere] Lucas-307 opened a new pull request #8046: Refactor DistributionChannel

Lucas-307 opened a new pull request #8046:
URL: https://github.com/apache/shardingsphere/pull/8046


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Lucas-307 commented on pull request #8046: Refactor DistributionChannel

Posted by GitBox <gi...@apache.org>.
Lucas-307 commented on pull request #8046:
URL: https://github.com/apache/shardingsphere/pull/8046#issuecomment-722856895


   please wait for ci.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Lucas-307 removed a comment on pull request #8046: Refactor DistributionChannel

Posted by GitBox <gi...@apache.org>.
Lucas-307 removed a comment on pull request #8046:
URL: https://github.com/apache/shardingsphere/pull/8046#issuecomment-722856895


   please wait for ci.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu merged pull request #8046: Refactor DistributionChannel

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #8046:
URL: https://github.com/apache/shardingsphere/pull/8046


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io commented on pull request #8046: Refactor DistributionChannel

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #8046:
URL: https://github.com/apache/shardingsphere/pull/8046#issuecomment-722903758


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8046?src=pr&el=h1) Report
   > Merging [#8046](https://codecov.io/gh/apache/shardingsphere/pull/8046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/0eaccba168d0f99fdd1916dcede79751c7b31460?el=desc) will **increase** coverage by `0.40%`.
   > The diff coverage is `84.61%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/8046/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/8046?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #8046      +/-   ##
   ============================================
   + Coverage     74.71%   75.12%   +0.40%     
   - Complexity      537      548      +11     
   ============================================
     Files          1447     1451       +4     
     Lines         22736    22779      +43     
     Branches       4061     4066       +5     
   ============================================
   + Hits          16988    17112     +124     
   + Misses         4654     4561      -93     
   - Partials       1094     1106      +12     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8046?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ng/core/execute/executor/channel/ManualBitSet.java](https://codecov.io/gh/apache/shardingsphere/pull/8046/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9leGVjdXRlL2V4ZWN1dG9yL2NoYW5uZWwvTWFudWFsQml0U2V0LmphdmE=) | `68.29% <68.29%> (ø)` | `0.00 <0.00> (?)` | |
   | [...executor/channel/AutoAcknowledgeBitSetChannel.java](https://codecov.io/gh/apache/shardingsphere/pull/8046/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9leGVjdXRlL2V4ZWN1dG9yL2NoYW5uZWwvQXV0b0Fja25vd2xlZGdlQml0U2V0Q2hhbm5lbC5qYXZh) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...e/executor/channel/BlockingQueueBitSetChannel.java](https://codecov.io/gh/apache/shardingsphere/pull/8046/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9leGVjdXRlL2V4ZWN1dG9yL2NoYW5uZWwvQmxvY2tpbmdRdWV1ZUJpdFNldENoYW5uZWwuamF2YQ==) | `85.00% <85.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...xecute/executor/channel/AbstractBitSetChannel.java](https://codecov.io/gh/apache/shardingsphere/pull/8046/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9leGVjdXRlL2V4ZWN1dG9yL2NoYW5uZWwvQWJzdHJhY3RCaXRTZXRDaGFubmVsLmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../execute/executor/channel/DistributionChannel.java](https://codecov.io/gh/apache/shardingsphere/pull/8046/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9leGVjdXRlL2V4ZWN1dG9yL2NoYW5uZWwvRGlzdHJpYnV0aW9uQ2hhbm5lbC5qYXZh) | `95.45% <100.00%> (+16.04%)` | `0.00 <0.00> (ø)` | |
   | [.../shardingsphere/scaling/core/utils/ThreadUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/8046/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS91dGlscy9UaHJlYWRVdGlsLmphdmE=) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...here/sql/parser/exception/SQLParsingException.java](https://codecov.io/gh/apache/shardingsphere/pull/8046/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9leGNlcHRpb24vU1FMUGFyc2luZ0V4Y2VwdGlvbi5qYXZh) | `50.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...g/core/execute/executor/channel/MemoryChannel.java](https://codecov.io/gh/apache/shardingsphere/pull/8046/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9leGVjdXRlL2V4ZWN1dG9yL2NoYW5uZWwvTWVtb3J5Q2hhbm5lbC5qYXZh) | `31.81% <0.00%> (-40.91%)` | `0.00% <0.00%> (ø%)` | |
   | [...aling/core/execute/executor/record/RecordUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/8046/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9leGVjdXRlL2V4ZWN1dG9yL3JlY29yZC9SZWNvcmRVdGlsLmphdmE=) | `71.42% <0.00%> (-28.58%)` | `8.00% <0.00%> (+8.00%)` | :arrow_down: |
   | [...phere/governance/core/facade/GovernanceFacade.java](https://codecov.io/gh/apache/shardingsphere/pull/8046/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS1jb3JlLWZhY2FkZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZ292ZXJuYW5jZS9jb3JlL2ZhY2FkZS9Hb3Zlcm5hbmNlRmFjYWRlLmphdmE=) | `79.16% <0.00%> (-15.84%)` | `1.00% <0.00%> (ø%)` | |
   | ... and [264 more](https://codecov.io/gh/apache/shardingsphere/pull/8046/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8046?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8046?src=pr&el=footer). Last update [0eaccba...74a6580](https://codecov.io/gh/apache/shardingsphere/pull/8046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org