You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "mbien (via GitHub)" <gi...@apache.org> on 2023/11/06 21:16:54 UTC
[PR] BuildInstallersMojo: disable obsolete pack200 by default [netbeans-mavenutils-nbm-maven-plugin]
mbien opened a new pull request, #116:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/116
functionality doesn't exist post JDK 11 (JDK 14?)
i am wondering why the build compiles without errors: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/blob/4f5d42c9a5513bbcc91b8524570f3d442742b8ca/nbm-maven-plugin/src/main/java/org/apache/netbeans/nbm/CreateClusterAppMojo.java#L334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] BuildInstallersMojo: disable obsolete pack200 by default [netbeans-mavenutils-nbm-maven-plugin]
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on PR #116:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/116#issuecomment-1801376474
the released version is compiled with jdk 8, we have jenkins ci that build on a jdk matrix 8 11 17 21. Is'nt the target/release option that put the pack2000 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] BuildInstallersMojo: disable obsolete pack200 by default [netbeans-mavenutils-nbm-maven-plugin]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien merged PR #116:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] BuildInstallersMojo: disable obsolete pack200 by default [netbeans-mavenutils-nbm-maven-plugin]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #116:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/116#issuecomment-1802022000
While I'd be tempted to make this flag a no-op, I'd at least mark it deprecated and log a warning if it's set to `true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] BuildInstallersMojo: disable obsolete pack200 by default [netbeans-mavenutils-nbm-maven-plugin]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #116:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/116#issuecomment-1801410491
you are right! I didn't realize that you can in theory build against classes which do no longer exist in the JDK you are building with. Since the signature files only assert that the --release version has the files, not the version you are building with.
So this would cause a class loading error if someone runs the mojo on JDK 14+ without disabling the pack200 compression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] BuildInstallersMojo: disable obsolete pack200 by default [netbeans-mavenutils-nbm-maven-plugin]
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on PR #116:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/116#issuecomment-1808085047
Maybe we could merge ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] BuildInstallersMojo: disable obsolete pack200 by default [netbeans-mavenutils-nbm-maven-plugin]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #116:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/116#issuecomment-1799788034
> we have a profile to target on jdk 8 if jdk > 8
what does this mean? the MoJo is not compiled on JDK 17/21? Where does the [Pack200](https://docs.oracle.com/javase/8/docs/api/java/util/jar/Pack200.html) class come from?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] BuildInstallersMojo: disable obsolete pack200 by default [netbeans-mavenutils-nbm-maven-plugin]
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on PR #116:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/116#issuecomment-1801530119
good to remove the default true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] BuildInstallersMojo: disable obsolete pack200 by default [netbeans-mavenutils-nbm-maven-plugin]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #116:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/116#issuecomment-1802516812
> I'd at least mark it deprecated and log a warning if it's set to true.
good idea, lets deprecate it, disable it by default and print warnings if it is enabled for at least one release
> I'm not quite clear on which IDE versions and which platform versions this will be active?
I don't know either. I searched the repo for pack200 and got two hits: https://github.com/search?q=repo%3Aapache%2Fnetbeans-mavenutils-nbm-maven-plugin+pack200&type=code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] BuildInstallersMojo: disable obsolete pack200 by default [netbeans-mavenutils-nbm-maven-plugin]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #116:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/116#issuecomment-1802920681
added `@Deprecated` to this and other parameters which had it missing. I asked on maven slack and deprecating maven parameters is sufficient to make maven print warnings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] BuildInstallersMojo: disable obsolete pack200 by default [netbeans-mavenutils-nbm-maven-plugin]
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on PR #116:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/116#issuecomment-1798071751
we have a profile to target on jdk 8 if jdk > 8
Not sure how to play well with maven as it has a jdk 8 baseline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] BuildInstallersMojo: disable obsolete pack200 by default [netbeans-mavenutils-nbm-maven-plugin]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #116:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/116#issuecomment-1808096917
it isn't approved yet :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists