[jira] [Commented] (KAFKA-2558) ServerShutdownTest is failing intermittently

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-2558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14877366#comment-14877366 ] 

ASF GitHub Bot commented on KAFKA-2558:
---------------------------------------

GitHub user fpj opened a pull request:

    https://github.com/apache/kafka/pull/224

    KAFKA-2558: ServerShutdownTest is failing intermittently

    See jira for a description.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fpj/kafka KAFKA-2558

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/224.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #224
    
----
commit bd71a44122e423d23ad651d689a145aba18fe499
Author: fpj <fp...@apache.org>
Date:   2015-09-20T01:08:23Z

    KAFKA-2558: Use class name to figure out the threads of test case.

----


> ServerShutdownTest is failing intermittently
> --------------------------------------------
>
>                 Key: KAFKA-2558
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2558
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: unit tests
>            Reporter: Flavio Junqueira
>            Assignee: Flavio Junqueira
>
> The test case there fail because tests are leaking resources into others. For this particular case I noticed that the test cases are checking if all threads are being shut down and they are finding threads created by other tests in the same jvm instance.
> To verify this, I added a couple of log messages to print the thread id when the thread starts and when the thread is interrupted. I also interrupt the offending thread in the test case to force it to print its id. Here is one such output:
> {noformat}
> $ grep 1572 build/test-results/*.xml
> build/test-results/TEST-kafka.controller.ControllerFailoverTest.xml:[2015-09-16 15:03:42,398] INFO [Controller-0-to-broker-1-send-thread], Starting Controller-0-to-broker-1-send-thread 1572 (kafka.controller.RequestSendThread:68)
> build/test-results/TEST-kafka.server.ServerShutdownTest.xml:[2015-09-16 15:06:33,334] INFO [Controller-0-to-broker-1-send-thread], Got interrupted: Controller-0-to-broker-1-send-thread 1572 (kafka.controller.RequestSendThread:68)
> {noformat}
> The number 1572 is the thread id.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)