[GitHub] [jackrabbit-oak] tihom88 commented on a change in pull request #357: OAK-9552: Don't index except if it's oak:QueryIndexDefinition

[GitBox <gi...@apache.org>]

tihom88 commented on a change in pull request #357:
URL: https://github.com/apache/jackrabbit-oak/pull/357#discussion_r701744402



##########
File path: oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/IndexUpdate.java
##########
@@ -72,6 +73,16 @@
 
     private static final Logger log = LoggerFactory.getLogger(IndexUpdate.class);
     private static final String TYPE_ELASTICSEARCH = "elasticsearch";
+    public static final String DEFAULT_indexJcrTypeInvalidLogLimiter = "1000";
+    //This is used so that wrong index definitions are sparsely logged. After every 1000 indexing cycles, index definitions
+    // with wrong nodetype will be logged.
+    private static final long indexJcrTypeInvalidLogLimiter = Long.valueOf(System.getProperty("oak.indexer.indexJcrTypeInvalidLogLimiter", DEFAULT_indexJcrTypeInvalidLogLimiter));

Review comment:
       I am not setting this in test using system property as it is "static final" --> this gets initialised first with default value whenever any test runs and then I am unable to change it in the test. I don't want to add a setter or not make it final just to pass the test. 
   
   Will change it to all caps




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org