You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Kirk Lund <ki...@gmail.com> on 2017/03/01 01:39:37 UTC

Review Request 57175: GEODE-4160: upgrade mortbay-jetty-servlet-api dependency

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57175/
-----------------------------------------------------------

Review request for geode, Anthony Baker, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe, and Mark Bretl.


Bugs: GEODE-4160
    https://issues.apache.org/jira/browse/GEODE-4160


Repository: geode


Description
-------

Upgrade mortbay-jetty-servlet-api dependency

This is the last upgrade on GEODE-4160 ticket.


Diffs
-----

  gradle/dependency-versions.properties aca65fa 

Diff: https://reviews.apache.org/r/57175/diff/


Testing
-------

precheckin in progress
uiTest passes


Thanks,

Kirk Lund


Re: Review Request 57175: GEODE-4160: upgrade mortbay-jetty-servlet-api dependency

Posted by Mark Bretl <mb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57175/#review167371
-----------------------------------------------------------


Ship it!




Ship It!

- Mark Bretl


On Feb. 28, 2017, 5:39 p.m., Kirk Lund wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57175/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2017, 5:39 p.m.)
> 
> 
> Review request for geode, Anthony Baker, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe, and Mark Bretl.
> 
> 
> Bugs: GEODE-4160
>     https://issues.apache.org/jira/browse/GEODE-4160
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Upgrade mortbay-jetty-servlet-api dependency
> 
> This is the last upgrade on GEODE-4160 ticket.
> 
> 
> Diffs
> -----
> 
>   gradle/dependency-versions.properties aca65fa 
> 
> 
> Diff: https://reviews.apache.org/r/57175/diff/1/
> 
> 
> Testing
> -------
> 
> precheckin in progress
> uiTest passes
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>


Re: Review Request 57175: GEODE-4160: upgrade mortbay-jetty-servlet-api dependency

Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57175/#review167544
-----------------------------------------------------------


Ship it!




Ship It!

- Jinmei Liao


On March 1, 2017, 1:39 a.m., Kirk Lund wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57175/
> -----------------------------------------------------------
> 
> (Updated March 1, 2017, 1:39 a.m.)
> 
> 
> Review request for geode, Anthony Baker, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe, and Mark Bretl.
> 
> 
> Bugs: GEODE-4160
>     https://issues.apache.org/jira/browse/GEODE-4160
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Upgrade mortbay-jetty-servlet-api dependency
> 
> This is the last upgrade on GEODE-4160 ticket.
> 
> 
> Diffs
> -----
> 
>   gradle/dependency-versions.properties aca65fa 
> 
> 
> Diff: https://reviews.apache.org/r/57175/diff/1/
> 
> 
> Testing
> -------
> 
> precheckin in progress
> uiTest passes
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>


Re: Review Request 57175: GEODE-4160: upgrade mortbay-jetty-servlet-api dependency

Posted by Jared Stewart <js...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57175/#review167278
-----------------------------------------------------------


Ship it!




Ship It!

- Jared Stewart


On March 1, 2017, 1:39 a.m., Kirk Lund wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57175/
> -----------------------------------------------------------
> 
> (Updated March 1, 2017, 1:39 a.m.)
> 
> 
> Review request for geode, Anthony Baker, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe, and Mark Bretl.
> 
> 
> Bugs: GEODE-4160
>     https://issues.apache.org/jira/browse/GEODE-4160
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Upgrade mortbay-jetty-servlet-api dependency
> 
> This is the last upgrade on GEODE-4160 ticket.
> 
> 
> Diffs
> -----
> 
>   gradle/dependency-versions.properties aca65fa 
> 
> 
> Diff: https://reviews.apache.org/r/57175/diff/1/
> 
> 
> Testing
> -------
> 
> precheckin in progress
> uiTest passes
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>


Re: Review Request 57175: GEODE-4160: upgrade mortbay-jetty-servlet-api dependency

Posted by Anthony Baker <ab...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57175/#review167276
-----------------------------------------------------------


Ship it!




Ship It!

- Anthony Baker


On March 1, 2017, 1:39 a.m., Kirk Lund wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57175/
> -----------------------------------------------------------
> 
> (Updated March 1, 2017, 1:39 a.m.)
> 
> 
> Review request for geode, Anthony Baker, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe, and Mark Bretl.
> 
> 
> Bugs: GEODE-4160
>     https://issues.apache.org/jira/browse/GEODE-4160
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Upgrade mortbay-jetty-servlet-api dependency
> 
> This is the last upgrade on GEODE-4160 ticket.
> 
> 
> Diffs
> -----
> 
>   gradle/dependency-versions.properties aca65fa 
> 
> 
> Diff: https://reviews.apache.org/r/57175/diff/1/
> 
> 
> Testing
> -------
> 
> precheckin in progress
> uiTest passes
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>


Re: Review Request 57175: GEODE-4160: upgrade mortbay-jetty-servlet-api dependency

Posted by Kevin Duling <kd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57175/#review167291
-----------------------------------------------------------


Ship it!




Ship It!

- Kevin Duling


On Feb. 28, 2017, 5:39 p.m., Kirk Lund wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57175/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2017, 5:39 p.m.)
> 
> 
> Review request for geode, Anthony Baker, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe, and Mark Bretl.
> 
> 
> Bugs: GEODE-4160
>     https://issues.apache.org/jira/browse/GEODE-4160
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Upgrade mortbay-jetty-servlet-api dependency
> 
> This is the last upgrade on GEODE-4160 ticket.
> 
> 
> Diffs
> -----
> 
>   gradle/dependency-versions.properties aca65fa 
> 
> 
> Diff: https://reviews.apache.org/r/57175/diff/1/
> 
> 
> Testing
> -------
> 
> precheckin in progress
> uiTest passes
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>


Re: Review Request 57175: GEODE-4160: upgrade mortbay-jetty-servlet-api dependency

Posted by Ken Howe <kh...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57175/#review167511
-----------------------------------------------------------


Ship it!




Ship It!

- Ken Howe


On March 1, 2017, 1:39 a.m., Kirk Lund wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57175/
> -----------------------------------------------------------
> 
> (Updated March 1, 2017, 1:39 a.m.)
> 
> 
> Review request for geode, Anthony Baker, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe, and Mark Bretl.
> 
> 
> Bugs: GEODE-4160
>     https://issues.apache.org/jira/browse/GEODE-4160
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Upgrade mortbay-jetty-servlet-api dependency
> 
> This is the last upgrade on GEODE-4160 ticket.
> 
> 
> Diffs
> -----
> 
>   gradle/dependency-versions.properties aca65fa 
> 
> 
> Diff: https://reviews.apache.org/r/57175/diff/1/
> 
> 
> Testing
> -------
> 
> precheckin in progress
> uiTest passes
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>


Re: Gfsh> Create regions with bad property values?

Posted by Kirk Lund <kl...@apache.org>.
That's a result of replacing geode-joptsimple with a dependency on the
binary release of jopt-simple.

geode-joptsimple was a forked version that added this functionality.
Unfortunately this was implemented in a rather dodgy way by adding fields
to some internal exceptions which were then treated as a return type. We
would have to figure out a more appropriate way to implement this in order
to contribute an enhancement like this to jopt-simple.

This work is quite low in the priorities right now.

On Tue, Feb 28, 2017 at 9:17 PM Real Wes <Th...@outlook.com> wrote:

> This works in Geode 1.1.0 where GemFire 8 failed:
>
> gfsh> create region --name=Testxxx --type=PARTITION_REDUNDANT_HEAP_LRU
> --badProperty=badValue
>
>
> Is ignoring bad properties by design?  Or a bug?
>
> Thanks,
> Wes Williams
>
>
>

Re: gfsh> export cluster-configuration - Reason: null

Posted by Jinmei Liao <ji...@pivotal.io>.
It is the correct syntax, I just tried it on the tip of develop branch. I
know we have tests that covers export cluster-configuration in the
pipeline. Please do file a ticket with the logs.

gfsh>export cluster-configuration --zip-file-name=test.zip

Downloading cluster configuration : /Users/jiliao/my_geode/tmp/test.zip

On Tue, Feb 28, 2017 at 10:36 PM, Real Wes <Th...@outlook.com> wrote:

> Is this proper syntax in Geode 1.1.0?   If so, let me know and I’ll file a
> jira...
>
> gfsh>export cluster-configuration --zip-file-name=cluster.zip
> Could not process command due to GemFire error. Error while processing
> command <export cluster-configuration --zip-file-name=cluster.zip> Reason :
> null
>
>
> Thanks,
> Wes
>
>
> > On Mar 1, 2017, at 12:24 AM, Jinmei Liao <ji...@pivotal.io> wrote:
> >
> > We have multiple jira tickets on this waiting to be fixed:
> > https://issues.apache.org/jira/browse/GEODE-1597
> > https://issues.apache.org/jira/browse/GEODE-2249
> >
> >
> > On Tue, Feb 28, 2017 at 9:16 PM, Real Wes <Th...@outlook.com>
> wrote:
> >
> >> This works in Geode 1.1.0 where GemFire 8 failed:
> >>
> >> gfsh> create region --name=Testxxx --type=PARTITION_REDUNDANT_HEAP_LRU
> >> --badProperty=badValue
> >>
> >>
> >> Is ignoring bad properties by design?  Or a bug?
> >>
> >> Thanks,
> >> Wes Williams
> >>
> >>
> >>
> >
> >
> > --
> > Cheers
> >
> > Jinmei
>
>


-- 
Cheers

Jinmei

Re: gfsh> export cluster-configuration - Reason: null

Posted by Real Wes <Th...@outlook.com>.
Is this proper syntax in Geode 1.1.0?   If so, let me know and I’ll file a jira...

gfsh>export cluster-configuration --zip-file-name=cluster.zip
Could not process command due to GemFire error. Error while processing command <export cluster-configuration --zip-file-name=cluster.zip> Reason : null


Thanks,
Wes


> On Mar 1, 2017, at 12:24 AM, Jinmei Liao <ji...@pivotal.io> wrote:
> 
> We have multiple jira tickets on this waiting to be fixed:
> https://issues.apache.org/jira/browse/GEODE-1597
> https://issues.apache.org/jira/browse/GEODE-2249
> 
> 
> On Tue, Feb 28, 2017 at 9:16 PM, Real Wes <Th...@outlook.com> wrote:
> 
>> This works in Geode 1.1.0 where GemFire 8 failed:
>> 
>> gfsh> create region --name=Testxxx --type=PARTITION_REDUNDANT_HEAP_LRU
>> --badProperty=badValue
>> 
>> 
>> Is ignoring bad properties by design?  Or a bug?
>> 
>> Thanks,
>> Wes Williams
>> 
>> 
>> 
> 
> 
> -- 
> Cheers
> 
> Jinmei


Re: Gfsh> Create regions with bad property values?

Posted by Jinmei Liao <ji...@pivotal.io>.
We have multiple jira tickets on this waiting to be fixed:
https://issues.apache.org/jira/browse/GEODE-1597
https://issues.apache.org/jira/browse/GEODE-2249


On Tue, Feb 28, 2017 at 9:16 PM, Real Wes <Th...@outlook.com> wrote:

> This works in Geode 1.1.0 where GemFire 8 failed:
>
> gfsh> create region --name=Testxxx --type=PARTITION_REDUNDANT_HEAP_LRU
> --badProperty=badValue
>
>
> Is ignoring bad properties by design?  Or a bug?
>
> Thanks,
> Wes Williams
>
>
>


-- 
Cheers

Jinmei

Gfsh> Create regions with bad property values?

Posted by Real Wes <Th...@outlook.com>.
This works in Geode 1.1.0 where GemFire 8 failed:

gfsh> create region --name=Testxxx --type=PARTITION_REDUNDANT_HEAP_LRU --badProperty=badValue


Is ignoring bad properties by design?  Or a bug?

Thanks,
Wes Williams