You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@lucene.apache.org by "Shai Erera (JIRA)" <ji...@apache.org> on 2014/05/20 18:08:38 UTC

[jira] [Commented] (LUCENE-5689) FieldInfo.setDocValuesGen should not be public.

    [ https://issues.apache.org/jira/browse/LUCENE-5689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14003556#comment-14003556 ] 

Shai Erera commented on LUCENE-5689:
------------------------------------

Looks good. So now FI.setDVGen is used only by ReaderAndUpdates, right? Perhaps it is possible to get rid of it entirely, by having RAU create a new FI instance, setting the new dvGen?

> FieldInfo.setDocValuesGen should not be public.
> -----------------------------------------------
>
>                 Key: LUCENE-5689
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5689
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-5689.patch
>
>
> its currently public and users can modify it. We made this class mostly immutable long ago: remember its returned by the atomicreader API!



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org