[GitHub] [apisix-ingress-controller] nic-6443 commented on a change in pull request #827: feat: ensure that the lease can be actively released before program shutdown to reduce the time required for failover

[GitBox <gi...@apache.org>]

nic-6443 commented on a change in pull request #827:
URL: https://github.com/apache/apisix-ingress-controller/pull/827#discussion_r777877847



##########
File path: pkg/ingress/controller.go
##########
@@ -380,10 +380,7 @@ func (c *Controller) Run(stop chan struct{}) error {
 				c.apisix.DeleteCluster(c.cfg.APISIX.DefaultClusterName)
 			},
 		},
-		// Set it to false as current leaderelection implementation will report
-		// "Failed to release lock: resource name may not be empty" error when
-		// ReleaseOnCancel is true and the Run context is cancelled.
-		ReleaseOnCancel: false,

Review comment:
       It should be, I didn't find the error mentioned in the comment




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org