[jira] [Commented] (SOLR-5041) Add a test to make sure that a leader always recovers from log on startup

["Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14222499#comment-14222499 ] 

Shalin Shekhar Mangar commented on SOLR-5041:
---------------------------------------------

Hi [~vzhovtiuk], this isn't testing what this issue requires. What we need to test is that a node must recover from logs on startup. Killing/restarting the zookeeper is not going to help.

> Add a test to make sure that a leader always recovers from log on startup
> -------------------------------------------------------------------------
>
>                 Key: SOLR-5041
>                 URL: https://issues.apache.org/jira/browse/SOLR-5041
>             Project: Solr
>          Issue Type: Test
>          Components: SolrCloud
>            Reporter: Shalin Shekhar Mangar
>            Assignee: Shalin Shekhar Mangar
>             Fix For: 4.9, Trunk
>
>         Attachments: SOLR-5041.patch
>
>
> From my comment on SOLR-4997:
> bq. I fixed a bug that I had introduced which skipped log recovery on startup for all leaders instead of only sub shard leaders. I caught this only because I was doing another line-by-line review of all my changes. We should have a test which catches such a condition.
> Add a test which tests that leaders always recover from log on startup.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org