You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/02/08 08:56:33 UTC

[GitHub] [rocketmq-spring] joewee edited a comment on issue #429: The 'consumeThreadMax' in annotation @RocketMQMessageListener is not works well

joewee edited a comment on issue #429:
URL: https://github.com/apache/rocketmq-spring/issues/429#issuecomment-1032122875


   I have read the relevant code in ConsumeMessageConcurrentlyService and ConsumeMessageOrderlyService, i think the purpose of use LinkedBlockingQueue with default capacity bound (Integer.MAX_VALUE) is to avoid the message loss caused by the task rejection or the entire consumption process to be blocked as much as possible. In my opinion  the implementation of ConsumeMessageService is right, in other words use one property like 'consumeThreadNum' instead of the 'consumeThreadMax' maybe more suitable for this，then what's your opinion? 
   
   > Duplicate with #173 #184. The issue does exist, but it needs to be fixed in the RocketMQ main repo code.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org