You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by nitin-maharana <gi...@git.apache.org> on 2016/12/26 13:25:12 UTC

[GitHub] cloudstack pull request #1870: CLOUDSTACK-9708: Router deployment filed due ...

GitHub user nitin-maharana opened a pull request:

    https://github.com/apache/cloudstack/pull/1870

    CLOUDSTACK-9708: Router deployment filed due to two threads start VR simultaneously.

    Description:
    =========
    Please see the description in https://issues.apache.org/jira/browse/CLOUDSTACK-9708
    
    Resolution:
    ========
    - The  SearchBuilder instance is a class scope variable that should be instantiated in the constructor.
    - Since it was being instantiated in the scope of the method, parallel calls to the method will overwrite the class variable.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-9708

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1870.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1870
    
----
commit 5092beaf0630efa89188be84f4334d7482c55ae7
Author: Nitin Kumar Maharana <ni...@accelerite.com>
Date:   2016-12-26T13:21:46Z

    CLOUDSTACK-9708: Router deployment filed due to two threads start VR simultaneosuly
    
    Resolution:
    - The  SearchBuilder instance is a class scope variable that should be instantiated in the constructor.
    - Since it was being instantiated in the scope of the method, parallel calls to the method will overwrite the class variable.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1870: CLOUDSTACK-9708: Router deployment failed due to two...

Posted by nitin-maharana <gi...@git.apache.org>.
Github user nitin-maharana commented on the issue:

    https://github.com/apache/cloudstack/pull/1870
  
    @remibergsma : Can you please review it again. Fixed the test failures.
    
    ping @jayapalu @rajesh-battala 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1870: CLOUDSTACK-9708: Router deployment failed due to two...

Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the issue:

    https://github.com/apache/cloudstack/pull/1870
  
    @nitin-maharana Can you please double check this PR? Lots of tests are failing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---