You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Santhosh Edukulla <sa...@citrix.com> on 2013/12/06 17:57:06 UTC
Review Request 16086: Added a temp sleep fix for vm start command
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16086/
-----------------------------------------------------------
Review request for cloudstack.
Repository: cloudstack-git
Description
-------
Added a temporary time sleep fix post a restart command. Applies to 4.2,master,4.3
Note: Has to clean other things as well and will do more cleaner way of handling things.
Diffs
-----
test/integration/smoke/test_volumes.py 816ae03
Diff: https://reviews.apache.org/r/16086/diff/
Testing
-------
No.
Thanks,
Santhosh Edukulla
Re: Review Request 16086: Added a temp sleep fix for vm start command
Posted by Girish Shilamkar <gi...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16086/#review30181
-----------------------------------------------------------
Ship it!
Committed to 4.2, 4.3 and master.
- Girish Shilamkar
On Dec. 6, 2013, 6:28 p.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16086/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2013, 6:28 p.m.)
>
>
> Review request for cloudstack and Girish Shilamkar.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added a temporary time sleep fix post a restart command. Applies to 4.2,master,4.3
>
> Note: Has to clean other things as well and will do more cleaner way of handling things.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_volumes.py 816ae03
>
> Diff: https://reviews.apache.org/r/16086/diff/
>
>
> Testing
> -------
>
> No.
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 16086: Added a temp sleep fix for vm start command
Posted by Santhosh Edukulla <sa...@citrix.com>.
> On Dec. 9, 2013, 8:24 a.m., Sebastien Goasguen wrote:
> > what happens if the machine starts only after 31 s ?
> > Can we have a polling mechanism instead.
1. I mentioned it as part of "Note" under review description. Here, i mentioned to do more cleaner way once time permits.
2. Actually, this is not a permanent fix. There were other clean ups required here. The fix is added when xen team using marvin reported an issue. Sometimes, volume is being detached while the VM is still starting up. If we see there is no status check for vmstart and post the operation. So, post discussion agreed to add up a temp sleep. Thats what even the subject for this review mentions "temp" seep...
- Santhosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16086/#review29993
-----------------------------------------------------------
On Dec. 6, 2013, 6:28 p.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16086/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2013, 6:28 p.m.)
>
>
> Review request for cloudstack and Girish Shilamkar.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added a temporary time sleep fix post a restart command. Applies to 4.2,master,4.3
>
> Note: Has to clean other things as well and will do more cleaner way of handling things.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_volumes.py 816ae03
>
> Diff: https://reviews.apache.org/r/16086/diff/
>
>
> Testing
> -------
>
> No.
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 16086: Added a temp sleep fix for vm start command
Posted by Sebastien Goasguen <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16086/#review29993
-----------------------------------------------------------
what happens if the machine starts only after 31 s ?
Can we have a polling mechanism instead.
- Sebastien Goasguen
On Dec. 6, 2013, 6:28 p.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16086/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2013, 6:28 p.m.)
>
>
> Review request for cloudstack and Girish Shilamkar.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added a temporary time sleep fix post a restart command. Applies to 4.2,master,4.3
>
> Note: Has to clean other things as well and will do more cleaner way of handling things.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_volumes.py 816ae03
>
> Diff: https://reviews.apache.org/r/16086/diff/
>
>
> Testing
> -------
>
> No.
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 16086: Added a temp sleep fix for vm start command
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16086/#review29992
-----------------------------------------------------------
Can you add more description about why this sleep is required? or add the related JIRA bug number to the RB request.
- SrikanteswaraRao Talluri
On Dec. 6, 2013, 6:28 p.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16086/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2013, 6:28 p.m.)
>
>
> Review request for cloudstack and Girish Shilamkar.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added a temporary time sleep fix post a restart command. Applies to 4.2,master,4.3
>
> Note: Has to clean other things as well and will do more cleaner way of handling things.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_volumes.py 816ae03
>
> Diff: https://reviews.apache.org/r/16086/diff/
>
>
> Testing
> -------
>
> No.
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 16086: Added a temp sleep fix for vm start command
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16086/
-----------------------------------------------------------
(Updated Dec. 6, 2013, 6:28 p.m.)
Review request for cloudstack and Girish Shilamkar.
Changes
-------
Added a reviewer
Repository: cloudstack-git
Description
-------
Added a temporary time sleep fix post a restart command. Applies to 4.2,master,4.3
Note: Has to clean other things as well and will do more cleaner way of handling things.
Diffs
-----
test/integration/smoke/test_volumes.py 816ae03
Diff: https://reviews.apache.org/r/16086/diff/
Testing
-------
No.
Thanks,
Santhosh Edukulla