[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4556: Support aws s3 with Parquet in pinot-tools

[GitBox <gi...@apache.org>]

kishoreg commented on a change in pull request #4556: Support aws s3 with Parquet in pinot-tools
URL: https://github.com/apache/incubator-pinot/pull/4556#discussion_r317314231
 
 

 ##########
 File path: pinot-tools/pom.xml
 ##########
 @@ -98,6 +103,21 @@
       <groupId>org.apache.commons</groupId>
       <artifactId>commons-math3</artifactId>
     </dependency>
+    <dependency>
+      <groupId>org.apache.hadoop</groupId>
 
 Review comment:
   This is adding it only tools right not to core. We definitely need to extract out all things related to format and filesystems out of pinot-core and make it pluggable. But for now, this is the only solution I can think of adding support for different formats.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org