You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "JingsongLi (via GitHub)" <gi...@apache.org> on 2023/04/10 03:44:50 UTC
[GitHub] [incubator-paimon] JingsongLi opened a new pull request, #856: [flink] Assign splits evenly in StaticFileStoreSplitEnumerator
JingsongLi opened a new pull request, #856:
URL: https://github.com/apache/incubator-paimon/pull/856
### Purpose
Assign splits evenly in StaticFileStoreSplitEnumerator, this can avoid the long tail problem caused by uneven distribution.
### Tests
FixBinPackingTest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi merged pull request #856: [flink] Assign splits evenly in StaticFileStoreSplitEnumerator
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #856:
URL: https://github.com/apache/incubator-paimon/pull/856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] sonarcloud[bot] commented on pull request #856: [flink] Assign splits evenly in StaticFileStoreSplitEnumerator
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #856:
URL: https://github.com/apache/incubator-paimon/pull/856#issuecomment-1501361904
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_incubator-paimon&pullRequest=856)
[](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=856&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=856&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=856&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=856&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=856&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=856&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-paimon&pullRequest=856&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-paimon&pullRequest=856&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-paimon&pullRequest=856&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=856&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=856&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=856&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_incubator-paimon&pullRequest=856) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_incubator-paimon&pullRequest=856&metric=new_duplicated_lines_density&view=list) [1.8% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-paimon&pullRequest=856&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] yuzelin commented on a diff in pull request #856: [flink] Assign splits evenly in StaticFileStoreSplitEnumerator
Posted by "yuzelin (via GitHub)" <gi...@apache.org>.
yuzelin commented on code in PR #856:
URL: https://github.com/apache/incubator-paimon/pull/856#discussion_r1161686956
##########
paimon-common/src/main/java/org/apache/paimon/utils/FixBinPacking.java:
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.paimon.utils;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.PriorityQueue;
+import java.util.function.Function;
+
+import static java.util.Comparator.comparingLong;
+
+/** A bin packing implementation for fixed bin number. */
+public class FixBinPacking {
+ private FixBinPacking() {}
+
+ public static <T> List<List<T>> pack(
+ Iterable<T> items, Function<T, Long> weightFunc, int binNumber) {
+ // 1. sort items first
+ List<T> sorted = new ArrayList<>();
+ items.forEach(sorted::add);
+ sorted.sort(comparingLong(weightFunc::apply));
+
+ // 2. packing
+ List<List<T>> packed = new ArrayList<>();
+ PriorityQueue<Bin<T>> bins = new PriorityQueue<>();
+ for (T item : sorted) {
+ long weight = weightFunc.apply(item);
+ Bin<T> bin = bins.size() < binNumber ? new Bin<>() : bins.poll();
+ bin.add(item, weight);
+ bins.add(bin);
+ }
+
+ // 3. output
+ bins.forEach(bin -> packed.add(bin.items));
+ return packed;
+ }
Review Comment:
Better to move Line 40 to close to Line 50.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org