[GitHub] [ignite] pvinokurov commented on a change in pull request #8547: IGNITE-13507 NullPointerException on tx recovery

[GitBox <gi...@apache.org>]

pvinokurov commented on a change in pull request #8547:
URL: https://github.com/apache/ignite/pull/8547#discussion_r544791554



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxManager.java
##########
@@ -3353,9 +3353,14 @@ else if (tx.setRollbackOnly())
          * @return True if message required, false otherwise.
          */
         private boolean isMvccRecoveryMessageRequired() {
-            return node.isClient() && mvccCrd != null && mvccCrd.nodeId() != null &&
+            ClusterNode mvccCrdNode = null;
+
+            if (mvccCrd != null && mvccCrd.nodeId() != null)
+                mvccCrdNode = cctx.node(mvccCrd.nodeId());
+
+            return node.isClient() && mvccCrdNode != null &&
                 (cctx.kernalContext().coordinators().mvccEnabled() ||
-                    !IgniteFeatures.nodeSupports(cctx.node(mvccCrd.nodeId()), IgniteFeatures.MVCC_TX_RECOVERY_PROTOCOL_V2));
+                    !IgniteFeatures.nodeSupports(mvccCrdNode, IgniteFeatures.MVCC_TX_RECOVERY_PROTOCOL_V2));

Review comment:
       I am not sure that it is related to comatibility. It was introduced as an optimization within fixes for https://issues.apache.org/jira/browse/IGNITE-12350




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org