You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by "Michael Vorburger (Jira)" <ji...@apache.org> on 2020/01/10 17:04:00 UTC

[jira] [Commented] (FINERACT-712) Fineract codebase should pass PMD, Findbugs and Checkstyle analysis

    [ https://issues.apache.org/jira/browse/FINERACT-712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013064#comment-17013064 ] 

Michael Vorburger commented on FINERACT-712:
--------------------------------------------

1. *SpotBugs* is getting done in FINERACT-702.
 
2. *Checkstyle* would be really really useful and great as well; I've created a new FINERACT-821 to specifically track that.

3. *Error Prone* is another tool which IMHO will add real value, see FINERACT-822 for adding that.

4. *Modernizer* is yet another such tool which would be useful, see FINERACT-823.

5. *PMD* would need similar work (re-enable it by undoing [https://github.com/apache/fineract/pull/612/files] AND removing ignoreFailures = true, else it's pointless).

> Fineract codebase should pass PMD, Findbugs and Checkstyle analysis
> -------------------------------------------------------------------
>
>                 Key: FINERACT-712
>                 URL: https://issues.apache.org/jira/browse/FINERACT-712
>             Project: Apache Fineract
>          Issue Type: Improvement
>            Reporter: Vishwas Babu A J
>            Assignee: Awasum Yannick
>            Priority: Major
>              Labels: gsoc2019
>   Original Estimate: 80h
>  Remaining Estimate: 80h
>
> The fineract codebase has findbugs (now spotbugs) and PMD gradle plugins, however, the ignoreFailures option is enabled on the gradle file. Disabling the same and fixing current errors is crucial for the long term maintainability of the Fineract project.
> Another good to have would be checkstyle analysis.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)