You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2019/11/08 20:38:12 UTC

[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #135: HDDS-2451. Use lazy string evaluation in preconditions

adoroszlai opened a new pull request #135: HDDS-2451. Use lazy string evaluation in preconditions
URL: https://github.com/apache/hadoop-ozone/pull/135
 
 
   ## What changes were proposed in this pull request?
   
   Use the version of `Preconditions.check...` that accepts `errorMessageTemplate` and `errorMessageArgs`.
   
   There are occurrences of the `errorMessage` version left, but they do not seem to be important:
   
   1. use constant message, or
   2. are infrequently used (eg. one-time init in `MetadataKeyFilters`), or
   3. only append a plain `long` (container ID) to the message.
   
   https://issues.apache.org/jira/browse/HDDS-2451
   
   ## How was this patch tested?
   
   Ran related unit tests and checkstyle.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org