You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/06/01 03:36:32 UTC
[kudu-CR] [hms] Add a tool to list all Kudu HMS entries
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13490
Change subject: [hms] Add a tool to list all Kudu HMS entries
......................................................................
[hms] Add a tool to list all Kudu HMS entries
Adds a tool to list the Kudu HMS entries with optional
columns in various formats.
Change-Id: Ib18cde6e92e799390bb977562fd8d2eac2dae026
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_hms.cc
2 files changed, 69 insertions(+), 22 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/13490/1
--
To view, visit http://gerrit.cloudera.org:8080/13490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib18cde6e92e799390bb977562fd8d2eac2dae026
Gerrit-Change-Number: 13490
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [hms] Add a tool to list all Kudu HMS entries
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13490 )
Change subject: [hms] Add a tool to list all Kudu HMS entries
......................................................................
Patch Set 2:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/13490/2/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
PS2:
> It would be great to add coverage for newly introduced commands into:
Done
http://gerrit.cloudera.org:8080/#/c/13490/2/src/kudu/tools/kudu-tool-test.cc@3887
PS2, Line 3887: // Enable the HMS integration.
: cluster_->ShutdownNodes(cluster::ClusterNodes::MASTERS_ONLY);
: cluster_->EnableMetastoreIntegration();
> What does the tool output in case if the integration disabled? Does it mak
Done
http://gerrit.cloudera.org:8080/#/c/13490/2/src/kudu/tools/tool_action_hms.cc
File src/kudu/tools/tool_action_hms.cc:
http://gerrit.cloudera.org:8080/#/c/13490/2/src/kudu/tools/tool_action_hms.cc@794
PS2, Line 794: RETURN_NOT_OK(PrintHMSTables(hms_tables, cout));
:
: return Status::OK();
> nit: maybe just
Done
http://gerrit.cloudera.org:8080/#/c/13490/2/src/kudu/tools/tool_action_hms.cc@857
PS2, Line 857: string(
> nit: I would expect this extra object was not needed, since Substitute() re
Done
http://gerrit.cloudera.org:8080/#/c/13490/2/src/kudu/tools/tool_action_hms.cc@859
PS2, Line 859: string(
> nit: ditto
Done
http://gerrit.cloudera.org:8080/#/c/13490/2/src/kudu/tools/tool_action_hms.cc@870
PS2, Line 870: .AddAction(std::move(hms_check))
: .AddAction(std::move(hms_downgrade))
: .AddAction(std::move(hms_fix))
: .AddAction(std::move(hms_precheck))
: .AddAction(std::move(hms_list))
> nit: sort alphabetically; same for the Action within 815-868 line span
Done
--
To view, visit http://gerrit.cloudera.org:8080/13490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib18cde6e92e799390bb977562fd8d2eac2dae026
Gerrit-Change-Number: 13490
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 01 Jun 2019 15:10:02 +0000
Gerrit-HasComments: Yes
[kudu-CR] [hms] Add a tool to list all Kudu HMS entries
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13490 )
Change subject: [hms] Add a tool to list all Kudu HMS entries
......................................................................
[hms] Add a tool to list all Kudu HMS entries
Adds a tool to list the Kudu HMS entries with optional
columns in various formats.
Change-Id: Ib18cde6e92e799390bb977562fd8d2eac2dae026
Reviewed-on: http://gerrit.cloudera.org:8080/13490
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_hms.cc
2 files changed, 155 insertions(+), 3 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib18cde6e92e799390bb977562fd8d2eac2dae026
Gerrit-Change-Number: 13490
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [hms] Add a tool to list all Kudu HMS entries
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13490 )
Change subject: [hms] Add a tool to list all Kudu HMS entries
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13490/4/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
http://gerrit.cloudera.org:8080/#/c/13490/4/src/kudu/tools/kudu-tool-test.cc@972
PS4, Line 972: {
Thank you for adding these!
--
To view, visit http://gerrit.cloudera.org:8080/13490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib18cde6e92e799390bb977562fd8d2eac2dae026
Gerrit-Change-Number: 13490
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 01 Jun 2019 23:44:12 +0000
Gerrit-HasComments: Yes
[kudu-CR] [hms] Add a tool to list all Kudu HMS entries
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13490 )
Change subject: [hms] Add a tool to list all Kudu HMS entries
......................................................................
Patch Set 2:
(6 comments)
LGTM, just a few nits
http://gerrit.cloudera.org:8080/#/c/13490/2/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
PS2:
It would be great to add coverage for newly introduced commands into:
* TEST_F(ToolTest, TestTopLevelHelp)
* TEST_F(ToolTest, TestModeHelp)
http://gerrit.cloudera.org:8080/#/c/13490/2/src/kudu/tools/kudu-tool-test.cc@3887
PS2, Line 3887: // Enable the HMS integration.
: cluster_->ShutdownNodes(cluster::ClusterNodes::MASTERS_ONLY);
: cluster_->EnableMetastoreIntegration();
What does the tool output in case if the integration disabled? Does it make sense to add coverage for that case?
http://gerrit.cloudera.org:8080/#/c/13490/2/src/kudu/tools/tool_action_hms.cc
File src/kudu/tools/tool_action_hms.cc:
http://gerrit.cloudera.org:8080/#/c/13490/2/src/kudu/tools/tool_action_hms.cc@794
PS2, Line 794: RETURN_NOT_OK(PrintHMSTables(hms_tables, cout));
:
: return Status::OK();
nit: maybe just
return PrintHMSTables(hms_tables, cout);
?
http://gerrit.cloudera.org:8080/#/c/13490/2/src/kudu/tools/tool_action_hms.cc@857
PS2, Line 857: string(
nit: I would expect this extra object was not needed, since Substitute() returns std::string already.
http://gerrit.cloudera.org:8080/#/c/13490/2/src/kudu/tools/tool_action_hms.cc@859
PS2, Line 859: string(
nit: ditto
http://gerrit.cloudera.org:8080/#/c/13490/2/src/kudu/tools/tool_action_hms.cc@870
PS2, Line 870: .AddAction(std::move(hms_check))
: .AddAction(std::move(hms_downgrade))
: .AddAction(std::move(hms_fix))
: .AddAction(std::move(hms_precheck))
: .AddAction(std::move(hms_list))
nit: sort alphabetically; same for the Action within 815-868 line span
--
To view, visit http://gerrit.cloudera.org:8080/13490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib18cde6e92e799390bb977562fd8d2eac2dae026
Gerrit-Change-Number: 13490
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 01 Jun 2019 06:25:27 +0000
Gerrit-HasComments: Yes
[kudu-CR] [hms] Add a tool to list all Kudu HMS entries
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13490
to look at the new patch set (#2).
Change subject: [hms] Add a tool to list all Kudu HMS entries
......................................................................
[hms] Add a tool to list all Kudu HMS entries
Adds a tool to list the Kudu HMS entries with optional
columns in various formats.
Change-Id: Ib18cde6e92e799390bb977562fd8d2eac2dae026
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_hms.cc
2 files changed, 136 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/13490/2
--
To view, visit http://gerrit.cloudera.org:8080/13490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib18cde6e92e799390bb977562fd8d2eac2dae026
Gerrit-Change-Number: 13490
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [hms] Add a tool to list all Kudu HMS entries
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13490
to look at the new patch set (#3).
Change subject: [hms] Add a tool to list all Kudu HMS entries
......................................................................
[hms] Add a tool to list all Kudu HMS entries
Adds a tool to list the Kudu HMS entries with optional
columns in various formats.
Change-Id: Ib18cde6e92e799390bb977562fd8d2eac2dae026
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_hms.cc
2 files changed, 154 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/13490/3
--
To view, visit http://gerrit.cloudera.org:8080/13490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib18cde6e92e799390bb977562fd8d2eac2dae026
Gerrit-Change-Number: 13490
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [hms] Add a tool to list all Kudu HMS entries
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13490
to look at the new patch set (#4).
Change subject: [hms] Add a tool to list all Kudu HMS entries
......................................................................
[hms] Add a tool to list all Kudu HMS entries
Adds a tool to list the Kudu HMS entries with optional
columns in various formats.
Change-Id: Ib18cde6e92e799390bb977562fd8d2eac2dae026
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_hms.cc
2 files changed, 155 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/13490/4
--
To view, visit http://gerrit.cloudera.org:8080/13490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib18cde6e92e799390bb977562fd8d2eac2dae026
Gerrit-Change-Number: 13490
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)