You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2017/11/07 13:38:33 UTC

Review Request 63617: Log Feeder should be able to run locally with dockerized dev env by default

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63617/
-----------------------------------------------------------

Review request for Ambari, Krisztian Kasa and Robert Nettleton.


Bugs: AMBARI-22364
    https://issues.apache.org/jira/browse/AMBARI-22364


Repository: ambari


Description
-------

Run logfeeder locally, requirements:
- some changes in run logsearch configs (add --monitor flag, set workspace folder)

logfeeder.properties work with docker environment


Diffs
-----

  ambari-logsearch/ambari-logsearch-logfeeder/README.md 5a64daf 
  ambari-logsearch/ambari-logsearch-logfeeder/pom.xml b1b6ece 
  ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log-samples/.gitignore PRE-CREATION 
  ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log-samples/logs/service_sample.txt PRE-CREATION 
  ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log-samples/shipper-conf/global.config.json PRE-CREATION 
  ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log-samples/shipper-conf/input.config-sample.json PRE-CREATION 
  ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log-samples/shipper-conf/output.config-sample.json PRE-CREATION 
  ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log4j.xml 8d5174e 
  ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/logfeeder.properties 74ea0ef 


Diff: https://reviews.apache.org/r/63617/diff/1/


Testing
-------

done with docker-compose commands


Thanks,

Oliver Szabo


Re: Review Request 63617: Log Feeder should be able to run locally with dockerized dev env by default

Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63617/#review190326
-----------------------------------------------------------


Ship it!




Ship It!

- Robert Nettleton


On Nov. 7, 2017, 1:38 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63617/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2017, 1:38 p.m.)
> 
> 
> Review request for Ambari, Krisztian Kasa and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22364
>     https://issues.apache.org/jira/browse/AMBARI-22364
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Run logfeeder locally, requirements:
> - some changes in run logsearch configs (add --monitor flag, set workspace folder)
> 
> logfeeder.properties work with docker environment
> 
> 
> Diffs
> -----
> 
>   ambari-logsearch/ambari-logsearch-logfeeder/README.md 5a64daf 
>   ambari-logsearch/ambari-logsearch-logfeeder/pom.xml b1b6ece 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log-samples/.gitignore PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log-samples/logs/service_sample.txt PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log-samples/shipper-conf/global.config.json PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log-samples/shipper-conf/input.config-sample.json PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log-samples/shipper-conf/output.config-sample.json PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log4j.xml 8d5174e 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/logfeeder.properties 74ea0ef 
> 
> 
> Diff: https://reviews.apache.org/r/63617/diff/1/
> 
> 
> Testing
> -------
> 
> done with docker-compose commands
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>


Re: Review Request 63617: Log Feeder should be able to run locally with dockerized dev env by default

Posted by Krisztian Kasa <kk...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63617/#review190307
-----------------------------------------------------------


Ship it!




Ship It!

- Krisztian Kasa


On Nov. 7, 2017, 1:38 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63617/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2017, 1:38 p.m.)
> 
> 
> Review request for Ambari, Krisztian Kasa and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22364
>     https://issues.apache.org/jira/browse/AMBARI-22364
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Run logfeeder locally, requirements:
> - some changes in run logsearch configs (add --monitor flag, set workspace folder)
> 
> logfeeder.properties work with docker environment
> 
> 
> Diffs
> -----
> 
>   ambari-logsearch/ambari-logsearch-logfeeder/README.md 5a64daf 
>   ambari-logsearch/ambari-logsearch-logfeeder/pom.xml b1b6ece 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log-samples/.gitignore PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log-samples/logs/service_sample.txt PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log-samples/shipper-conf/global.config.json PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log-samples/shipper-conf/input.config-sample.json PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log-samples/shipper-conf/output.config-sample.json PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log4j.xml 8d5174e 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/logfeeder.properties 74ea0ef 
> 
> 
> Diff: https://reviews.apache.org/r/63617/diff/1/
> 
> 
> Testing
> -------
> 
> done with docker-compose commands
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>