You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2020/09/09 08:58:43 UTC

[GitHub] [tinkerpop] rdtr commented on pull request #1325: [TINKERPOP-2416] MultiIterator should implement AutoCloseable

rdtr commented on pull request #1325:
URL: https://github.com/apache/tinkerpop/pull/1325#issuecomment-689428667


   I agree that we don't need to explicitly call `close` in TinkerPop's code.
   
   The change is mainly for providers. When overriding TinkerPop's API to retrieve elements from their own internal Storage layer, if the returned iterator holds any reference which must be released in the end, it is the provider's responsibility to call `close` in their own method. 
   
   TinkerPop's base class and TinkerGraph doesn't have the resource issue so we don't need to call `close` there.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org