You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fx-dev@ws.apache.org by "Matt Lovett (JIRA)" <ji...@apache.org> on 2006/08/07 16:11:59 UTC
[jira] Created: (SANDESHA2-20) Refactor ack header processing
Refactor ack header processing
------------------------------
Key: SANDESHA2-20
URL: http://issues.apache.org/jira/browse/SANDESHA2-20
Project: Apache Sandesha2
Issue Type: Improvement
Reporter: Matt Lovett
Priority: Minor
Attachments: ackPatch.txt
As I have hinted a few times on list, I think that the message processing through the sandesha handlers could be refactored into header processing (within the handlers), and body processing (in a message receiver). This patch is the start of that work, refactoring the ack header processing.
This patch also fixes a defect along the way, as there might be multiple ack headers on an inbound message.
If this patch is accepted then I'll do the same for the ackRequest header, and then move on to the body processing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Commented: (SANDESHA2-20) Refactor ack header processing
Posted by "Matt Lovett (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-20?page=comments#action_12445127 ]
Matt Lovett commented on SANDESHA2-20:
--------------------------------------
Unfortunately sandesha has already moved on enough to make the patch fail.... I'll get sync up and attach another one soon.
Matt
> Refactor ack header processing
> ------------------------------
>
> Key: SANDESHA2-20
> URL: http://issues.apache.org/jira/browse/SANDESHA2-20
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Priority: Minor
> Attachments: ackPatch.txt, ackPatch.txt, ackRequested.patch, rework.patch, rework2.patch
>
>
> As I have hinted a few times on list, I think that the message processing through the sandesha handlers could be refactored into header processing (within the handlers), and body processing (in a message receiver). This patch is the start of that work, refactoring the ack header processing.
> This patch also fixes a defect along the way, as there might be multiple ack headers on an inbound message.
> If this patch is accepted then I'll do the same for the ackRequest header, and then move on to the body processing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Commented: (SANDESHA2-20) Refactor ack header processing
Posted by "Chamikara Jayalath (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-20?page=comments#action_12427161 ]
Chamikara Jayalath commented on SANDESHA2-20:
---------------------------------------------
Applied. Thanks.
Chamikara
> Refactor ack header processing
> ------------------------------
>
> Key: SANDESHA2-20
> URL: http://issues.apache.org/jira/browse/SANDESHA2-20
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Priority: Minor
> Attachments: ackPatch.txt, ackPatch.txt
>
>
> As I have hinted a few times on list, I think that the message processing through the sandesha handlers could be refactored into header processing (within the handlers), and body processing (in a message receiver). This patch is the start of that work, refactoring the ack header processing.
> This patch also fixes a defect along the way, as there might be multiple ack headers on an inbound message.
> If this patch is accepted then I'll do the same for the ackRequest header, and then move on to the body processing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Commented: (SANDESHA2-20) Refactor ack header processing
Posted by "David Illsley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-20?page=comments#action_12445105 ]
David Illsley commented on SANDESHA2-20:
----------------------------------------
Chamikara, I committed the relevant changes from AXIS2-1457 to Axis2 a couple of days ago.
You should be good to go ahead with this patch.
> Refactor ack header processing
> ------------------------------
>
> Key: SANDESHA2-20
> URL: http://issues.apache.org/jira/browse/SANDESHA2-20
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Priority: Minor
> Attachments: ackPatch.txt, ackPatch.txt, ackRequested.patch, rework.patch, rework2.patch
>
>
> As I have hinted a few times on list, I think that the message processing through the sandesha handlers could be refactored into header processing (within the handlers), and body processing (in a message receiver). This patch is the start of that work, refactoring the ack header processing.
> This patch also fixes a defect along the way, as there might be multiple ack headers on an inbound message.
> If this patch is accepted then I'll do the same for the ackRequest header, and then move on to the body processing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Updated: (SANDESHA2-20) Refactor ack header processing
Posted by "Matt Lovett (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-20?page=all ]
Matt Lovett updated SANDESHA2-20:
---------------------------------
Attachment: operation.patch
I missed a couple of places where we construct new operations instead of looking up the ones in module.xml. This patch cleans them up too.
Thanks,
Matt
> Refactor ack header processing
> ------------------------------
>
> Key: SANDESHA2-20
> URL: http://issues.apache.org/jira/browse/SANDESHA2-20
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Priority: Minor
> Attachments: ackPatch.txt, ackPatch.txt, ackRequested.patch, operation.patch, rework.patch, rework2.patch, rework3.patch
>
>
> As I have hinted a few times on list, I think that the message processing through the sandesha handlers could be refactored into header processing (within the handlers), and body processing (in a message receiver). This patch is the start of that work, refactoring the ack header processing.
> This patch also fixes a defect along the way, as there might be multiple ack headers on an inbound message.
> If this patch is accepted then I'll do the same for the ackRequest header, and then move on to the body processing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Resolved: (SANDESHA2-20) Refactor ack header processing
Posted by "Matt Lovett (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-20?page=all ]
Matt Lovett resolved SANDESHA2-20.
----------------------------------
Resolution: Fixed
> Refactor ack header processing
> ------------------------------
>
> Key: SANDESHA2-20
> URL: http://issues.apache.org/jira/browse/SANDESHA2-20
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Priority: Minor
> Attachments: ackPatch.txt, ackPatch.txt, ackRequested.patch, operation.patch, rework.patch, rework2.patch, rework3.patch
>
>
> As I have hinted a few times on list, I think that the message processing through the sandesha handlers could be refactored into header processing (within the handlers), and body processing (in a message receiver). This patch is the start of that work, refactoring the ack header processing.
> This patch also fixes a defect along the way, as there might be multiple ack headers on an inbound message.
> If this patch is accepted then I'll do the same for the ackRequest header, and then move on to the body processing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Commented: (SANDESHA2-20) Refactor ack header processing
Posted by "Chamikara Jayalath (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-20?page=comments#action_12445479 ]
Chamikara Jayalath commented on SANDESHA2-20:
---------------------------------------------
Hi Matt,
I created the branch for Sandesha2 1.1. Please send a new patch for this issue to be applied against the trunk.
Chamikara
> Refactor ack header processing
> ------------------------------
>
> Key: SANDESHA2-20
> URL: http://issues.apache.org/jira/browse/SANDESHA2-20
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Priority: Minor
> Attachments: ackPatch.txt, ackPatch.txt, ackRequested.patch, rework.patch, rework2.patch
>
>
> As I have hinted a few times on list, I think that the message processing through the sandesha handlers could be refactored into header processing (within the handlers), and body processing (in a message receiver). This patch is the start of that work, refactoring the ack header processing.
> This patch also fixes a defect along the way, as there might be multiple ack headers on an inbound message.
> If this patch is accepted then I'll do the same for the ackRequest header, and then move on to the body processing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Commented: (SANDESHA2-20) Refactor ack header processing
Posted by "Chamikara Jayalath (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-20?page=comments#action_12445479 ]
Chamikara Jayalath commented on SANDESHA2-20:
---------------------------------------------
Hi Matt,
I created the branch for Sandesha2 1.1. Please send a new patch for this issue to be applied against the trunk.
Chamikara
> Refactor ack header processing
> ------------------------------
>
> Key: SANDESHA2-20
> URL: http://issues.apache.org/jira/browse/SANDESHA2-20
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Priority: Minor
> Attachments: ackPatch.txt, ackPatch.txt, ackRequested.patch, rework.patch, rework2.patch
>
>
> As I have hinted a few times on list, I think that the message processing through the sandesha handlers could be refactored into header processing (within the handlers), and body processing (in a message receiver). This patch is the start of that work, refactoring the ack header processing.
> This patch also fixes a defect along the way, as there might be multiple ack headers on an inbound message.
> If this patch is accepted then I'll do the same for the ackRequest header, and then move on to the body processing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Commented: (SANDESHA2-20) Refactor ack header processing
Posted by "Chamikara Jayalath (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-20?page=comments#action_12445149 ]
Chamikara Jayalath commented on SANDESHA2-20:
---------------------------------------------
It seems like this patch will make Sandesha2 head diverge from Axis2 1.1. So seems like its time to create a Sandesha2 branch as we agreed before. Let me do it before appling this patch.
Chamikara
> Refactor ack header processing
> ------------------------------
>
> Key: SANDESHA2-20
> URL: http://issues.apache.org/jira/browse/SANDESHA2-20
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Priority: Minor
> Attachments: ackPatch.txt, ackPatch.txt, ackRequested.patch, rework.patch, rework2.patch
>
>
> As I have hinted a few times on list, I think that the message processing through the sandesha handlers could be refactored into header processing (within the handlers), and body processing (in a message receiver). This patch is the start of that work, refactoring the ack header processing.
> This patch also fixes a defect along the way, as there might be multiple ack headers on an inbound message.
> If this patch is accepted then I'll do the same for the ackRequest header, and then move on to the body processing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Updated: (SANDESHA2-20) Refactor ack header processing
Posted by "Matt Lovett (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-20?page=all ]
Matt Lovett updated SANDESHA2-20:
---------------------------------
Attachment: ackPatch.txt
Re-attaching, as I didn't grant ASF license first time I attached it!
> Refactor ack header processing
> ------------------------------
>
> Key: SANDESHA2-20
> URL: http://issues.apache.org/jira/browse/SANDESHA2-20
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Priority: Minor
> Attachments: ackPatch.txt, ackPatch.txt
>
>
> As I have hinted a few times on list, I think that the message processing through the sandesha handlers could be refactored into header processing (within the handlers), and body processing (in a message receiver). This patch is the start of that work, refactoring the ack header processing.
> This patch also fixes a defect along the way, as there might be multiple ack headers on an inbound message.
> If this patch is accepted then I'll do the same for the ackRequest header, and then move on to the body processing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Commented: (SANDESHA2-20) Refactor ack header processing
Posted by "Chamikara Jayalath (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-20?page=comments#action_12445013 ]
Chamikara Jayalath commented on SANDESHA2-20:
---------------------------------------------
Hi Matt,
This patch seems to be dependent on a patch u submitted to http://issues.apache.org/jira/browse/AXIS2-1457?page=all.
So we cannot commit this until Axis2 is fixed right?
Chamikara
> Refactor ack header processing
> ------------------------------
>
> Key: SANDESHA2-20
> URL: http://issues.apache.org/jira/browse/SANDESHA2-20
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Priority: Minor
> Attachments: ackPatch.txt, ackPatch.txt, ackRequested.patch, rework.patch, rework2.patch
>
>
> As I have hinted a few times on list, I think that the message processing through the sandesha handlers could be refactored into header processing (within the handlers), and body processing (in a message receiver). This patch is the start of that work, refactoring the ack header processing.
> This patch also fixes a defect along the way, as there might be multiple ack headers on an inbound message.
> If this patch is accepted then I'll do the same for the ackRequest header, and then move on to the body processing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Updated: (SANDESHA2-20) Refactor ack header processing
Posted by "Matt Lovett (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-20?page=all ]
Matt Lovett updated SANDESHA2-20:
---------------------------------
Attachment: rework2.patch
Oops - I hadn't resolved some svn conflicts properly in that version of the patch, here's a better one.
Apologies,
Matt
> Refactor ack header processing
> ------------------------------
>
> Key: SANDESHA2-20
> URL: http://issues.apache.org/jira/browse/SANDESHA2-20
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Priority: Minor
> Attachments: ackPatch.txt, ackPatch.txt, ackRequested.patch, rework.patch, rework2.patch
>
>
> As I have hinted a few times on list, I think that the message processing through the sandesha handlers could be refactored into header processing (within the handlers), and body processing (in a message receiver). This patch is the start of that work, refactoring the ack header processing.
> This patch also fixes a defect along the way, as there might be multiple ack headers on an inbound message.
> If this patch is accepted then I'll do the same for the ackRequest header, and then move on to the body processing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Commented: (SANDESHA2-20) Refactor ack header processing
Posted by "Chamikara Jayalath (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-20?page=comments#action_12445149 ]
Chamikara Jayalath commented on SANDESHA2-20:
---------------------------------------------
It seems like this patch will make Sandesha2 head diverge from Axis2 1.1. So seems like its time to create a Sandesha2 branch as we agreed before. Let me do it before appling this patch.
Chamikara
> Refactor ack header processing
> ------------------------------
>
> Key: SANDESHA2-20
> URL: http://issues.apache.org/jira/browse/SANDESHA2-20
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Priority: Minor
> Attachments: ackPatch.txt, ackPatch.txt, ackRequested.patch, rework.patch, rework2.patch
>
>
> As I have hinted a few times on list, I think that the message processing through the sandesha handlers could be refactored into header processing (within the handlers), and body processing (in a message receiver). This patch is the start of that work, refactoring the ack header processing.
> This patch also fixes a defect along the way, as there might be multiple ack headers on an inbound message.
> If this patch is accepted then I'll do the same for the ackRequest header, and then move on to the body processing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Commented: (SANDESHA2-20) Refactor ack header processing
Posted by "Chamikara Jayalath (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-20?page=comments#action_12435171 ]
Chamikara Jayalath commented on SANDESHA2-20:
---------------------------------------------
Applied the patch from Matt.
Chamikara
> Refactor ack header processing
> ------------------------------
>
> Key: SANDESHA2-20
> URL: http://issues.apache.org/jira/browse/SANDESHA2-20
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Priority: Minor
> Attachments: ackPatch.txt, ackPatch.txt, ackRequested.patch
>
>
> As I have hinted a few times on list, I think that the message processing through the sandesha handlers could be refactored into header processing (within the handlers), and body processing (in a message receiver). This patch is the start of that work, refactoring the ack header processing.
> This patch also fixes a defect along the way, as there might be multiple ack headers on an inbound message.
> If this patch is accepted then I'll do the same for the ackRequest header, and then move on to the body processing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Commented: (SANDESHA2-20) Refactor ack header processing
Posted by "Chamikara Jayalath (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-20?page=comments#action_12435171 ]
Chamikara Jayalath commented on SANDESHA2-20:
---------------------------------------------
Applied the patch from Matt.
Chamikara
> Refactor ack header processing
> ------------------------------
>
> Key: SANDESHA2-20
> URL: http://issues.apache.org/jira/browse/SANDESHA2-20
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Priority: Minor
> Attachments: ackPatch.txt, ackPatch.txt, ackRequested.patch
>
>
> As I have hinted a few times on list, I think that the message processing through the sandesha handlers could be refactored into header processing (within the handlers), and body processing (in a message receiver). This patch is the start of that work, refactoring the ack header processing.
> This patch also fixes a defect along the way, as there might be multiple ack headers on an inbound message.
> If this patch is accepted then I'll do the same for the ackRequest header, and then move on to the body processing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Updated: (SANDESHA2-20) Refactor ack header processing
Posted by "Matt Lovett (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-20?page=all ]
Matt Lovett updated SANDESHA2-20:
---------------------------------
Attachment: rework.patch
Here's another patch, continuing the header processing theme. With this, inbound Sequence headers get processed in the InHandler (by the new SequenceProcessor class), but the message body is now handled by the message receiver (and application messages will run through to the app message receiver, not the sandesha one). That's goodness as it means we fit in with the axis architecture better, and could also cope with odd situations like a CreateSequence message that was sent reliably.
I also took the opportunity to change module.xml so that the inbound operations will be resolved correctly (by action), and outbound operations are now looked up instead of being created each time. I believe this will ensure that op.isClientSide() will now be telling the truth for all our flows.
This patch depends on the Axis2 jira at http://issues.apache.org/jira/browse/AXIS2-1457
and it won't work before that patch goes in
Thanks,
Matt
> Refactor ack header processing
> ------------------------------
>
> Key: SANDESHA2-20
> URL: http://issues.apache.org/jira/browse/SANDESHA2-20
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Priority: Minor
> Attachments: ackPatch.txt, ackPatch.txt, ackRequested.patch, rework.patch
>
>
> As I have hinted a few times on list, I think that the message processing through the sandesha handlers could be refactored into header processing (within the handlers), and body processing (in a message receiver). This patch is the start of that work, refactoring the ack header processing.
> This patch also fixes a defect along the way, as there might be multiple ack headers on an inbound message.
> If this patch is accepted then I'll do the same for the ackRequest header, and then move on to the body processing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Updated: (SANDESHA2-20) Refactor ack header processing
Posted by "Matt Lovett (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-20?page=all ]
Matt Lovett updated SANDESHA2-20:
---------------------------------
Attachment: rework3.patch
Let's see if it's third time lucky :)
Cheers, Matt
> Refactor ack header processing
> ------------------------------
>
> Key: SANDESHA2-20
> URL: http://issues.apache.org/jira/browse/SANDESHA2-20
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Priority: Minor
> Attachments: ackPatch.txt, ackPatch.txt, ackRequested.patch, rework.patch, rework2.patch, rework3.patch
>
>
> As I have hinted a few times on list, I think that the message processing through the sandesha handlers could be refactored into header processing (within the handlers), and body processing (in a message receiver). This patch is the start of that work, refactoring the ack header processing.
> This patch also fixes a defect along the way, as there might be multiple ack headers on an inbound message.
> If this patch is accepted then I'll do the same for the ackRequest header, and then move on to the body processing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Commented: (SANDESHA2-20) Refactor ack header processing
Posted by "David Illsley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-20?page=comments#action_12445105 ]
David Illsley commented on SANDESHA2-20:
----------------------------------------
Chamikara, I committed the relevant changes from AXIS2-1457 to Axis2 a couple of days ago.
You should be good to go ahead with this patch.
> Refactor ack header processing
> ------------------------------
>
> Key: SANDESHA2-20
> URL: http://issues.apache.org/jira/browse/SANDESHA2-20
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Priority: Minor
> Attachments: ackPatch.txt, ackPatch.txt, ackRequested.patch, rework.patch, rework2.patch
>
>
> As I have hinted a few times on list, I think that the message processing through the sandesha handlers could be refactored into header processing (within the handlers), and body processing (in a message receiver). This patch is the start of that work, refactoring the ack header processing.
> This patch also fixes a defect along the way, as there might be multiple ack headers on an inbound message.
> If this patch is accepted then I'll do the same for the ackRequest header, and then move on to the body processing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Commented: (SANDESHA2-20) Refactor ack header processing
Posted by "Matt Lovett (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-20?page=comments#action_12445127 ]
Matt Lovett commented on SANDESHA2-20:
--------------------------------------
Unfortunately sandesha has already moved on enough to make the patch fail.... I'll get sync up and attach another one soon.
Matt
> Refactor ack header processing
> ------------------------------
>
> Key: SANDESHA2-20
> URL: http://issues.apache.org/jira/browse/SANDESHA2-20
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Priority: Minor
> Attachments: ackPatch.txt, ackPatch.txt, ackRequested.patch, rework.patch, rework2.patch
>
>
> As I have hinted a few times on list, I think that the message processing through the sandesha handlers could be refactored into header processing (within the handlers), and body processing (in a message receiver). This patch is the start of that work, refactoring the ack header processing.
> This patch also fixes a defect along the way, as there might be multiple ack headers on an inbound message.
> If this patch is accepted then I'll do the same for the ackRequest header, and then move on to the body processing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Commented: (SANDESHA2-20) Refactor ack header processing
Posted by "Chamikara Jayalath (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-20?page=comments#action_12445624 ]
Chamikara Jayalath commented on SANDESHA2-20:
---------------------------------------------
Applied.
Chamikara
> Refactor ack header processing
> ------------------------------
>
> Key: SANDESHA2-20
> URL: http://issues.apache.org/jira/browse/SANDESHA2-20
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Priority: Minor
> Attachments: ackPatch.txt, ackPatch.txt, ackRequested.patch, rework.patch, rework2.patch, rework3.patch
>
>
> As I have hinted a few times on list, I think that the message processing through the sandesha handlers could be refactored into header processing (within the handlers), and body processing (in a message receiver). This patch is the start of that work, refactoring the ack header processing.
> This patch also fixes a defect along the way, as there might be multiple ack headers on an inbound message.
> If this patch is accepted then I'll do the same for the ackRequest header, and then move on to the body processing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Updated: (SANDESHA2-20) Refactor ack header processing
Posted by "Matt Lovett (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-20?page=all ]
Matt Lovett updated SANDESHA2-20:
---------------------------------
Attachment: operation.patch
I missed a couple of places where we construct new operations instead of looking up the ones in module.xml. This patch cleans them up too.
Thanks,
Matt
> Refactor ack header processing
> ------------------------------
>
> Key: SANDESHA2-20
> URL: http://issues.apache.org/jira/browse/SANDESHA2-20
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Priority: Minor
> Attachments: ackPatch.txt, ackPatch.txt, ackRequested.patch, operation.patch, rework.patch, rework2.patch, rework3.patch
>
>
> As I have hinted a few times on list, I think that the message processing through the sandesha handlers could be refactored into header processing (within the handlers), and body processing (in a message receiver). This patch is the start of that work, refactoring the ack header processing.
> This patch also fixes a defect along the way, as there might be multiple ack headers on an inbound message.
> If this patch is accepted then I'll do the same for the ackRequest header, and then move on to the body processing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Updated: (SANDESHA2-20) Refactor ack header processing
Posted by "Matt Lovett (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-20?page=all ]
Matt Lovett updated SANDESHA2-20:
---------------------------------
Attachment: rework3.patch
Let's see if it's third time lucky :)
Cheers, Matt
> Refactor ack header processing
> ------------------------------
>
> Key: SANDESHA2-20
> URL: http://issues.apache.org/jira/browse/SANDESHA2-20
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Priority: Minor
> Attachments: ackPatch.txt, ackPatch.txt, ackRequested.patch, rework.patch, rework2.patch, rework3.patch
>
>
> As I have hinted a few times on list, I think that the message processing through the sandesha handlers could be refactored into header processing (within the handlers), and body processing (in a message receiver). This patch is the start of that work, refactoring the ack header processing.
> This patch also fixes a defect along the way, as there might be multiple ack headers on an inbound message.
> If this patch is accepted then I'll do the same for the ackRequest header, and then move on to the body processing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Updated: (SANDESHA2-20) Refactor ack header processing
Posted by "Matt Lovett (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-20?page=all ]
Matt Lovett updated SANDESHA2-20:
---------------------------------
Attachment: rework.patch
Here's another patch, continuing the header processing theme. With this, inbound Sequence headers get processed in the InHandler (by the new SequenceProcessor class), but the message body is now handled by the message receiver (and application messages will run through to the app message receiver, not the sandesha one). That's goodness as it means we fit in with the axis architecture better, and could also cope with odd situations like a CreateSequence message that was sent reliably.
I also took the opportunity to change module.xml so that the inbound operations will be resolved correctly (by action), and outbound operations are now looked up instead of being created each time. I believe this will ensure that op.isClientSide() will now be telling the truth for all our flows.
This patch depends on the Axis2 jira at http://issues.apache.org/jira/browse/AXIS2-1457
and it won't work before that patch goes in
Thanks,
Matt
> Refactor ack header processing
> ------------------------------
>
> Key: SANDESHA2-20
> URL: http://issues.apache.org/jira/browse/SANDESHA2-20
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Priority: Minor
> Attachments: ackPatch.txt, ackPatch.txt, ackRequested.patch, rework.patch
>
>
> As I have hinted a few times on list, I think that the message processing through the sandesha handlers could be refactored into header processing (within the handlers), and body processing (in a message receiver). This patch is the start of that work, refactoring the ack header processing.
> This patch also fixes a defect along the way, as there might be multiple ack headers on an inbound message.
> If this patch is accepted then I'll do the same for the ackRequest header, and then move on to the body processing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Updated: (SANDESHA2-20) Refactor ack header processing
Posted by "Matt Lovett (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-20?page=all ]
Matt Lovett updated SANDESHA2-20:
---------------------------------
Attachment: ackRequested.patch
Here's a follow-up patch, that refactors the ack requested header in a similar way to the sequence ack.
> Refactor ack header processing
> ------------------------------
>
> Key: SANDESHA2-20
> URL: http://issues.apache.org/jira/browse/SANDESHA2-20
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Priority: Minor
> Attachments: ackPatch.txt, ackPatch.txt, ackRequested.patch
>
>
> As I have hinted a few times on list, I think that the message processing through the sandesha handlers could be refactored into header processing (within the handlers), and body processing (in a message receiver). This patch is the start of that work, refactoring the ack header processing.
> This patch also fixes a defect along the way, as there might be multiple ack headers on an inbound message.
> If this patch is accepted then I'll do the same for the ackRequest header, and then move on to the body processing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Updated: (SANDESHA2-20) Refactor ack header processing
Posted by "Matt Lovett (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-20?page=all ]
Matt Lovett updated SANDESHA2-20:
---------------------------------
Attachment: ackPatch.txt
Re-attaching, as I didn't grant ASF license first time I attached it!
> Refactor ack header processing
> ------------------------------
>
> Key: SANDESHA2-20
> URL: http://issues.apache.org/jira/browse/SANDESHA2-20
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Priority: Minor
> Attachments: ackPatch.txt, ackPatch.txt
>
>
> As I have hinted a few times on list, I think that the message processing through the sandesha handlers could be refactored into header processing (within the handlers), and body processing (in a message receiver). This patch is the start of that work, refactoring the ack header processing.
> This patch also fixes a defect along the way, as there might be multiple ack headers on an inbound message.
> If this patch is accepted then I'll do the same for the ackRequest header, and then move on to the body processing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Commented: (SANDESHA2-20) Refactor ack header processing
Posted by "Chamikara Jayalath (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-20?page=comments#action_12445013 ]
Chamikara Jayalath commented on SANDESHA2-20:
---------------------------------------------
Hi Matt,
This patch seems to be dependent on a patch u submitted to http://issues.apache.org/jira/browse/AXIS2-1457?page=all.
So we cannot commit this until Axis2 is fixed right?
Chamikara
> Refactor ack header processing
> ------------------------------
>
> Key: SANDESHA2-20
> URL: http://issues.apache.org/jira/browse/SANDESHA2-20
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Priority: Minor
> Attachments: ackPatch.txt, ackPatch.txt, ackRequested.patch, rework.patch, rework2.patch
>
>
> As I have hinted a few times on list, I think that the message processing through the sandesha handlers could be refactored into header processing (within the handlers), and body processing (in a message receiver). This patch is the start of that work, refactoring the ack header processing.
> This patch also fixes a defect along the way, as there might be multiple ack headers on an inbound message.
> If this patch is accepted then I'll do the same for the ackRequest header, and then move on to the body processing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Updated: (SANDESHA2-20) Refactor ack header processing
Posted by "Matt Lovett (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-20?page=all ]
Matt Lovett updated SANDESHA2-20:
---------------------------------
Attachment: rework2.patch
Oops - I hadn't resolved some svn conflicts properly in that version of the patch, here's a better one.
Apologies,
Matt
> Refactor ack header processing
> ------------------------------
>
> Key: SANDESHA2-20
> URL: http://issues.apache.org/jira/browse/SANDESHA2-20
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Priority: Minor
> Attachments: ackPatch.txt, ackPatch.txt, ackRequested.patch, rework.patch, rework2.patch
>
>
> As I have hinted a few times on list, I think that the message processing through the sandesha handlers could be refactored into header processing (within the handlers), and body processing (in a message receiver). This patch is the start of that work, refactoring the ack header processing.
> This patch also fixes a defect along the way, as there might be multiple ack headers on an inbound message.
> If this patch is accepted then I'll do the same for the ackRequest header, and then move on to the body processing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Commented: (SANDESHA2-20) Refactor ack header processing
Posted by "Chamikara Jayalath (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-20?page=comments#action_12446147 ]
Chamikara Jayalath commented on SANDESHA2-20:
---------------------------------------------
Applied.
Thanks Matt.
Chamikara
> Refactor ack header processing
> ------------------------------
>
> Key: SANDESHA2-20
> URL: http://issues.apache.org/jira/browse/SANDESHA2-20
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Priority: Minor
> Attachments: ackPatch.txt, ackPatch.txt, ackRequested.patch, operation.patch, rework.patch, rework2.patch, rework3.patch
>
>
> As I have hinted a few times on list, I think that the message processing through the sandesha handlers could be refactored into header processing (within the handlers), and body processing (in a message receiver). This patch is the start of that work, refactoring the ack header processing.
> This patch also fixes a defect along the way, as there might be multiple ack headers on an inbound message.
> If this patch is accepted then I'll do the same for the ackRequest header, and then move on to the body processing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Commented: (SANDESHA2-20) Refactor ack header processing
Posted by "Chamikara Jayalath (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-20?page=comments#action_12446147 ]
Chamikara Jayalath commented on SANDESHA2-20:
---------------------------------------------
Applied.
Thanks Matt.
Chamikara
> Refactor ack header processing
> ------------------------------
>
> Key: SANDESHA2-20
> URL: http://issues.apache.org/jira/browse/SANDESHA2-20
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Priority: Minor
> Attachments: ackPatch.txt, ackPatch.txt, ackRequested.patch, operation.patch, rework.patch, rework2.patch, rework3.patch
>
>
> As I have hinted a few times on list, I think that the message processing through the sandesha handlers could be refactored into header processing (within the handlers), and body processing (in a message receiver). This patch is the start of that work, refactoring the ack header processing.
> This patch also fixes a defect along the way, as there might be multiple ack headers on an inbound message.
> If this patch is accepted then I'll do the same for the ackRequest header, and then move on to the body processing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Commented: (SANDESHA2-20) Refactor ack header processing
Posted by "Chamikara Jayalath (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-20?page=comments#action_12427161 ]
Chamikara Jayalath commented on SANDESHA2-20:
---------------------------------------------
Applied. Thanks.
Chamikara
> Refactor ack header processing
> ------------------------------
>
> Key: SANDESHA2-20
> URL: http://issues.apache.org/jira/browse/SANDESHA2-20
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Priority: Minor
> Attachments: ackPatch.txt, ackPatch.txt
>
>
> As I have hinted a few times on list, I think that the message processing through the sandesha handlers could be refactored into header processing (within the handlers), and body processing (in a message receiver). This patch is the start of that work, refactoring the ack header processing.
> This patch also fixes a defect along the way, as there might be multiple ack headers on an inbound message.
> If this patch is accepted then I'll do the same for the ackRequest header, and then move on to the body processing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Resolved: (SANDESHA2-20) Refactor ack header processing
Posted by "Matt Lovett (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-20?page=all ]
Matt Lovett resolved SANDESHA2-20.
----------------------------------
Resolution: Fixed
> Refactor ack header processing
> ------------------------------
>
> Key: SANDESHA2-20
> URL: http://issues.apache.org/jira/browse/SANDESHA2-20
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Priority: Minor
> Attachments: ackPatch.txt, ackPatch.txt, ackRequested.patch, operation.patch, rework.patch, rework2.patch, rework3.patch
>
>
> As I have hinted a few times on list, I think that the message processing through the sandesha handlers could be refactored into header processing (within the handlers), and body processing (in a message receiver). This patch is the start of that work, refactoring the ack header processing.
> This patch also fixes a defect along the way, as there might be multiple ack headers on an inbound message.
> If this patch is accepted then I'll do the same for the ackRequest header, and then move on to the body processing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Updated: (SANDESHA2-20) Refactor ack header processing
Posted by "Matt Lovett (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-20?page=all ]
Matt Lovett updated SANDESHA2-20:
---------------------------------
Attachment: ackRequested.patch
Here's a follow-up patch, that refactors the ack requested header in a similar way to the sequence ack.
> Refactor ack header processing
> ------------------------------
>
> Key: SANDESHA2-20
> URL: http://issues.apache.org/jira/browse/SANDESHA2-20
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Priority: Minor
> Attachments: ackPatch.txt, ackPatch.txt, ackRequested.patch
>
>
> As I have hinted a few times on list, I think that the message processing through the sandesha handlers could be refactored into header processing (within the handlers), and body processing (in a message receiver). This patch is the start of that work, refactoring the ack header processing.
> This patch also fixes a defect along the way, as there might be multiple ack headers on an inbound message.
> If this patch is accepted then I'll do the same for the ackRequest header, and then move on to the body processing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
[jira] Commented: (SANDESHA2-20) Refactor ack header processing
Posted by "Chamikara Jayalath (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SANDESHA2-20?page=comments#action_12445624 ]
Chamikara Jayalath commented on SANDESHA2-20:
---------------------------------------------
Applied.
Chamikara
> Refactor ack header processing
> ------------------------------
>
> Key: SANDESHA2-20
> URL: http://issues.apache.org/jira/browse/SANDESHA2-20
> Project: Apache Sandesha2
> Issue Type: Improvement
> Reporter: Matt Lovett
> Priority: Minor
> Attachments: ackPatch.txt, ackPatch.txt, ackRequested.patch, rework.patch, rework2.patch, rework3.patch
>
>
> As I have hinted a few times on list, I think that the message processing through the sandesha handlers could be refactored into header processing (within the handlers), and body processing (in a message receiver). This patch is the start of that work, refactoring the ack header processing.
> This patch also fixes a defect along the way, as there might be multiple ack headers on an inbound message.
> If this patch is accepted then I'll do the same for the ackRequest header, and then move on to the body processing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org