You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Zsombor Gegesy <gz...@gmail.com> on 2017/06/15 22:23:55 UTC
Review Request 60134: RANGER-1646 : providing more useful error
messages in SSL configuration problems
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60134/
-----------------------------------------------------------
Review request for ranger.
Bugs: RANGER-1646
https://issues.apache.org/jira/browse/RANGER-1646
Repository: ranger
Description
-------
Instead of shallowing the exceptions - and returning nulls, which later results in a 'SSLContext must not be null' error, it would be better, if the process would fail early, and provide detailed error message in the exceptions, so the user could solve it.
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java 784023b
Diff: https://reviews.apache.org/r/60134/diff/1/
Testing
-------
Thanks,
Zsombor Gegesy
Re: Review Request 60134: RANGER-1646 : providing more useful error
messages in SSL configuration problems
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60134/#review178362
-----------------------------------------------------------
Ship it!
Ship It!
- Colm O hEigeartaigh
On June 19, 2017, 12:15 p.m., Zsombor Gegesy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60134/
> -----------------------------------------------------------
>
> (Updated June 19, 2017, 12:15 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-1646
> https://issues.apache.org/jira/browse/RANGER-1646
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Instead of shallowing the exceptions - and returning nulls, which later results in a 'SSLContext must not be null' error, it would be better, if the process would fail early, and provide detailed error message in the exceptions, so the user could solve it.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java 784023b
>
>
> Diff: https://reviews.apache.org/r/60134/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zsombor Gegesy
>
>
Re: Review Request 60134: RANGER-1646 : providing more useful error
messages in SSL configuration problems
Posted by Zsombor Gegesy <gz...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60134/
-----------------------------------------------------------
(Updated June 19, 2017, 12:15 p.m.)
Review request for ranger.
Changes
-------
Whitespace changes
Bugs: RANGER-1646
https://issues.apache.org/jira/browse/RANGER-1646
Repository: ranger
Description
-------
Instead of shallowing the exceptions - and returning nulls, which later results in a 'SSLContext must not be null' error, it would be better, if the process would fail early, and provide detailed error message in the exceptions, so the user could solve it.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java 784023b
Diff: https://reviews.apache.org/r/60134/diff/3/
Changes: https://reviews.apache.org/r/60134/diff/2-3/
Testing
-------
Thanks,
Zsombor Gegesy
Re: Review Request 60134: RANGER-1646 : providing more useful error
messages in SSL configuration problems
Posted by Zsombor Gegesy <gz...@gmail.com>.
> On June 19, 2017, 9:28 a.m., Colm O hEigeartaigh wrote:
> > Another trivial change - there are several instances of "+" where it is not surrounded either side by a space, e.g. mKeyStoreFile+"
Hopefully I've found & fixed all
- Zsombor
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60134/#review178208
-----------------------------------------------------------
On June 19, 2017, 12:15 p.m., Zsombor Gegesy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60134/
> -----------------------------------------------------------
>
> (Updated June 19, 2017, 12:15 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-1646
> https://issues.apache.org/jira/browse/RANGER-1646
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Instead of shallowing the exceptions - and returning nulls, which later results in a 'SSLContext must not be null' error, it would be better, if the process would fail early, and provide detailed error message in the exceptions, so the user could solve it.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java 784023b
>
>
> Diff: https://reviews.apache.org/r/60134/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zsombor Gegesy
>
>
Re: Review Request 60134: RANGER-1646 : providing more useful error
messages in SSL configuration problems
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60134/#review178208
-----------------------------------------------------------
Another trivial change - there are several instances of "+" where it is not surrounded either side by a space, e.g. mKeyStoreFile+"
- Colm O hEigeartaigh
On June 16, 2017, 11:48 a.m., Zsombor Gegesy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60134/
> -----------------------------------------------------------
>
> (Updated June 16, 2017, 11:48 a.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-1646
> https://issues.apache.org/jira/browse/RANGER-1646
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Instead of shallowing the exceptions - and returning nulls, which later results in a 'SSLContext must not be null' error, it would be better, if the process would fail early, and provide detailed error message in the exceptions, so the user could solve it.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java 784023b
>
>
> Diff: https://reviews.apache.org/r/60134/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zsombor Gegesy
>
>
Re: Review Request 60134: RANGER-1646 : providing more useful error
messages in SSL configuration problems
Posted by Zsombor Gegesy <gz...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60134/
-----------------------------------------------------------
(Updated June 16, 2017, 11:48 a.m.)
Review request for ranger.
Changes
-------
Fix grammar
Bugs: RANGER-1646
https://issues.apache.org/jira/browse/RANGER-1646
Repository: ranger
Description
-------
Instead of shallowing the exceptions - and returning nulls, which later results in a 'SSLContext must not be null' error, it would be better, if the process would fail early, and provide detailed error message in the exceptions, so the user could solve it.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java 784023b
Diff: https://reviews.apache.org/r/60134/diff/2/
Changes: https://reviews.apache.org/r/60134/diff/1-2/
Testing
-------
Thanks,
Zsombor Gegesy
Re: Review Request 60134: RANGER-1646 : providing more useful error
messages in SSL configuration problems
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60134/#review178097
-----------------------------------------------------------
Looks fine. You have "Unable find" twice in the code...should be "Unable to find"
- Colm O hEigeartaigh
On June 15, 2017, 10:23 p.m., Zsombor Gegesy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60134/
> -----------------------------------------------------------
>
> (Updated June 15, 2017, 10:23 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-1646
> https://issues.apache.org/jira/browse/RANGER-1646
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Instead of shallowing the exceptions - and returning nulls, which later results in a 'SSLContext must not be null' error, it would be better, if the process would fail early, and provide detailed error message in the exceptions, so the user could solve it.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java 784023b
>
>
> Diff: https://reviews.apache.org/r/60134/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zsombor Gegesy
>
>