You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@usergrid.apache.org by eburi <gi...@git.apache.org> on 2014/11/19 18:00:49 UTC

[GitHub] incubator-usergrid pull request: changed calcTimeDiff to actually ...

GitHub user eburi opened a pull request:

    https://github.com/apache/incubator-usergrid/pull/101

    changed calcTimeDiff to actually return seconds

    Hi,
    
    calcTimeDiff does not return seconds as it claims in logging. Fixed it.
    
    BR
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/eburi/incubator-usergrid sdk/nodejs/calc-time-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-usergrid/pull/101.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #101
    
----
commit aca5822c602d72cd1f2adf27ecfdaec6fd45c1c6
Author: Erich Buri <er...@gmail.com>
Date:   2014-11-19T16:58:22Z

    changed calcTimeDiff to actually return seconds

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-usergrid pull request: changed calcTimeDiff to actually ...

Posted by eburi <gi...@git.apache.org>.
Github user eburi commented on the pull request:

    https://github.com/apache/incubator-usergrid/pull/101#issuecomment-63677603
  
    @rodsimpson nope. I'll try to get one...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-usergrid pull request: changed calcTimeDiff to actually ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-usergrid/pull/101


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-usergrid pull request: changed calcTimeDiff to actually ...

Posted by rodsimpson <gi...@git.apache.org>.
Github user rodsimpson commented on the pull request:

    https://github.com/apache/incubator-usergrid/pull/101#issuecomment-63694470
  
    @eburi it's pretty straightforward.  Just fill out this form and fax/email to Apache:
    
    http://www.apache.org/licenses/icla.txt


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] incubator-usergrid pull request: changed calcTimeDiff to actually ...

Posted by Rod Simpson <ro...@rodsimpson.com>.
Awesome.  I will ack your PR soon.

Rod


-- 
Rod Simpson
@rockerston
rodsimpson.com

On November 25, 2014 at 10:22:32 AM, eburi (git@git.apache.org) wrote:

Github user eburi commented on the pull request:  

https://github.com/apache/incubator-usergrid/pull/101#issuecomment-64436895  

Hi,  

my ICLA has been filed.  

BR  
Erich  


---  
If your project is set up for it, you can reply to this email and have your  
reply appear on GitHub as well. If your project does not have this feature  
enabled and wishes so, or if the feature is enabled but not working, please  
contact infrastructure at infrastructure@apache.org or file a JIRA ticket  
with INFRA.  
---

[GitHub] incubator-usergrid pull request: changed calcTimeDiff to actually ...

Posted by eburi <gi...@git.apache.org>.
Github user eburi commented on the pull request:

    https://github.com/apache/incubator-usergrid/pull/101#issuecomment-64436895
  
    Hi,
    
    my ICLA has been filed.
    
    BR
    Erich


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-usergrid pull request: changed calcTimeDiff to actually ...

Posted by rodsimpson <gi...@git.apache.org>.
Github user rodsimpson commented on the pull request:

    https://github.com/apache/incubator-usergrid/pull/101#issuecomment-63676905
  
    @eburi Thank you for the PR - do you have an ICLA on file with Apache?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---