You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/05/24 06:37:30 UTC
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #3755: net/icmp: icmp bug fix and enhancement
yamt commented on a change in pull request #3755:
URL: https://github.com/apache/incubator-nuttx/pull/3755#discussion_r637719224
##########
File path: net/icmp/icmp_recvmsg.c
##########
@@ -162,7 +162,7 @@ static uint16_t recvfrom_eventhandler(FAR struct net_driver_s *dev,
/* Return the size of the returned data */
- DEBUGASSERT(recvsize > INT16_MAX);
+ DEBUGASSERT(recvsize < INT16_MAX);
Review comment:
maybe "<=" ?
##########
File path: net/icmpv6/icmpv6_recvmsg.c
##########
@@ -169,7 +169,7 @@ static uint16_t recvfrom_eventhandler(FAR struct net_driver_s *dev,
/* Return the size of the returned data */
- DEBUGASSERT(recvsize > INT16_MAX);
+ DEBUGASSERT(recvsize < INT16_MAX);
Review comment:
<= ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org