[GitHub] [incubator-doris] adonis0147 commented on a diff in pull request #9505: [Refactor] Use file factory to replace create file reader/writer

[GitBox <gi...@apache.org>]

adonis0147 commented on code in PR #9505:
URL: https://github.com/apache/incubator-doris/pull/9505#discussion_r870321488


##########
be/src/exec/broker_scanner.h:
##########
@@ -110,7 +110,7 @@ class BrokerScanner : public BaseScanner {
     int _line_delimiter_length;
 
     // Reader
-    FileReader* _cur_file_reader;
+    std::shared_ptr<FileReader> _cur_file_reader;

Review Comment:
   Why `std::shared_ptr`? Is the ownership of `_cur_file_reader` sharable? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org