You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2022/07/12 13:19:38 UTC
[GitHub] [activemq-artemis] jsmucr opened a new pull request, #4144: ARTEMIS-3767 Fix replication incompatibility between pre 2.18.0 and SNAPSHOT (WIP)
jsmucr opened a new pull request, #4144:
URL: https://github.com/apache/activemq-artemis/pull/4144
This PR attempts to solve the issue described in https://issues.apache.org/jira/browse/ARTEMIS-3767.
TL;DR replication between 2.17.0 and newer Artemis versions is broken since 2.18.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jsmucr commented on pull request #4144: ARTEMIS-3767 Fix replication incompatibility between pre 2.18.0 and SNAPSHOT (WIP)
Posted by GitBox <gi...@apache.org>.
jsmucr commented on PR #4144:
URL: https://github.com/apache/activemq-artemis/pull/4144#issuecomment-1184389148
I've got a problem with this. Changes in #3680 should have introduced a new version of the `REPLICATION_START_FINISH_SYNC` packet as there's suddenly more data in it. This tainted the Artemis releases up to the current snapshot and I don't know how to overcome this unless there's a bugfix release for all recent versions starting with 2.18.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #4144: ARTEMIS-3767 Fix replication incompatibility between pre 2.18.0 and SNAPSHOT (WIP)
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on PR #4144:
URL: https://github.com/apache/activemq-artemis/pull/4144#issuecomment-1185566390
I don't think you need the Server compatibility Test.
Please take a look at MultiVersionReplicatest under compatibility-tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jsmucr commented on pull request #4144: ARTEMIS-3767 Fix replication incompatibility between pre 2.18.0 and SNAPSHOT (WIP)
Posted by GitBox <gi...@apache.org>.
jsmucr commented on PR #4144:
URL: https://github.com/apache/activemq-artemis/pull/4144#issuecomment-1185666687
I didn't notice this test before. Maybe it wasn't on the 2.18.0 I was starting with, and after many failures when trying to make it work with the compatibility-tests base, I created my own (more Groovy-ish way, without shared bindings and the `GroovyRun` helper class). Well, nevermind. I'll throw it away then.
The test does not work with 2.17.0 now as it appears to assume the existence of some newer methods on older implementations, but that's easy to fix, I suppose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on pull request #4144: ARTEMIS-3767 Fix replication incompatibility between pre 2.18.0 and SNAPSHOT (WIP)
Posted by GitBox <gi...@apache.org>.
gemmellr commented on PR #4144:
URL: https://github.com/apache/activemq-artemis/pull/4144#issuecomment-1185669735
Also being discussed on https://lists.apache.org/thread/bf8t8gkzg374351d2rjd6pkzr13olclb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #4144: ARTEMIS-3767 Fix replication incompatibility between pre 2.18.0 and SNAPSHOT (WIP)
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on PR #4144:
URL: https://github.com/apache/activemq-artemis/pull/4144#issuecomment-1185867995
lets move the discussion to my new PR?
this PR is being replaced by https://github.com/apache/activemq-artemis/pull/4150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic closed pull request #4144: ARTEMIS-3767 Fix replication incompatibility between pre 2.18.0 and SNAPSHOT (WIP)
Posted by GitBox <gi...@apache.org>.
clebertsuconic closed pull request #4144: ARTEMIS-3767 Fix replication incompatibility between pre 2.18.0 and SNAPSHOT (WIP)
URL: https://github.com/apache/activemq-artemis/pull/4144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org