You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Jens Riemschneider (JIRA)" <ji...@apache.org> on 2009/08/26 15:11:50 UTC
[jira] Created: (CAMEL-1942) Allow access to IoSession via message
Allow access to IoSession via message
-------------------------------------
Key: CAMEL-1942
URL: https://issues.apache.org/activemq/browse/CAMEL-1942
Project: Apache Camel
Issue Type: Improvement
Components: camel-mina
Affects Versions: 2.0.0
Reporter: Jens Riemschneider
In 1.x it was possible to get access to the IoSession via the MinaExchange.
In 2.0, MinaExchange is no more and therefore access to the IoSession is impossible.
Add a MinaMessage that has an accessor to the IoSession set by the MinaConsumer.
Mailing List: http://www.nabble.com/IoSession-data-in-Exchange-created-by-MinaConsumer-td25150794.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-1942) Allow access to IoSession via message
Posted by "Jens Riemschneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jens Riemschneider updated CAMEL-1942:
--------------------------------------
Attachment: mina.patch
> Allow access to IoSession via message
> -------------------------------------
>
> Key: CAMEL-1942
> URL: https://issues.apache.org/activemq/browse/CAMEL-1942
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-mina
> Affects Versions: 2.0.0
> Reporter: Jens Riemschneider
> Assignee: Willem Jiang
> Attachments: mina.patch
>
>
> In 1.x it was possible to get access to the IoSession via the MinaExchange.
> In 2.0, MinaExchange is no more and therefore access to the IoSession is impossible.
> Add a MinaMessage that has an accessor to the IoSession set by the MinaConsumer.
> Mailing List: http://www.nabble.com/IoSession-data-in-Exchange-created-by-MinaConsumer-td25150794.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CAMEL-1942) Allow access to IoSession via message
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Willem Jiang reassigned CAMEL-1942:
-----------------------------------
Assignee: Willem Jiang
> Allow access to IoSession via message
> -------------------------------------
>
> Key: CAMEL-1942
> URL: https://issues.apache.org/activemq/browse/CAMEL-1942
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-mina
> Affects Versions: 2.0.0
> Reporter: Jens Riemschneider
> Assignee: Willem Jiang
> Attachments: mina.patch
>
>
> In 1.x it was possible to get access to the IoSession via the MinaExchange.
> In 2.0, MinaExchange is no more and therefore access to the IoSession is impossible.
> Add a MinaMessage that has an accessor to the IoSession set by the MinaConsumer.
> Mailing List: http://www.nabble.com/IoSession-data-in-Exchange-created-by-MinaConsumer-td25150794.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1942) Allow access to IoSession via
message
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=53831#action_53831 ]
Claus Ibsen commented on CAMEL-1942:
------------------------------------
Jens patch looks much better, however please use the method {{populateInitialHeaders}} to setup the headers instead of creating your own method for that.
Then its aligned what we do in Camel.
> Allow access to IoSession via message
> -------------------------------------
>
> Key: CAMEL-1942
> URL: https://issues.apache.org/activemq/browse/CAMEL-1942
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-mina
> Affects Versions: 2.0.0
> Reporter: Jens Riemschneider
> Assignee: Willem Jiang
> Attachments: mina.patch
>
>
> In 1.x it was possible to get access to the IoSession via the MinaExchange.
> In 2.0, MinaExchange is no more and therefore access to the IoSession is impossible.
> Add a MinaMessage that has an accessor to the IoSession set by the MinaConsumer.
> Mailing List: http://www.nabble.com/IoSession-data-in-Exchange-created-by-MinaConsumer-td25150794.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1942) Allow access to IoSession via
message
Posted by "Jens Riemschneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=53821#action_53821 ]
Jens Riemschneider commented on CAMEL-1942:
-------------------------------------------
I'm sorry, the patch got mixed up with earlier changes I did. Claus suggested offering the IoSession via a MinaMessage and that was the actual way I implemented it. Plus, I forgot to add the new files. I upload the patch again.
I noticed that you put most (all?) header keys into Exchange. Should this be done with those from the MinaMessage as well?
> Allow access to IoSession via message
> -------------------------------------
>
> Key: CAMEL-1942
> URL: https://issues.apache.org/activemq/browse/CAMEL-1942
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-mina
> Affects Versions: 2.0.0
> Reporter: Jens Riemschneider
> Assignee: Willem Jiang
>
> In 1.x it was possible to get access to the IoSession via the MinaExchange.
> In 2.0, MinaExchange is no more and therefore access to the IoSession is impossible.
> Add a MinaMessage that has an accessor to the IoSession set by the MinaConsumer.
> Mailing List: http://www.nabble.com/IoSession-data-in-Exchange-created-by-MinaConsumer-td25150794.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1942) Allow access to IoSession via
message
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=53832#action_53832 ]
Claus Ibsen commented on CAMEL-1942:
------------------------------------
Jens we push commonly used or shared header keys in Exchange itself.
Camel mina does not fall into that category so its fine to have them on MinaMessage.
> Allow access to IoSession via message
> -------------------------------------
>
> Key: CAMEL-1942
> URL: https://issues.apache.org/activemq/browse/CAMEL-1942
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-mina
> Affects Versions: 2.0.0
> Reporter: Jens Riemschneider
> Assignee: Willem Jiang
> Attachments: mina.patch
>
>
> In 1.x it was possible to get access to the IoSession via the MinaExchange.
> In 2.0, MinaExchange is no more and therefore access to the IoSession is impossible.
> Add a MinaMessage that has an accessor to the IoSession set by the MinaConsumer.
> Mailing List: http://www.nabble.com/IoSession-data-in-Exchange-created-by-MinaConsumer-td25150794.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1942) Allow access to IoSession via
message
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=53874#action_53874 ]
Claus Ibsen commented on CAMEL-1942:
------------------------------------
Yeah I might be overkill with only one session to be stored in a specialized MinaMessage.
You could use {{newInstance}} or what it was to ensure a MinaMessage is constructed so you can preserve the IoSession while being routed.
See the file component.
Anyway storing it as a header is great as well.
Remember to document this on the mina wiki page.
And storing the local and remote address in separate headers is also a good idea for CBR routing using headers. I wonder if it has a nice toString if its stored as InetAddress object. We want to be able to use regexp or equal etc. for nice CBR routing. If not we could consider adding a type converter in camel-mina for InetAddress or maybe even better in camel-core for reuse elsewhere.
> Allow access to IoSession via message
> -------------------------------------
>
> Key: CAMEL-1942
> URL: https://issues.apache.org/activemq/browse/CAMEL-1942
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-mina
> Affects Versions: 2.0.0
> Reporter: Jеns Riеmschneidеɾ
> Assignee: Willem Jiang
> Fix For: 2.1.0
>
> Attachments: mina.patch
>
>
> In 1.x it was possible to get access to the IoSession via the MinaExchange.
> In 2.0, MinaExchange is no more and therefore access to the IoSession is impossible.
> Add a MinaMessage that has an accessor to the IoSession set by the MinaConsumer.
> Mailing List: http://www.nabble.com/IoSession-data-in-Exchange-created-by-MinaConsumer-td25150794.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1942) Allow access to IoSession via
message
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=53893#action_53893 ]
Claus Ibsen commented on CAMEL-1942:
------------------------------------
Yeah good point about the async.
Would be smarter to take a copy of the local/remote address, then you got that throughout the entire routing. And where it could make sense the do CBR based on which client called.
And we can keep the IoSession there for people needing it in some special cases.
> Allow access to IoSession via message
> -------------------------------------
>
> Key: CAMEL-1942
> URL: https://issues.apache.org/activemq/browse/CAMEL-1942
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-mina
> Affects Versions: 2.0.0
> Reporter: Jеns Riеmschneidеɾ
> Assignee: Willem Jiang
> Fix For: 2.1.0
>
> Attachments: mina.patch
>
>
> In 1.x it was possible to get access to the IoSession via the MinaExchange.
> In 2.0, MinaExchange is no more and therefore access to the IoSession is impossible.
> Add a MinaMessage that has an accessor to the IoSession set by the MinaConsumer.
> Mailing List: http://www.nabble.com/IoSession-data-in-Exchange-created-by-MinaConsumer-td25150794.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1942) Allow access to IoSession via
message
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=53817#action_53817 ]
Claus Ibsen commented on CAMEL-1942:
------------------------------------
And we need an unit test as well, so please create an unit test to test this new feature.
> Allow access to IoSession via message
> -------------------------------------
>
> Key: CAMEL-1942
> URL: https://issues.apache.org/activemq/browse/CAMEL-1942
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-mina
> Affects Versions: 2.0.0
> Reporter: Jens Riemschneider
> Assignee: Willem Jiang
> Attachments: mina.patch
>
>
> In 1.x it was possible to get access to the IoSession via the MinaExchange.
> In 2.0, MinaExchange is no more and therefore access to the IoSession is impossible.
> Add a MinaMessage that has an accessor to the IoSession set by the MinaConsumer.
> Mailing List: http://www.nabble.com/IoSession-data-in-Exchange-created-by-MinaConsumer-td25150794.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1942) Allow access to IoSession via
message
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=53883#action_53883 ]
Claus Ibsen commented on CAMEL-1942:
------------------------------------
Willem the binary operators should support type coercing so if you compare the LOCAL_ADDRESS with a java.lang.String then Camel will covert it to String as well.
And I do think the regexp will convert to String before matching as it uses String by nature. So it should work out of the box with the simple language.
But as always its best to ask the computer and add an unit test to ensure it works :)
> Allow access to IoSession via message
> -------------------------------------
>
> Key: CAMEL-1942
> URL: https://issues.apache.org/activemq/browse/CAMEL-1942
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-mina
> Affects Versions: 2.0.0
> Reporter: Jеns Riеmschneidеɾ
> Assignee: Willem Jiang
> Fix For: 2.1.0
>
> Attachments: mina.patch
>
>
> In 1.x it was possible to get access to the IoSession via the MinaExchange.
> In 2.0, MinaExchange is no more and therefore access to the IoSession is impossible.
> Add a MinaMessage that has an accessor to the IoSession set by the MinaConsumer.
> Mailing List: http://www.nabble.com/IoSession-data-in-Exchange-created-by-MinaConsumer-td25150794.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1942) Allow access to IoSession via
message
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=53811#action_53811 ]
Willem Jiang commented on CAMEL-1942:
-------------------------------------
Hi Jens,
I think you missed the MinaMessage in your patch.
If you use svn diff to create the patch , you need to use "svn add ../MinaMessage.java" first.
Can you submit the patch again ?
Thanks,
Willem
> Allow access to IoSession via message
> -------------------------------------
>
> Key: CAMEL-1942
> URL: https://issues.apache.org/activemq/browse/CAMEL-1942
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-mina
> Affects Versions: 2.0.0
> Reporter: Jens Riemschneider
> Assignee: Willem Jiang
> Attachments: mina.patch
>
>
> In 1.x it was possible to get access to the IoSession via the MinaExchange.
> In 2.0, MinaExchange is no more and therefore access to the IoSession is impossible.
> Add a MinaMessage that has an accessor to the IoSession set by the MinaConsumer.
> Mailing List: http://www.nabble.com/IoSession-data-in-Exchange-created-by-MinaConsumer-td25150794.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CAMEL-1942) Allow access to IoSession
via message
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=53811#action_53811 ]
Willem Jiang edited comment on CAMEL-1942 at 8/26/09 7:10 PM:
--------------------------------------------------------------
Hi Jens,
I think you missed the MinaMessage.java in your patch.
If you use svn diff to create the patch , you need to use "svn add ../MinaMessage.java" first.
Can you submit the patch again ?
Thanks,
Willem
was (Author: njiang):
Hi Jens,
I think you missed the MinaMessage in your patch.
If you use svn diff to create the patch , you need to use "svn add ../MinaMessage.java" first.
Can you submit the patch again ?
Thanks,
Willem
> Allow access to IoSession via message
> -------------------------------------
>
> Key: CAMEL-1942
> URL: https://issues.apache.org/activemq/browse/CAMEL-1942
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-mina
> Affects Versions: 2.0.0
> Reporter: Jens Riemschneider
> Assignee: Willem Jiang
> Attachments: mina.patch
>
>
> In 1.x it was possible to get access to the IoSession via the MinaExchange.
> In 2.0, MinaExchange is no more and therefore access to the IoSession is impossible.
> Add a MinaMessage that has an accessor to the IoSession set by the MinaConsumer.
> Mailing List: http://www.nabble.com/IoSession-data-in-Exchange-created-by-MinaConsumer-td25150794.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1942) Allow access to IoSession via
message
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=53882#action_53882 ]
Willem Jiang commented on CAMEL-1942:
-------------------------------------
Updated the document.
I also did a quick test on the message header. As we support to use the converter when get the message header, message.getHeader(MinaEndpoint.HEADER_LOCAL_ADDRESS, String.class) will did the trick for CBR, and we may need to add a simple language for getting the message header with specified Type.
> Allow access to IoSession via message
> -------------------------------------
>
> Key: CAMEL-1942
> URL: https://issues.apache.org/activemq/browse/CAMEL-1942
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-mina
> Affects Versions: 2.0.0
> Reporter: Jеns Riеmschneidеɾ
> Assignee: Willem Jiang
> Fix For: 2.1.0
>
> Attachments: mina.patch
>
>
> In 1.x it was possible to get access to the IoSession via the MinaExchange.
> In 2.0, MinaExchange is no more and therefore access to the IoSession is impossible.
> Add a MinaMessage that has an accessor to the IoSession set by the MinaConsumer.
> Mailing List: http://www.nabble.com/IoSession-data-in-Exchange-created-by-MinaConsumer-td25150794.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1942) Allow access to IoSession via
message
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=53870#action_53870 ]
Willem Jiang commented on CAMEL-1942:
-------------------------------------
After digging a pipeline issue this week, I realized that you can't get the MinaMessage if your processor is far from the MinaConsumer. You can change the route rule of the MinaMessageTest.java to reproduce the error.
{code}
@Override
protected RouteBuilder createRouteBuilder() throws Exception {
return new RouteBuilder() {
@Override
public void configure() throws Exception {
from("mina:tcp://localhost:6200?textline=true&sync=false")
.to("log://mytest")
.to("mock:result");
}
};
}
{code}
So I changed the code to put the IOSession into the DefaultMessage header , then the pipeline will pass it to the next processor.
> Allow access to IoSession via message
> -------------------------------------
>
> Key: CAMEL-1942
> URL: https://issues.apache.org/activemq/browse/CAMEL-1942
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-mina
> Affects Versions: 2.0.0
> Reporter: Jеns Riеmschneidеɾ
> Assignee: Willem Jiang
> Attachments: mina.patch
>
>
> In 1.x it was possible to get access to the IoSession via the MinaExchange.
> In 2.0, MinaExchange is no more and therefore access to the IoSession is impossible.
> Add a MinaMessage that has an accessor to the IoSession set by the MinaConsumer.
> Mailing List: http://www.nabble.com/IoSession-data-in-Exchange-created-by-MinaConsumer-td25150794.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-1942) Allow access to IoSession via message
Posted by "Jens Riemschneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jens Riemschneider updated CAMEL-1942:
--------------------------------------
Attachment: (was: mina.patch)
> Allow access to IoSession via message
> -------------------------------------
>
> Key: CAMEL-1942
> URL: https://issues.apache.org/activemq/browse/CAMEL-1942
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-mina
> Affects Versions: 2.0.0
> Reporter: Jens Riemschneider
> Assignee: Willem Jiang
>
> In 1.x it was possible to get access to the IoSession via the MinaExchange.
> In 2.0, MinaExchange is no more and therefore access to the IoSession is impossible.
> Add a MinaMessage that has an accessor to the IoSession set by the MinaConsumer.
> Mailing List: http://www.nabble.com/IoSession-data-in-Exchange-created-by-MinaConsumer-td25150794.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CAMEL-1942) Allow access to IoSession via message
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Willem Jiang resolved CAMEL-1942.
---------------------------------
Resolution: Fixed
Fix Version/s: 2.1.0
http://svn.apache.org/viewvc?rev=809095&view=rev
> Allow access to IoSession via message
> -------------------------------------
>
> Key: CAMEL-1942
> URL: https://issues.apache.org/activemq/browse/CAMEL-1942
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-mina
> Affects Versions: 2.0.0
> Reporter: Jеns Riеmschneidеɾ
> Assignee: Willem Jiang
> Fix For: 2.1.0
>
> Attachments: mina.patch
>
>
> In 1.x it was possible to get access to the IoSession via the MinaExchange.
> In 2.0, MinaExchange is no more and therefore access to the IoSession is impossible.
> Add a MinaMessage that has an accessor to the IoSession set by the MinaConsumer.
> Mailing List: http://www.nabble.com/IoSession-data-in-Exchange-created-by-MinaConsumer-td25150794.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1942) Allow access to IoSession via
message
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=53816#action_53816 ]
Claus Ibsen commented on CAMEL-1942:
------------------------------------
And in mina consumer it should set these 2 properties as headers, and not properties on the exchange.
They are protocol specific for mina and thus belongs on the MinaMessage.
> Allow access to IoSession via message
> -------------------------------------
>
> Key: CAMEL-1942
> URL: https://issues.apache.org/activemq/browse/CAMEL-1942
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-mina
> Affects Versions: 2.0.0
> Reporter: Jens Riemschneider
> Assignee: Willem Jiang
> Attachments: mina.patch
>
>
> In 1.x it was possible to get access to the IoSession via the MinaExchange.
> In 2.0, MinaExchange is no more and therefore access to the IoSession is impossible.
> Add a MinaMessage that has an accessor to the IoSession set by the MinaConsumer.
> Mailing List: http://www.nabble.com/IoSession-data-in-Exchange-created-by-MinaConsumer-td25150794.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1942) Allow access to IoSession via
message
Posted by "Jеns Riеmschneidеɾ (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=53888#action_53888 ]
Jеns Riеmschneidеɾ commented on CAMEL-1942:
-------------------------------------------
The toString() methods of the SocketAddress implementations should return something useful. Usually something of the form "host:port" or "ip-address:port". So that should be fine.
I don't know about others, but for us the IoSession itself wasn't the important thing. We only need the addresses. You can do a lot of things with the IoSession that are probably not very useful. Also, the IoSession might have been closed at the time the header is retrieved, e.g. in asynchronous routing. So maybe it would be better to simply offer some of the data that the IoSession offers and not the IoSession itself.
> Allow access to IoSession via message
> -------------------------------------
>
> Key: CAMEL-1942
> URL: https://issues.apache.org/activemq/browse/CAMEL-1942
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-mina
> Affects Versions: 2.0.0
> Reporter: Jеns Riеmschneidеɾ
> Assignee: Willem Jiang
> Fix For: 2.1.0
>
> Attachments: mina.patch
>
>
> In 1.x it was possible to get access to the IoSession via the MinaExchange.
> In 2.0, MinaExchange is no more and therefore access to the IoSession is impossible.
> Add a MinaMessage that has an accessor to the IoSession set by the MinaConsumer.
> Mailing List: http://www.nabble.com/IoSession-data-in-Exchange-created-by-MinaConsumer-td25150794.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-1942) Allow access to IoSession via message
Posted by "Jens Riemschneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jens Riemschneider updated CAMEL-1942:
--------------------------------------
Attachment: mina.patch
> Allow access to IoSession via message
> -------------------------------------
>
> Key: CAMEL-1942
> URL: https://issues.apache.org/activemq/browse/CAMEL-1942
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-mina
> Affects Versions: 2.0.0
> Reporter: Jens Riemschneider
> Attachments: mina.patch
>
>
> In 1.x it was possible to get access to the IoSession via the MinaExchange.
> In 2.0, MinaExchange is no more and therefore access to the IoSession is impossible.
> Add a MinaMessage that has an accessor to the IoSession set by the MinaConsumer.
> Mailing List: http://www.nabble.com/IoSession-data-in-Exchange-created-by-MinaConsumer-td25150794.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.