You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Michael Brohl (Created) (JIRA)" <ji...@apache.org> on 2012/03/21 16:13:40 UTC
[jira] [Created] (OFBIZ-4744) ProductStoreCartAwareEvents: wrong
check for website in setSessionProductStore
ProductStoreCartAwareEvents: wrong check for website in setSessionProductStore
------------------------------------------------------------------------------
Key: OFBIZ-4744
URL: https://issues.apache.org/jira/browse/OFBIZ-4744
Project: OFBiz
Issue Type: Bug
Components: order, specialpurpose/ecommerce
Affects Versions: SVN trunk
Reporter: Michael Brohl
Fix For: SVN trunk
There's a duplicate check if the productStore is null instead of checking productStore and website in ProductStoreCartAwareEvents.setSessionProductStore.
I will provide a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4744) ProductStoreCartAwareEvents: wrong
check for website in setSessionProductStore
Posted by "Michael Brohl (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Brohl updated OFBIZ-4744:
---------------------------------
Attachment: OFBIZ-4744_ProductStoreCartAwareEvents_wrong_check_for_website.patch
The patch.
> ProductStoreCartAwareEvents: wrong check for website in setSessionProductStore
> ------------------------------------------------------------------------------
>
> Key: OFBIZ-4744
> URL: https://issues.apache.org/jira/browse/OFBIZ-4744
> Project: OFBiz
> Issue Type: Bug
> Components: order, specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Reporter: Michael Brohl
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4744_ProductStoreCartAwareEvents_wrong_check_for_website.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> There's a duplicate check if the productStore is null instead of checking productStore and website in ProductStoreCartAwareEvents.setSessionProductStore.
> I will provide a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (OFBIZ-4744) ProductStoreCartAwareEvents: wrong
check for website in setSessionProductStore
Posted by "Sascha Rodekamp (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sascha Rodekamp reassigned OFBIZ-4744:
--------------------------------------
Assignee: Sascha Rodekamp
> ProductStoreCartAwareEvents: wrong check for website in setSessionProductStore
> ------------------------------------------------------------------------------
>
> Key: OFBIZ-4744
> URL: https://issues.apache.org/jira/browse/OFBIZ-4744
> Project: OFBiz
> Issue Type: Bug
> Components: order, specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Reporter: Michael Brohl
> Assignee: Sascha Rodekamp
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4744_ProductStoreCartAwareEvents_wrong_check_for_website.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> There's a duplicate check if the productStore is null instead of checking productStore and website in ProductStoreCartAwareEvents.setSessionProductStore.
> I will provide a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4744) ProductStoreCartAwareEvents: wrong
check for website in setSessionProductStore
Posted by "Sascha Rodekamp (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sascha Rodekamp closed OFBIZ-4744.
----------------------------------
Resolution: Fixed
Fix Version/s: Release Branch 11.04
Release Branch 10.04
Thanks Michael,
your Patch is in
Trunk @Rev: 1306742
11.04 @Rev: 1306740
10.04 @Rev: 1306739
Have a good day!
> ProductStoreCartAwareEvents: wrong check for website in setSessionProductStore
> ------------------------------------------------------------------------------
>
> Key: OFBIZ-4744
> URL: https://issues.apache.org/jira/browse/OFBIZ-4744
> Project: OFBiz
> Issue Type: Bug
> Components: order, specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Reporter: Michael Brohl
> Assignee: Sascha Rodekamp
> Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk
>
> Attachments: OFBIZ-4744_ProductStoreCartAwareEvents_wrong_check_for_website.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> There's a duplicate check if the productStore is null instead of checking productStore and website in ProductStoreCartAwareEvents.setSessionProductStore.
> I will provide a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira