You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/26 18:37:44 UTC
[GitHub] [arrow-rs] alamb opened a new pull request, #1754: Rename `string_concat` to `concat_elements_utf8`
alamb opened a new pull request, #1754:
URL: https://github.com/apache/arrow-rs/pull/1754
# Which issue does this PR close?
re https://github.com/apache/arrow-rs/issues/1747
# Rationale for this change
Per suggestion from @tustvold here https://github.com/apache/arrow-rs/pull/1752#issuecomment-1138724644
The idea is to have a naming scheme that is consistent with other kernels such as `eq_utf8`
It also allows us to add a `concat_elements_dyn` to work with dynamic array types, which I will track in a moment
# What changes are included in this PR?
Rename `string_concat` to `concat_elements_utf8`
# Are there any user-facing changes?
No, code is not yet released
<!---
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on pull request #1754: Rename `string_concat` to `concat_elements_utf8`
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #1754:
URL: https://github.com/apache/arrow-rs/pull/1754#issuecomment-1139174789
lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] HaoYang670 commented on pull request #1754: Rename `string_concat` to `concat_elements_utf8`
Posted by GitBox <gi...@apache.org>.
HaoYang670 commented on PR #1754:
URL: https://github.com/apache/arrow-rs/pull/1754#issuecomment-1139189150
LGTM. A new compute kernel was born!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #1754: Rename `string_concat` to `concat_elements_utf8`
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #1754:
URL: https://github.com/apache/arrow-rs/pull/1754#issuecomment-1138947930
cc @HaoYang670 @tustvold and @viirya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #1754: Rename `string_concat` to `concat_elements_utf8`
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #1754:
URL: https://github.com/apache/arrow-rs/pull/1754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org