[GitHub] [submarine] rayray2002 commented on a change in pull request #775: SUBMARINE-1045. Add static type parameter in submarine-sdk

[GitBox <gi...@apache.org>]

rayray2002 commented on a change in pull request #775:
URL: https://github.com/apache/submarine/pull/775#discussion_r729950482



##########
File path: submarine-sdk/pysubmarine/submarine/experiment/api_client.py
##########
@@ -82,7 +82,12 @@ class ApiClient(object):
     _pool = None
 
     def __init__(
-        self, configuration=None, header_name=None, header_value=None, cookie=None, pool_threads=1
+        self,
+        configuration: Configuration = None,
+        header_name: str = None,

Review comment:
       fixed

##########
File path: submarine-sdk/pysubmarine/submarine/experiment/configuration.py
##########
@@ -70,12 +70,12 @@ class Configuration(object):
 
     def __init__(
         self,
-        host="http://localhost/api",
-        api_key=None,
-        api_key_prefix=None,
-        username=None,
-        password=None,
-        discard_unknown_keys=False,
+        host: str = "http://localhost/api",
+        api_key: dict = None,
+        api_key_prefix: dict = None,
+        username: str = None,

Review comment:
       fixed

##########
File path: submarine-sdk/pysubmarine/submarine/entities/model_registry/model_stages.py
##########
@@ -26,7 +26,7 @@
 _CANONICAL_MAPPING = {stage.lower(): stage for stage in ALL_STAGES}
 
 
-def get_canonical_stage(stage):
+def get_canonical_stage(stage: str):

Review comment:
       fixed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org