You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "stack (Created) (JIRA)" <ji...@apache.org> on 2012/01/06 07:39:39 UTC
[jira] [Created] (HBASE-5134) Remove geRegionServerWithoutRetries
and getRegionServerWithRetries from HConnection Interface
Remove geRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
---------------------------------------------------------------------------------------------
Key: HBASE-5134
URL: https://issues.apache.org/jira/browse/HBASE-5134
Project: HBase
Issue Type: Improvement
Reporter: stack
Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5134) Remove getRegionServerWithoutRetries
and getRegionServerWithRetries from HConnection Interface
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5134:
-------------------------
Attachment: 5134-v2.txt
v2 addresses Ted's javadoc comments (the javadoc was way off after moving the methods).
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Attachments: 5134-v2.txt
>
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5134) Remove
getRegionServerWithoutRetries and getRegionServerWithRetries from
HConnection Interface
Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183704#comment-13183704 ]
Lars Hofhansl commented on HBASE-5134:
--------------------------------------
+1 on v6
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.94.0
>
> Attachments: 5134-v2.txt, 5134-v3.txt, 5134-v4.txt, 5134-v5.txt, 5134-v6.txt, 5134-v6.txt
>
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5134) Remove getRegionServerWithoutRetries
and getRegionServerWithRetries from HConnection Interface
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5134:
-------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed trunk. Thanks for reviews lads.
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.94.0
>
> Attachments: 5134-v2.txt, 5134-v3.txt, 5134-v4.txt, 5134-v5.txt, 5134-v6.txt, 5134-v6.txt
>
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5134) Remove
getRegionServerWithoutRetries and getRegionServerWithRetries from
HConnection Interface
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181749#comment-13181749 ]
jiraposter@reviews.apache.org commented on HBASE-5134:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3419/#review4230
-----------------------------------------------------------
Ship it!
This is so much cleaner than before.
src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
<https://reviews.apache.org/r/3419/#comment9559>
+1 This does not belong here.
src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
<https://reviews.apache.org/r/3419/#comment9560>
nice!
src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
<https://reviews.apache.org/r/3419/#comment9561>
yep
src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
<https://reviews.apache.org/r/3419/#comment9562>
yes
src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
<https://reviews.apache.org/r/3419/#comment9563>
Why it this no longer needed?
- Lars
On 2012-01-07 00:51:43, Michael Stack wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3419/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-07 00:51:43)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Untangle HConnection. Makes it so I can mock scanning which wasn't
bq. possible when Callables had HConnections and HConnections had Callables.
bq. I want this so we can write tests around some of the interesting master fails
bq. we've seen of late; e.g. shutdown handler running at same time as a balance.
bq.
bq. With this change I can do things like standup an AssignmentManager and
bq. concurrently run a ServerShutdownHandler apart from their HMaster context;
bq. I can fake out the ServerShutdownHandler feeding it whatever for metarows, etc.
bq. Included are new tests that run an AssignmentManager#balance end-to-end and
bq. that put up a ServerShutdownHandler and run a server shutdown processing.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java
bq. Add a note that timeouts need fixup in here.
bq. Handle RetriesExhaustedException (Now we can mock at a lower-level
bq. than previous, below Callables where we used short-circuit them, we
bq. see Callable exceptions coming out in tests -- add handling).
bq.
bq. M src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java
bq. Callable retrying is done on the Callable now, not via HConnection.
bq.
bq. A src/main/java/org/apache/hadoop/hbase/client/ConnectionUtils.java
bq. Move common connection utility here, shared by HConnection and Callable.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/client/HConnection.java
bq. (getRegionServerWithRetries, getRegionServerWithoutRetries): deprecated.
bq. They are done on the Callable itself itself now.
bq. (clearCaches): Added.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
bq. (getPauseTime): Moved out to ConnectionUtils
bq. (getRegionServerWithRetries, getRegionServerWithoutRetries): deprecated.
bq. Changed body of methods to call new implementation.
bq. Removed dead code. Added doc and comments on other stuff to move.
bq. (translateException): Moved out to ServerCallable where its used.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/client/HTable.java
bq. Callable retrying is done on the Callable now, not via HConnection.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java
bq. Callable retrying is done on the Callable now, not via HConnection.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java
bq. (getConnection): Added
bq. (withRetries, withoutRetries): These replace old
bq. getRegionServerWithRetries, getRegionServerWithoutRetries that used to
bq. be done via HConnection.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/ipc/ExecRPCInvoker.java
bq. Callable retrying is done on the Callable now, not via HConnection.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
bq. Callable retrying is done on the Callable now, not via HConnection.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
bq. Comment.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegionHandler.java
bq. Comment.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java
bq. Make use of a data member previous unused.
bq.
bq. M src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java
bq. Callables are in the mix now so stuff gets retried. Deal with it.
bq.
bq. M src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java
bq. Add a method that mocks out more methods in a mocked HConnection.
bq.
bq. M src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java
bq. Comment.
bq.
bq. M src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java
bq. Add two tests, a testBalance and testServerShutdown
bq.
bq. M src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java
bq. Use new utility.
bq.
bq. M src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java
bq. Callables are in the mix now so stuff gets retried. Deal with it.
bq.
bq.
bq. This addresses bug HBASE-5134.
bq. https://issues.apache.org/jira/browse/HBASE-5134
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java 8ec5042
bq. src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java 6cdeec1
bq. src/main/java/org/apache/hadoop/hbase/client/ConnectionUtils.java PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/client/HConnection.java 0e78d96
bq. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 852a810
bq. src/main/java/org/apache/hadoop/hbase/client/HTable.java 839d79b
bq. src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java 4135e55
bq. src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java 9b568e3
bq. src/main/java/org/apache/hadoop/hbase/ipc/ExecRPCInvoker.java 3ad6cd5
bq. src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java bd574b2
bq. src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java d13daf0
bq. src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegionHandler.java 2dfc3e7
bq. src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java 2dd497b
bq. src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java dada051
bq. src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java c1a077f
bq. src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java 5e3e994
bq. src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java 82b32aa
bq. src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java c359f4b
bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java 0a34371
bq.
bq. Diff: https://reviews.apache.org/r/3419/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Michael
bq.
bq.
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5134) Remove
getRegionServerWithoutRetries and getRegionServerWithRetries from
HConnection Interface
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182880#comment-13182880 ]
Hadoop QA commented on HBASE-5134:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12509968/5134-v5.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 18 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/709//console
This message is automatically generated.
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.94.0
>
> Attachments: 5134-v2.txt, 5134-v3.txt, 5134-v4.txt, 5134-v5.txt
>
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5134) Remove getRegionServerWithoutRetries
and getRegionServerWithRetries from HConnection Interface
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5134:
-------------------------
Status: Patch Available (was: Open)
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.94.0
>
> Attachments: 5134-v2.txt, 5134-v3.txt, 5134-v4.txt, 5134-v5.txt, 5134-v6.txt
>
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5134) Remove
getRegionServerWithoutRetries and getRegionServerWithRetries from
HConnection Interface
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183452#comment-13183452 ]
Hadoop QA commented on HBASE-5134:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12509981/5134-v6.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 18 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -147 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 78 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/719//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/719//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/719//console
This message is automatically generated.
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.94.0
>
> Attachments: 5134-v2.txt, 5134-v3.txt, 5134-v4.txt, 5134-v5.txt, 5134-v6.txt, 5134-v6.txt
>
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5134) Remove
getRegionServerWithoutRetries and getRegionServerWithRetries from
HConnection Interface
Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181181#comment-13181181 ]
Lars Hofhansl commented on HBASE-5134:
--------------------------------------
+1... Didn't even realize that's what's happening. At least HConnectionImplementation and HTable do the right thing and pass themselves (HConnctionImpl) or the right HConnection (HTable) when creating the ServerCallable.
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5134) Remove
getRegionServerWithoutRetries and getRegionServerWithRetries from
HConnection Interface
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181795#comment-13181795 ]
Zhihong Yu commented on HBASE-5134:
-----------------------------------
Great work, Stack.
Still digesting the changes.
I think this should go in after 0.92 RC3 is cut so that patch testing is easier for the pending fixes toward 0.92.
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5134) Remove
getRegionServerWithoutRetries and getRegionServerWithRetries from
HConnection Interface
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181885#comment-13181885 ]
stack commented on HBASE-5134:
------------------------------
New version in morning; need to adjust a few mocks in TestAM.
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Attachments: 5134-v2.txt
>
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5134) Remove
getRegionServerWithoutRetries and getRegionServerWithRetries from
HConnection Interface
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183931#comment-13183931 ]
Hudson commented on HBASE-5134:
-------------------------------
Integrated in HBase-TRUNK-security #72 (See [https://builds.apache.org/job/HBase-TRUNK-security/72/])
HBASE-5134 Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/HBaseConfiguration.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/ConnectionUtils.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnection.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/ExecRPCInvoker.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegionHandler.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.94.0
>
> Attachments: 5134-v2.txt, 5134-v3.txt, 5134-v4.txt, 5134-v5.txt, 5134-v6.txt, 5134-v6.txt
>
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5134) Remove getRegionServerWithoutRetries
and getRegionServerWithRetries from HConnection Interface
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5134:
-------------------------
Attachment: 5134-v4.txt
No-prefix
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.94.0
>
> Attachments: 5134-v2.txt, 5134-v3.txt, 5134-v4.txt
>
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5134) Remove getRegionServerWithoutRetries
and getRegionServerWithRetries from HConnection Interface
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5134:
-------------------------
Attachment: 5134-v6.txt
no-prefix
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.94.0
>
> Attachments: 5134-v2.txt, 5134-v3.txt, 5134-v4.txt, 5134-v5.txt, 5134-v6.txt
>
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5134) Remove
getRegionServerWithoutRetries and getRegionServerWithRetries from
HConnection Interface
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181881#comment-13181881 ]
Hadoop QA commented on HBASE-5134:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12509771/5134-v2.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 18 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -147 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 78 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestAssignmentManager
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/695//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/695//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/695//console
This message is automatically generated.
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Attachments: 5134-v2.txt
>
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5134) Remove getRegionServerWithoutRetries
and getRegionServerWithRetries from HConnection Interface
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5134:
-------------------------
Status: Open (was: Patch Available)
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.94.0
>
> Attachments: 5134-v2.txt, 5134-v3.txt, 5134-v4.txt, 5134-v5.txt
>
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5134) Remove getRegionServerWithoutRetries
and getRegionServerWithRetries from HConnection Interface
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5134:
-------------------------
Status: Patch Available (was: Open)
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.94.0
>
> Attachments: 5134-v2.txt, 5134-v3.txt, 5134-v4.txt, 5134-v5.txt
>
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5134) Remove
getRegionServerWithoutRetries and getRegionServerWithRetries from
HConnection Interface
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182955#comment-13182955 ]
stack commented on HBASE-5134:
------------------------------
Thanks Zhihong. They pass locally. Let me retry a submission. How you tell they hung? You run a script against console output?
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.94.0
>
> Attachments: 5134-v2.txt, 5134-v3.txt, 5134-v4.txt, 5134-v5.txt, 5134-v6.txt, 5134-v6.txt
>
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5134) Remove
getRegionServerWithoutRetries and getRegionServerWithRetries from
HConnection Interface
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183462#comment-13183462 ]
stack commented on HBASE-5134:
------------------------------
I ran your script back to build 700 and every other test has a random hang, usually different each time.
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.94.0
>
> Attachments: 5134-v2.txt, 5134-v3.txt, 5134-v4.txt, 5134-v5.txt, 5134-v6.txt, 5134-v6.txt
>
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5134) Remove
getRegionServerWithoutRetries and getRegionServerWithRetries from
HConnection Interface
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182937#comment-13182937 ]
Zhihong Yu commented on HBASE-5134:
-----------------------------------
Two tests hung in PreCommit #710:
{code}
Hanging test: Running org.apache.hadoop.hbase.master.TestMasterRestartAfterDisablingTable
Hanging test: Running org.apache.hadoop.hbase.TestHBaseTestingUtility
{code}
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.94.0
>
> Attachments: 5134-v2.txt, 5134-v3.txt, 5134-v4.txt, 5134-v5.txt, 5134-v6.txt
>
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5134) Remove
getRegionServerWithoutRetries and getRegionServerWithRetries from
HConnection Interface
Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181750#comment-13181750 ]
Lars Hofhansl commented on HBASE-5134:
--------------------------------------
I think this is trunk only material, though.
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5134) Remove
getRegionServerWithoutRetries and getRegionServerWithRetries from
HConnection Interface
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182957#comment-13182957 ]
Zhihong Yu commented on HBASE-5134:
-----------------------------------
Yes, I have a script that can parse test output.
I can contribute that script if there is a proper JIRA.
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.94.0
>
> Attachments: 5134-v2.txt, 5134-v3.txt, 5134-v4.txt, 5134-v5.txt, 5134-v6.txt, 5134-v6.txt
>
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5134) Remove
getRegionServerWithoutRetries and getRegionServerWithRetries from
HConnection Interface
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183458#comment-13183458 ]
stack commented on HBASE-5134:
------------------------------
I ran your nice script Ted -- shall we check it in under ./dev-support? -- and it reports a new test hanging:
Hanging test: Running org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
... which also seems unrelated. Mind if I check in v6?
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.94.0
>
> Attachments: 5134-v2.txt, 5134-v3.txt, 5134-v4.txt, 5134-v5.txt, 5134-v6.txt, 5134-v6.txt
>
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5134) Remove getRegionServerWithoutRetries
and getRegionServerWithRetries from HConnection Interface
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5134:
-------------------------
Status: Patch Available (was: Open)
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.94.0
>
> Attachments: 5134-v2.txt, 5134-v3.txt, 5134-v4.txt
>
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5134) Remove getRegionServerWithoutRetries
and getRegionServerWithRetries from HConnection Interface
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5134:
-------------------------
Attachment: 5134-v6.txt
Retry v6 against hadoop qa
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.94.0
>
> Attachments: 5134-v2.txt, 5134-v3.txt, 5134-v4.txt, 5134-v5.txt, 5134-v6.txt, 5134-v6.txt
>
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5134) Remove
getRegionServerWithoutRetries and getRegionServerWithRetries from
HConnection Interface
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181737#comment-13181737 ]
stack commented on HBASE-5134:
------------------------------
Would be grand to get this into TRUNK. Could write tests that use it to prove patches for 0.92.
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5134) Remove getRegionServerWithoutRetries
and getRegionServerWithRetries from HConnection Interface
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5134:
-------------------------
Status: Open (was: Patch Available)
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.94.0
>
> Attachments: 5134-v2.txt, 5134-v3.txt, 5134-v4.txt, 5134-v5.txt, 5134-v6.txt
>
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5134) Remove
getRegionServerWithoutRetries and getRegionServerWithRetries from
HConnection Interface
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182920#comment-13182920 ]
Hadoop QA commented on HBASE-5134:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12509971/5134-v6.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 18 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -147 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 78 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/710//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/710//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/710//console
This message is automatically generated.
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.94.0
>
> Attachments: 5134-v2.txt, 5134-v3.txt, 5134-v4.txt, 5134-v5.txt, 5134-v6.txt
>
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5134) Remove
getRegionServerWithoutRetries and getRegionServerWithRetries from
HConnection Interface
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183068#comment-13183068 ]
Zhihong Yu commented on HBASE-5134:
-----------------------------------
Script has been attached to HBASE-4480
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.94.0
>
> Attachments: 5134-v2.txt, 5134-v3.txt, 5134-v4.txt, 5134-v5.txt, 5134-v6.txt, 5134-v6.txt
>
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5134) Remove getRegionServerWithoutRetries
and getRegionServerWithRetries from HConnection Interface
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5134:
-------------------------
Attachment: 5134-v3.txt
v3 is same as v2 except for one line change in TestAssignmentManager where I chance the generic params on a mocked method to be specific (The commit of Mings' new closeRegion method broke this). All good now.
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.94.0
>
> Attachments: 5134-v2.txt, 5134-v3.txt
>
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5134) Remove
getRegionServerWithoutRetries and getRegionServerWithRetries from
HConnection Interface
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182142#comment-13182142 ]
Hadoop QA commented on HBASE-5134:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12509808/5134-v3.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 18 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/698//console
This message is automatically generated.
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.94.0
>
> Attachments: 5134-v2.txt, 5134-v3.txt
>
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5134) Remove getRegionServerWithoutRetries
and getRegionServerWithRetries from HConnection Interface
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5134:
-------------------------
Fix Version/s: 0.94.0
Hadoop Flags: Reviewed
Status: Patch Available (was: Open)
Trying against hadoopqa to see what is broke.
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.94.0
>
> Attachments: 5134-v2.txt, 5134-v3.txt
>
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5134) Remove
getRegionServerWithoutRetries and getRegionServerWithRetries from
HConnection Interface
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181880#comment-13181880 ]
jiraposter@reviews.apache.org commented on HBASE-5134:
------------------------------------------------------
bq. On 2012-01-07 04:20:17, Ted Yu wrote:
bq. > src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java, line 142
bq. > <https://reviews.apache.org/r/3419/diff/1/?file=67031#file67031line142>
bq. >
bq. > 'Pass in a ServerCallable' should be removed.
Yes. This javadoc (and next method) is all wrong now its been moved and its context changed. Good one. Will fix in v2.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3419/#review4231
-----------------------------------------------------------
On 2012-01-07 00:51:43, Michael Stack wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3419/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-07 00:51:43)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Untangle HConnection. Makes it so I can mock scanning which wasn't
bq. possible when Callables had HConnections and HConnections had Callables.
bq. I want this so we can write tests around some of the interesting master fails
bq. we've seen of late; e.g. shutdown handler running at same time as a balance.
bq.
bq. With this change I can do things like standup an AssignmentManager and
bq. concurrently run a ServerShutdownHandler apart from their HMaster context;
bq. I can fake out the ServerShutdownHandler feeding it whatever for metarows, etc.
bq. Included are new tests that run an AssignmentManager#balance end-to-end and
bq. that put up a ServerShutdownHandler and run a server shutdown processing.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java
bq. Add a note that timeouts need fixup in here.
bq. Handle RetriesExhaustedException (Now we can mock at a lower-level
bq. than previous, below Callables where we used short-circuit them, we
bq. see Callable exceptions coming out in tests -- add handling).
bq.
bq. M src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java
bq. Callable retrying is done on the Callable now, not via HConnection.
bq.
bq. A src/main/java/org/apache/hadoop/hbase/client/ConnectionUtils.java
bq. Move common connection utility here, shared by HConnection and Callable.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/client/HConnection.java
bq. (getRegionServerWithRetries, getRegionServerWithoutRetries): deprecated.
bq. They are done on the Callable itself itself now.
bq. (clearCaches): Added.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
bq. (getPauseTime): Moved out to ConnectionUtils
bq. (getRegionServerWithRetries, getRegionServerWithoutRetries): deprecated.
bq. Changed body of methods to call new implementation.
bq. Removed dead code. Added doc and comments on other stuff to move.
bq. (translateException): Moved out to ServerCallable where its used.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/client/HTable.java
bq. Callable retrying is done on the Callable now, not via HConnection.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java
bq. Callable retrying is done on the Callable now, not via HConnection.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java
bq. (getConnection): Added
bq. (withRetries, withoutRetries): These replace old
bq. getRegionServerWithRetries, getRegionServerWithoutRetries that used to
bq. be done via HConnection.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/ipc/ExecRPCInvoker.java
bq. Callable retrying is done on the Callable now, not via HConnection.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
bq. Callable retrying is done on the Callable now, not via HConnection.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
bq. Comment.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegionHandler.java
bq. Comment.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java
bq. Make use of a data member previous unused.
bq.
bq. M src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java
bq. Callables are in the mix now so stuff gets retried. Deal with it.
bq.
bq. M src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java
bq. Add a method that mocks out more methods in a mocked HConnection.
bq.
bq. M src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java
bq. Comment.
bq.
bq. M src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java
bq. Add two tests, a testBalance and testServerShutdown
bq.
bq. M src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java
bq. Use new utility.
bq.
bq. M src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java
bq. Callables are in the mix now so stuff gets retried. Deal with it.
bq.
bq.
bq. This addresses bug HBASE-5134.
bq. https://issues.apache.org/jira/browse/HBASE-5134
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java 8ec5042
bq. src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java 6cdeec1
bq. src/main/java/org/apache/hadoop/hbase/client/ConnectionUtils.java PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/client/HConnection.java 0e78d96
bq. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 852a810
bq. src/main/java/org/apache/hadoop/hbase/client/HTable.java 839d79b
bq. src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java 4135e55
bq. src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java 9b568e3
bq. src/main/java/org/apache/hadoop/hbase/ipc/ExecRPCInvoker.java 3ad6cd5
bq. src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java bd574b2
bq. src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java d13daf0
bq. src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegionHandler.java 2dfc3e7
bq. src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java 2dd497b
bq. src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java dada051
bq. src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java c1a077f
bq. src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java 5e3e994
bq. src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java 82b32aa
bq. src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java c359f4b
bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java 0a34371
bq.
bq. Diff: https://reviews.apache.org/r/3419/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Michael
bq.
bq.
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Attachments: 5134-v2.txt
>
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5134) Remove
getRegionServerWithoutRetries and getRegionServerWithRetries from
HConnection Interface
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182163#comment-13182163 ]
Hadoop QA commented on HBASE-5134:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12509816/5134-v4.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 18 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -147 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 78 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery
org.apache.hadoop.hbase.TestDrainingServer
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/699//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/699//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/699//console
This message is automatically generated.
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.94.0
>
> Attachments: 5134-v2.txt, 5134-v3.txt, 5134-v4.txt
>
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5134) Remove
getRegionServerWithoutRetries and getRegionServerWithRetries from
HConnection Interface
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183463#comment-13183463 ]
Zhihong Yu commented on HBASE-5134:
-----------------------------------
Feel free to check the script under ./dev-support.
I think v6 is good to go.
Thanks
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.94.0
>
> Attachments: 5134-v2.txt, 5134-v3.txt, 5134-v4.txt, 5134-v5.txt, 5134-v6.txt, 5134-v6.txt
>
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5134) Remove getRegionServerWithoutRetries
and getRegionServerWithRetries from HConnection Interface
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5134:
-------------------------
Attachment: 5134-v5.txt
Fix the bulk load test (needed updating...)
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.94.0
>
> Attachments: 5134-v2.txt, 5134-v3.txt, 5134-v4.txt, 5134-v5.txt
>
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5134) Remove getRegionServerWithoutRetries
and getRegionServerWithRetries from HConnection Interface
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5134:
-------------------------
Assignee: stack
Status: Patch Available (was: Open)
Try against hadoopqa -- see whats broke.
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Attachments: 5134-v2.txt
>
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5134) Remove
getRegionServerWithoutRetries and getRegionServerWithRetries from
HConnection Interface
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181875#comment-13181875 ]
jiraposter@reviews.apache.org commented on HBASE-5134:
------------------------------------------------------
bq. On 2012-01-07 01:17:37, Lars Hofhansl wrote:
bq. > src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java, line 1653
bq. > <https://reviews.apache.org/r/3419/diff/1/?file=67028#file67028line1653>
bq. >
bq. > Why it this no longer needed?
Yeah. Its weird. Eclipse flagged it. And then I looked. There is a local variable set to null and its never changed. Then in this loop, we check if its non-null. One day the machines will write all of the the programs for us.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3419/#review4230
-----------------------------------------------------------
On 2012-01-07 00:51:43, Michael Stack wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3419/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-07 00:51:43)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Untangle HConnection. Makes it so I can mock scanning which wasn't
bq. possible when Callables had HConnections and HConnections had Callables.
bq. I want this so we can write tests around some of the interesting master fails
bq. we've seen of late; e.g. shutdown handler running at same time as a balance.
bq.
bq. With this change I can do things like standup an AssignmentManager and
bq. concurrently run a ServerShutdownHandler apart from their HMaster context;
bq. I can fake out the ServerShutdownHandler feeding it whatever for metarows, etc.
bq. Included are new tests that run an AssignmentManager#balance end-to-end and
bq. that put up a ServerShutdownHandler and run a server shutdown processing.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java
bq. Add a note that timeouts need fixup in here.
bq. Handle RetriesExhaustedException (Now we can mock at a lower-level
bq. than previous, below Callables where we used short-circuit them, we
bq. see Callable exceptions coming out in tests -- add handling).
bq.
bq. M src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java
bq. Callable retrying is done on the Callable now, not via HConnection.
bq.
bq. A src/main/java/org/apache/hadoop/hbase/client/ConnectionUtils.java
bq. Move common connection utility here, shared by HConnection and Callable.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/client/HConnection.java
bq. (getRegionServerWithRetries, getRegionServerWithoutRetries): deprecated.
bq. They are done on the Callable itself itself now.
bq. (clearCaches): Added.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
bq. (getPauseTime): Moved out to ConnectionUtils
bq. (getRegionServerWithRetries, getRegionServerWithoutRetries): deprecated.
bq. Changed body of methods to call new implementation.
bq. Removed dead code. Added doc and comments on other stuff to move.
bq. (translateException): Moved out to ServerCallable where its used.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/client/HTable.java
bq. Callable retrying is done on the Callable now, not via HConnection.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java
bq. Callable retrying is done on the Callable now, not via HConnection.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java
bq. (getConnection): Added
bq. (withRetries, withoutRetries): These replace old
bq. getRegionServerWithRetries, getRegionServerWithoutRetries that used to
bq. be done via HConnection.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/ipc/ExecRPCInvoker.java
bq. Callable retrying is done on the Callable now, not via HConnection.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
bq. Callable retrying is done on the Callable now, not via HConnection.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
bq. Comment.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegionHandler.java
bq. Comment.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java
bq. Make use of a data member previous unused.
bq.
bq. M src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java
bq. Callables are in the mix now so stuff gets retried. Deal with it.
bq.
bq. M src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java
bq. Add a method that mocks out more methods in a mocked HConnection.
bq.
bq. M src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java
bq. Comment.
bq.
bq. M src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java
bq. Add two tests, a testBalance and testServerShutdown
bq.
bq. M src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java
bq. Use new utility.
bq.
bq. M src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java
bq. Callables are in the mix now so stuff gets retried. Deal with it.
bq.
bq.
bq. This addresses bug HBASE-5134.
bq. https://issues.apache.org/jira/browse/HBASE-5134
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java 8ec5042
bq. src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java 6cdeec1
bq. src/main/java/org/apache/hadoop/hbase/client/ConnectionUtils.java PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/client/HConnection.java 0e78d96
bq. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 852a810
bq. src/main/java/org/apache/hadoop/hbase/client/HTable.java 839d79b
bq. src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java 4135e55
bq. src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java 9b568e3
bq. src/main/java/org/apache/hadoop/hbase/ipc/ExecRPCInvoker.java 3ad6cd5
bq. src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java bd574b2
bq. src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java d13daf0
bq. src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegionHandler.java 2dfc3e7
bq. src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java 2dd497b
bq. src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java dada051
bq. src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java c1a077f
bq. src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java 5e3e994
bq. src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java 82b32aa
bq. src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java c359f4b
bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java 0a34371
bq.
bq. Diff: https://reviews.apache.org/r/3419/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Michael
bq.
bq.
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5134) Remove getRegionServerWithoutRetries
and getRegionServerWithRetries from HConnection Interface
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5134:
-------------------------
Status: Patch Available (was: Open)
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.94.0
>
> Attachments: 5134-v2.txt, 5134-v3.txt, 5134-v4.txt, 5134-v5.txt, 5134-v6.txt, 5134-v6.txt
>
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5134) Remove getRegionServerWithoutRetries
and getRegionServerWithRetries from HConnection Interface
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5134:
-------------------------
Status: Open (was: Patch Available)
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Attachments: 5134-v2.txt, 5134-v3.txt
>
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5134) Remove
getRegionServerWithoutRetries and getRegionServerWithRetries from
HConnection Interface
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181739#comment-13181739 ]
jiraposter@reviews.apache.org commented on HBASE-5134:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3419/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
Untangle HConnection. Makes it so I can mock scanning which wasn't
possible when Callables had HConnections and HConnections had Callables.
I want this so we can write tests around some of the interesting master fails
we've seen of late; e.g. shutdown handler running at same time as a balance.
With this change I can do things like standup an AssignmentManager and
concurrently run a ServerShutdownHandler apart from their HMaster context;
I can fake out the ServerShutdownHandler feeding it whatever for metarows, etc.
Included are new tests that run an AssignmentManager#balance end-to-end and
that put up a ServerShutdownHandler and run a server shutdown processing.
M src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java
Add a note that timeouts need fixup in here.
Handle RetriesExhaustedException (Now we can mock at a lower-level
than previous, below Callables where we used short-circuit them, we
see Callable exceptions coming out in tests -- add handling).
M src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java
Callable retrying is done on the Callable now, not via HConnection.
A src/main/java/org/apache/hadoop/hbase/client/ConnectionUtils.java
Move common connection utility here, shared by HConnection and Callable.
M src/main/java/org/apache/hadoop/hbase/client/HConnection.java
(getRegionServerWithRetries, getRegionServerWithoutRetries): deprecated.
They are done on the Callable itself itself now.
(clearCaches): Added.
M src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
(getPauseTime): Moved out to ConnectionUtils
(getRegionServerWithRetries, getRegionServerWithoutRetries): deprecated.
Changed body of methods to call new implementation.
Removed dead code. Added doc and comments on other stuff to move.
(translateException): Moved out to ServerCallable where its used.
M src/main/java/org/apache/hadoop/hbase/client/HTable.java
Callable retrying is done on the Callable now, not via HConnection.
M src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java
Callable retrying is done on the Callable now, not via HConnection.
M src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java
(getConnection): Added
(withRetries, withoutRetries): These replace old
getRegionServerWithRetries, getRegionServerWithoutRetries that used to
be done via HConnection.
M src/main/java/org/apache/hadoop/hbase/ipc/ExecRPCInvoker.java
Callable retrying is done on the Callable now, not via HConnection.
M src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
Callable retrying is done on the Callable now, not via HConnection.
M src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
Comment.
M src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegionHandler.java
Comment.
M src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java
Make use of a data member previous unused.
M src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java
Callables are in the mix now so stuff gets retried. Deal with it.
M src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java
Add a method that mocks out more methods in a mocked HConnection.
M src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java
Comment.
M src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java
Add two tests, a testBalance and testServerShutdown
M src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java
Use new utility.
M src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java
Callables are in the mix now so stuff gets retried. Deal with it.
This addresses bug HBASE-5134.
https://issues.apache.org/jira/browse/HBASE-5134
Diffs
-----
src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java 8ec5042
src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java 6cdeec1
src/main/java/org/apache/hadoop/hbase/client/ConnectionUtils.java PRE-CREATION
src/main/java/org/apache/hadoop/hbase/client/HConnection.java 0e78d96
src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 852a810
src/main/java/org/apache/hadoop/hbase/client/HTable.java 839d79b
src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java 4135e55
src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java 9b568e3
src/main/java/org/apache/hadoop/hbase/ipc/ExecRPCInvoker.java 3ad6cd5
src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java bd574b2
src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java d13daf0
src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegionHandler.java 2dfc3e7
src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java 2dd497b
src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java dada051
src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java c1a077f
src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java 5e3e994
src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java 82b32aa
src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java c359f4b
src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java 0a34371
Diff: https://reviews.apache.org/r/3419/diff
Testing
-------
Thanks,
Michael
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5134) Remove
getRegionServerWithoutRetries and getRegionServerWithRetries from
HConnection Interface
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181848#comment-13181848 ]
jiraposter@reviews.apache.org commented on HBASE-5134:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3419/#review4231
-----------------------------------------------------------
src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java
<https://reviews.apache.org/r/3419/#comment9565>
'Pass in a ServerCallable' should be removed.
src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java
<https://reviews.apache.org/r/3419/#comment9564>
This line seems unnecessary.
- Ted
On 2012-01-07 00:51:43, Michael Stack wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3419/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-07 00:51:43)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Untangle HConnection. Makes it so I can mock scanning which wasn't
bq. possible when Callables had HConnections and HConnections had Callables.
bq. I want this so we can write tests around some of the interesting master fails
bq. we've seen of late; e.g. shutdown handler running at same time as a balance.
bq.
bq. With this change I can do things like standup an AssignmentManager and
bq. concurrently run a ServerShutdownHandler apart from their HMaster context;
bq. I can fake out the ServerShutdownHandler feeding it whatever for metarows, etc.
bq. Included are new tests that run an AssignmentManager#balance end-to-end and
bq. that put up a ServerShutdownHandler and run a server shutdown processing.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java
bq. Add a note that timeouts need fixup in here.
bq. Handle RetriesExhaustedException (Now we can mock at a lower-level
bq. than previous, below Callables where we used short-circuit them, we
bq. see Callable exceptions coming out in tests -- add handling).
bq.
bq. M src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java
bq. Callable retrying is done on the Callable now, not via HConnection.
bq.
bq. A src/main/java/org/apache/hadoop/hbase/client/ConnectionUtils.java
bq. Move common connection utility here, shared by HConnection and Callable.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/client/HConnection.java
bq. (getRegionServerWithRetries, getRegionServerWithoutRetries): deprecated.
bq. They are done on the Callable itself itself now.
bq. (clearCaches): Added.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
bq. (getPauseTime): Moved out to ConnectionUtils
bq. (getRegionServerWithRetries, getRegionServerWithoutRetries): deprecated.
bq. Changed body of methods to call new implementation.
bq. Removed dead code. Added doc and comments on other stuff to move.
bq. (translateException): Moved out to ServerCallable where its used.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/client/HTable.java
bq. Callable retrying is done on the Callable now, not via HConnection.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java
bq. Callable retrying is done on the Callable now, not via HConnection.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java
bq. (getConnection): Added
bq. (withRetries, withoutRetries): These replace old
bq. getRegionServerWithRetries, getRegionServerWithoutRetries that used to
bq. be done via HConnection.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/ipc/ExecRPCInvoker.java
bq. Callable retrying is done on the Callable now, not via HConnection.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
bq. Callable retrying is done on the Callable now, not via HConnection.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
bq. Comment.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegionHandler.java
bq. Comment.
bq.
bq. M src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java
bq. Make use of a data member previous unused.
bq.
bq. M src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java
bq. Callables are in the mix now so stuff gets retried. Deal with it.
bq.
bq. M src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java
bq. Add a method that mocks out more methods in a mocked HConnection.
bq.
bq. M src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java
bq. Comment.
bq.
bq. M src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java
bq. Add two tests, a testBalance and testServerShutdown
bq.
bq. M src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java
bq. Use new utility.
bq.
bq. M src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java
bq. Callables are in the mix now so stuff gets retried. Deal with it.
bq.
bq.
bq. This addresses bug HBASE-5134.
bq. https://issues.apache.org/jira/browse/HBASE-5134
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java 8ec5042
bq. src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java 6cdeec1
bq. src/main/java/org/apache/hadoop/hbase/client/ConnectionUtils.java PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/client/HConnection.java 0e78d96
bq. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 852a810
bq. src/main/java/org/apache/hadoop/hbase/client/HTable.java 839d79b
bq. src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java 4135e55
bq. src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java 9b568e3
bq. src/main/java/org/apache/hadoop/hbase/ipc/ExecRPCInvoker.java 3ad6cd5
bq. src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java bd574b2
bq. src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java d13daf0
bq. src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegionHandler.java 2dfc3e7
bq. src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java 2dd497b
bq. src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java dada051
bq. src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java c1a077f
bq. src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java 5e3e994
bq. src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java 82b32aa
bq. src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java c359f4b
bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java 0a34371
bq.
bq. Diff: https://reviews.apache.org/r/3419/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Michael
bq.
bq.
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5134) Remove getRegionServerWithoutRetries
and getRegionServerWithRetries from HConnection Interface
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5134:
-------------------------
Status: Open (was: Patch Available)
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.94.0
>
> Attachments: 5134-v2.txt, 5134-v3.txt, 5134-v4.txt
>
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5134) Remove getRegionServerWithoutRetries
and getRegionServerWithRetries from HConnection Interface
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5134:
-------------------------
Status: Open (was: Patch Available)
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.94.0
>
> Attachments: 5134-v2.txt, 5134-v3.txt, 5134-v4.txt, 5134-v5.txt, 5134-v6.txt, 5134-v6.txt
>
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5134) Remove
getRegionServerWithoutRetries and getRegionServerWithRetries from
HConnection Interface
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183974#comment-13183974 ]
Hudson commented on HBASE-5134:
-------------------------------
Integrated in HBase-TRUNK #2617 (See [https://builds.apache.org/job/HBase-TRUNK/2617/])
HBASE-5134 Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/HBaseConfiguration.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/ConnectionUtils.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnection.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/ExecRPCInvoker.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegionHandler.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.94.0
>
> Attachments: 5134-v2.txt, 5134-v3.txt, 5134-v4.txt, 5134-v5.txt, 5134-v6.txt, 5134-v6.txt
>
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5134) Remove getRegionServerWithoutRetries
and getRegionServerWithRetries from HConnection Interface
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5134:
-------------------------
Summary: Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface (was: Remove geRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface)
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5134) Remove
getRegionServerWithoutRetries and getRegionServerWithRetries from
HConnection Interface
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182969#comment-13182969 ]
stack commented on HBASE-5134:
------------------------------
Zhihong: Yeah, put up the script please.
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.94.0
>
> Attachments: 5134-v2.txt, 5134-v3.txt, 5134-v4.txt, 5134-v5.txt, 5134-v6.txt, 5134-v6.txt
>
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5134) Remove
getRegionServerWithoutRetries and getRegionServerWithRetries from
HConnection Interface
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182933#comment-13182933 ]
stack commented on HBASE-5134:
------------------------------
I'll commit this soon unless objection. The above three failures are the usual suspects.
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.94.0
>
> Attachments: 5134-v2.txt, 5134-v3.txt, 5134-v4.txt, 5134-v5.txt, 5134-v6.txt
>
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira