You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by tillkahlbrock <gi...@git.apache.org> on 2015/04/30 09:55:56 UTC
[GitHub] couchdb pull request: installs npm while building the docker image...
GitHub user tillkahlbrock opened a pull request:
https://github.com/apache/couchdb/pull/318
installs npm while building the docker images
Building the docker image fails with
```
/bin/sh: 1: npm: not found
make: *** [share/www] Error 127
```
because `npm` is used in the Makefile and therefor is a dependency for building a docker image.
This change installs npm while building the image according to https://github.com/joyent/node/wiki/Backports.debian.org#install-node-and-npm
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillkahlbrock/couchdb npm-in-docker-image
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb/pull/318.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #318
----
commit 0287af3b838ee23c4c30a26358a9f4aba3819f4c
Author: Till Kahlbrock <ti...@jimdo.com>
Date: 2015-04-30T07:26:30Z
installs npm while building the docker images
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: installs npm while building the docker image...
Posted by tillkahlbrock <gi...@git.apache.org>.
Github user tillkahlbrock closed the pull request at:
https://github.com/apache/couchdb/pull/318
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: installs npm while building the docker image...
Posted by klaemo <gi...@git.apache.org>.
Github user klaemo commented on the pull request:
https://github.com/apache/couchdb/pull/318#issuecomment-166319800
Can this be closed in favor of #340?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: installs npm while building the docker image...
Posted by till <gi...@git.apache.org>.
Github user till commented on the pull request:
https://github.com/apache/couchdb/pull/318#issuecomment-97705547
@tillkahlbrock — Hey, first of, great choice of first name. ;) Then, I was wondering, is it a good idea to install the latest npm always? It could lead to unexpected breakage in the build script.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: installs npm while building the docker image...
Posted by tillkahlbrock <gi...@git.apache.org>.
Github user tillkahlbrock commented on the pull request:
https://github.com/apache/couchdb/pull/318#issuecomment-98082875
Thanks for pointing that out @kxepal. I will take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: installs npm while building the docker image...
Posted by tillkahlbrock <gi...@git.apache.org>.
Github user tillkahlbrock commented on the pull request:
https://github.com/apache/couchdb/pull/318#issuecomment-166387945
@klaemo yes (afaik)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: installs npm while building the docker image...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb/pull/318#issuecomment-97883660
Hi @tillkahlbrock ! Thanks you contribution. Unfortunately (well, actually, fortunately - it depends) we're going to deprecate our Dockerfile in favour is contribution of @klaemo ones. See https://github.com/klaemo/docker-couchdb/issues/22 for more information.
AFAIK, the process now on the paper work stage in order to get the code over the ASF IP Clearance procedure.
The best way to go for now, suppose, is to check is docker-couchdb project needs in your changes. If it's not - all fine, just use it and wait for a while. Otherwise feel free to help it and be sure - your contribution won't get lost (:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: installs npm while building the docker image...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb/pull/318#issuecomment-136980149
@snowch see also #340
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: installs npm while building the docker image...
Posted by snowch <gi...@git.apache.org>.
Github user snowch commented on the pull request:
https://github.com/apache/couchdb/pull/318#issuecomment-136939962
@kxepal - Can the deprecated Dockerfile be removed? It's harmful leaving it in while it is broken, as it will just end up wasting dev's time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: installs npm while building the docker image...
Posted by tillkahlbrock <gi...@git.apache.org>.
Github user tillkahlbrock commented on the pull request:
https://github.com/apache/couchdb/pull/318#issuecomment-97825158
I guess you're write. I fix this here https://github.com/tillkahlbrock/couchdb/commit/ef202f8db48b66e6e2bb9e750a362641df469096#diff-3254677a7917c6c01f55212f86c57fbfR23
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---