You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2022/05/05 20:40:21 UTC

[GitHub] [thrift] ctubbsii commented on a diff in pull request #2583: THRIFT-5570: update java lib document about gradle usage

ctubbsii commented on code in PR #2583:
URL: https://github.com/apache/thrift/pull/2583#discussion_r866294649


##########
lib/java/.gitignore:
##########
@@ -0,0 +1,53 @@
+# Created by https://www.toptal.com/developers/gitignore/api/java,gradle
+# Edit at https://www.toptal.com/developers/gitignore?templates=java,gradle
+

Review Comment:
   This change adds a new .gitignore file in the lib/java directory. This is consistent with the recently added one for lib/kotlin. However, they do differ in some ways. And, a lot of this is redundant with the top-level .gitignore file.
   
   I think it'd be better to remove both of these .gitignore files and add the relevant patterns into the .gitignore file at the root of the repository, rather than add this here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org