[GitHub] [ozone] JacksonYao287 removed a comment on pull request #2172: HDDS-5126. Recon should check new containers of a container report with batch

[GitBox <gi...@apache.org>]

JacksonYao287 removed a comment on pull request #2172:
URL: https://github.com/apache/ozone/pull/2172#issuecomment-834182214


   > @avijayanhwx Thanks for the review. I think we can keep the following check.
   > 
   > ```
   >       if (!containerExist(containerID)) {
   >         addNewContainer(containerID.getId(), containerWithPipeline);
   >       }
   > ```
   > 
   > Since the inner check @JacksonYao287 mentioned would involve additional write lock operations.
   
   @avijayanhwx @GlenGeng  what is your opinion
   
   > @avijayanhwx Thanks for the review. I think we can keep the following check.
   > 
   > ```
   >       if (!containerExist(containerID)) {
   >         addNewContainer(containerID.getId(), containerWithPipeline);
   >       }
   > ```
   > 
   > Since the inner check @JacksonYao287 mentioned would involve additional write lock operations.
   
   @avijayanhwx  what is you opinion about this? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org