You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@griffin.apache.org by Tushar Patil <tu...@gmail.com> on 2019/12/24 14:00:55 UTC
Code merge policy
Hi,
I recently contributed to griffin project, PR request got merged to master but contributor list is not showing my username.
I observed that PR closed with unmerged commits. We should make standard process for this.
Regards,
Tushar
Re: Code merge policy
Posted by William Guo <gu...@apache.org>.
hi Tushar,
I don't see your name in contributors.
Could you check whether the email address in your commit is the exactly
same as the email from github.
https://github.com/settings/emails
I checked your commit and cannot find your email address in it.
Author: tusharpatil20 <35...@users.noreply.github.com>
you need to run git config user.email to set this.
But we cannot change griffin git commit history, so you have to push
another PR to make your name in contributors.
Thanks,
William
On Wed, Dec 25, 2019 at 1:29 PM Tushar Patil <tu...@gmail.com>
wrote:
> Hi William,
>
> Please find below link for your reference,
>
> https://github.com/apache/griffin/pull/558
>
> Regards,
> Tushar
>
> On Wed, Dec 25, 2019 at 10:15 AM Chitral Verma <ch...@gmail.com>
> wrote:
>
> > Hi William,
> > It's the same with me also, attaching screenshot for your reference.
> >
> > https://github.com/apache/griffin/pull/56
> >
> > Regards,
> > Chitral Verma
> >
> > On Wed, 25 Dec, 2019, 08:54 William Guo, <gu...@apache.org> wrote:
> >
> >> hi Tushar,
> >>
> >> Could you tell me your PR and your commit, so I can follow your
> question.
> >>
> >> Thanks,
> >> William
> >>
> >> On Tue, Dec 24, 2019 at 10:01 PM Tushar Patil <
> >> tushar.opensource90@gmail.com>
> >> wrote:
> >>
> >> > Hi,
> >> >
> >> > I recently contributed to griffin project, PR request got merged to
> >> master
> >> > but contributor list is not showing my username.
> >> >
> >> > I observed that PR closed with unmerged commits. We should make
> standard
> >> > process for this.
> >> >
> >> > Regards,
> >> > Tushar
> >>
> >
>
Re: Code merge policy
Posted by Tushar Patil <tu...@gmail.com>.
Hi William,
Please find below link for your reference,
https://github.com/apache/griffin/pull/558
Regards,
Tushar
On Wed, Dec 25, 2019 at 10:15 AM Chitral Verma <ch...@gmail.com>
wrote:
> Hi William,
> It's the same with me also, attaching screenshot for your reference.
>
> https://github.com/apache/griffin/pull/56
>
> Regards,
> Chitral Verma
>
> On Wed, 25 Dec, 2019, 08:54 William Guo, <gu...@apache.org> wrote:
>
>> hi Tushar,
>>
>> Could you tell me your PR and your commit, so I can follow your question.
>>
>> Thanks,
>> William
>>
>> On Tue, Dec 24, 2019 at 10:01 PM Tushar Patil <
>> tushar.opensource90@gmail.com>
>> wrote:
>>
>> > Hi,
>> >
>> > I recently contributed to griffin project, PR request got merged to
>> master
>> > but contributor list is not showing my username.
>> >
>> > I observed that PR closed with unmerged commits. We should make standard
>> > process for this.
>> >
>> > Regards,
>> > Tushar
>>
>
Re: Code merge policy
Posted by William Guo <gu...@apache.org>.
hi Verma,
I have seen your name in contributors in griffin repo,
https://github.com/apache/griffin/graphs/contributors
Thanks,
William
On Wed, Dec 25, 2019 at 12:45 PM Chitral Verma <ch...@gmail.com>
wrote:
> Hi William,
> It's the same with me also, attaching screenshot for your reference.
>
> https://github.com/apache/griffin/pull/56
>
> Regards,
> Chitral Verma
>
> On Wed, 25 Dec, 2019, 08:54 William Guo, <gu...@apache.org> wrote:
>
>> hi Tushar,
>>
>> Could you tell me your PR and your commit, so I can follow your question.
>>
>> Thanks,
>> William
>>
>> On Tue, Dec 24, 2019 at 10:01 PM Tushar Patil <
>> tushar.opensource90@gmail.com>
>> wrote:
>>
>> > Hi,
>> >
>> > I recently contributed to griffin project, PR request got merged to
>> master
>> > but contributor list is not showing my username.
>> >
>> > I observed that PR closed with unmerged commits. We should make standard
>> > process for this.
>> >
>> > Regards,
>> > Tushar
>>
>
Re: Code merge policy
Posted by Chitral Verma <ch...@gmail.com>.
Hi William,
It's the same with me also, attaching screenshot for your reference.
https://github.com/apache/griffin/pull/56
Regards,
Chitral Verma
On Wed, 25 Dec, 2019, 08:54 William Guo, <gu...@apache.org> wrote:
> hi Tushar,
>
> Could you tell me your PR and your commit, so I can follow your question.
>
> Thanks,
> William
>
> On Tue, Dec 24, 2019 at 10:01 PM Tushar Patil <
> tushar.opensource90@gmail.com>
> wrote:
>
> > Hi,
> >
> > I recently contributed to griffin project, PR request got merged to
> master
> > but contributor list is not showing my username.
> >
> > I observed that PR closed with unmerged commits. We should make standard
> > process for this.
> >
> > Regards,
> > Tushar
>
Re: Code merge policy
Posted by William Guo <gu...@apache.org>.
hi Tushar,
Could you tell me your PR and your commit, so I can follow your question.
Thanks,
William
On Tue, Dec 24, 2019 at 10:01 PM Tushar Patil <tu...@gmail.com>
wrote:
> Hi,
>
> I recently contributed to griffin project, PR request got merged to master
> but contributor list is not showing my username.
>
> I observed that PR closed with unmerged commits. We should make standard
> process for this.
>
> Regards,
> Tushar
Re:Code merge policy
Posted by 万昆 <wa...@163.com>.
Hi, Tushar
There are many contributors to Apache Griffin project, so we don't have a list of contributors, but if you can continue to provide PR for a while, you will be invited to be a committer, and you can see your name on the website.
Your PR had been closed and merged into master branch .
Can you tell me where you see the status of unmerged ?
At 2019-12-24 22:00:55, "Tushar Patil" <tu...@gmail.com> wrote:
>Hi,
>
>I recently contributed to griffin project, PR request got merged to master but contributor list is not showing my username.
>
>I observed that PR closed with unmerged commits. We should make standard process for this.
>
>Regards,
>Tushar