You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/01 15:46:10 UTC
[GitHub] [superset] hughhhh commented on a change in pull request #14881: feat: Database Connection UI
hughhhh commented on a change in pull request #14881:
URL: https://github.com/apache/superset/pull/14881#discussion_r662404481
##########
File path: superset/config.py
##########
@@ -1085,10 +1085,10 @@ def CSV_TO_HIVE_UPLOAD_DIRECTORY_FUNC(
# use the "engine_name" attribute of the corresponding DB engine spec
# in `superset/db_engine_specs/`.
PREFERRED_DATABASES: List[str] = [
- # "PostgreSQL",
- # "Presto",
- # "MySQL",
- # "SQLite",
+ "PostgreSQL",
+ "Presto",
+ "MySQL",
+ "SQLite",
# etc.
Review comment:
I think these are fine for now
@yousoph what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org