You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Brett Porter <bp...@f2network.com.au> on 2003/10/09 02:15:15 UTC
RE: cvs commit: maven/src/java/org/apache/maven/jelly/tags/maven
RootRelativePathTag.java MavenTagLibrary.java
This fix came with switching from projectBeanReader to getProject, but a
consequence was that the expressions were evaluated in the wrong order so I
took it back out.
I'm pretty confident I can add it back in as I clean this stuff up - sorry I
haven't had a chance to look at it again this week. The only failures at the
moment are in the touchstone tests.
I think this tag should probably not be used as the other workaround does
this.
Cheers,
Brett
> -----Original Message-----
> From: Jason van Zyl [mailto:jvanzyl@maven.org]
> Sent: Thursday, 9 October 2003 5:48 AM
> To: Maven Developers List
> Subject: Re: cvs commit:
> maven/src/java/org/apache/maven/jelly/tags/maven
> RootRelativePathTag.java MavenTagLibrary.java
>
>
> On Wed, 2003-10-08 at 19:44, vmassol@apache.org wrote:
> > vmassol 2003/10/08 16:44:04
> >
> > Modified: src/java/org/apache/maven/jelly/tags/maven
> > MavenTagLibrary.java
> > Added: src/test/java/org/apache/maven/jelly/tags/maven
> > RootRelativePathTagTest.java
> > src/java/org/apache/maven/jelly/tags/maven
> > RootRelativePathTag.java
> > Log:
> > Added new tag which can be used to implement property inheritance
> > while waiting for the final fix in maven 2.0...
>
> I'm not sure how much code Brett has integrated but I believe
> he integrated code that will take care of this. I certainly
> wasn't planning on waiting until 2.0 to fix this, just post
> 1.0. If he's got it working then I would certainly like to
> use that and not encourage what you just suggested.
>
> Brett how you making out on integrating that code?
>
> > --
> > jvz.
> >
> > Jason van Zyl
> > jason@zenplex.com
> > http://tambora.zenplex.org
> >
> > In short, man creates for himself a new religion of a rational and
> > technical order to justify his work and to be justified in it.
> >
> > -- Jacques Ellul, The Technological Society
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
RE: cvs commit: maven/src/java/org/apache/maven/jelly/tags/maven RootRelativePathTag.java MavenTagLibrary.java
Posted by Vincent Massol <vm...@pivolis.com>.
> -----Original Message-----
> From: Brett Porter [mailto:bporter@f2network.com.au]
> Sent: 09 October 2003 02:15
> To: 'Maven Developers List'
> Subject: RE: cvs commit:
maven/src/java/org/apache/maven/jelly/tags/maven
> RootRelativePathTag.java MavenTagLibrary.java
>
> This fix came with switching from projectBeanReader to getProject, but
a
> consequence was that the expressions were evaluated in the wrong order
so
> I
> took it back out.
>
> I'm pretty confident I can add it back in as I clean this stuff up -
sorry
> I
> haven't had a chance to look at it again this week. The only failures
at
> the
> moment are in the touchstone tests.
>
> I think this tag should probably not be used as the other workaround
does
> this.
+1 to remove it when you add the code back. I was simply not aware we
were that close to get property inheritance. That's very cool :-)
Thanks
-Vincent
>
> Cheers,
> Brett
>
> > -----Original Message-----
> > From: Jason van Zyl [mailto:jvanzyl@maven.org]
> > Sent: Thursday, 9 October 2003 5:48 AM
> > To: Maven Developers List
> > Subject: Re: cvs commit:
> > maven/src/java/org/apache/maven/jelly/tags/maven
> > RootRelativePathTag.java MavenTagLibrary.java
> >
> >
> > On Wed, 2003-10-08 at 19:44, vmassol@apache.org wrote:
> > > vmassol 2003/10/08 16:44:04
> > >
> > > Modified: src/java/org/apache/maven/jelly/tags/maven
> > > MavenTagLibrary.java
> > > Added: src/test/java/org/apache/maven/jelly/tags/maven
> > > RootRelativePathTagTest.java
> > > src/java/org/apache/maven/jelly/tags/maven
> > > RootRelativePathTag.java
> > > Log:
> > > Added new tag which can be used to implement property
inheritance
> > > while waiting for the final fix in maven 2.0...
> >
> > I'm not sure how much code Brett has integrated but I believe
> > he integrated code that will take care of this. I certainly
> > wasn't planning on waiting until 2.0 to fix this, just post
> > 1.0. If he's got it working then I would certainly like to
> > use that and not encourage what you just suggested.
> >
> > Brett how you making out on integrating that code?
> >
> > > --
> > > jvz.
> > >
> > > Jason van Zyl
> > > jason@zenplex.com
> > > http://tambora.zenplex.org
> > >
> > > In short, man creates for himself a new religion of a rational and
> > > technical order to justify his work and to be justified in it.
> > >
> > > -- Jacques Ellul, The Technological Society
> >
> >
> >
---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org